Re: [RFC][PATCH 16/42] now we can fold open_check_o_direct() into do_dentry_open()

On Tue, Jul 10, 2018 at 7:59 PM Al Viro wrote: > > Umm... Something like [..] Ack. Linus

Re: [RFC][PATCH 16/42] now we can fold open_check_o_direct() into do_dentry_open()

On Tue, Jul 10, 2018 at 07:44:59PM -0700, Linus Torvalds wrote: > I like the patch, I hate the commit message. > > It makes sense right now in this sequence, but I'd really like the > commit message to say _why_ this sequence led up to this point. > > Right now I still remember you trying this, a

Re: [RFC][PATCH 16/42] now we can fold open_check_o_direct() into do_dentry_open()

I like the patch, I hate the commit message. It makes sense right now in this sequence, but I'd really like the commit message to say _why_ this sequence led up to this point. Right now I still remember you trying this, and having to revert it because it didn't work before all the fput/put_filp i

[RFC][PATCH 16/42] now we can fold open_check_o_direct() into do_dentry_open()

From: Al Viro Signed-off-by: Al Viro --- fs/internal.h | 1 - fs/namei.c| 7 +-- fs/open.c | 17 + 3 files changed, 6 insertions(+), 19 deletions(-) diff --git a/fs/internal.h b/fs/internal.h index ab84a29f4874..33a28438570e 100644 --- a/fs/internal.h +++ b/fs/int