Re: [RFC][PATCH 2/3] exec: Simplify unshare_files

2018-09-17 Thread Eric W. Biederman
Oleg Nesterov writes: > absolutely off-topic question, > > On 09/16, Eric W. Biederman wrote: >> >> @@ -747,11 +746,9 @@ void do_coredump(const siginfo_t *siginfo) >> } >> >> /* get us an unshared descriptor table; almost always a no-op */ >> -retval = unshare_files(&displaced); >>

Re: [RFC][PATCH 2/3] exec: Simplify unshare_files

2018-09-17 Thread Oleg Nesterov
absolutely off-topic question, On 09/16, Eric W. Biederman wrote: > > @@ -747,11 +746,9 @@ void do_coredump(const siginfo_t *siginfo) > } > > /* get us an unshared descriptor table; almost always a no-op */ > - retval = unshare_files(&displaced); > + retval = unshare_files();

[RFC][PATCH 2/3] exec: Simplify unshare_files

2018-09-16 Thread Eric W. Biederman
Now that exec calls unshare_files after the point of no return there is no reason to return displaced. Signed-off-by: "Eric W. Biederman" --- fs/coredump.c | 5 + fs/exec.c | 5 + include/linux/fdtable.h | 2 +- kernel/fork.c | 12 ++-- 4 fi