Re: [RFC][PATCH 2/5 v2] tracing: Create seq_buf layer in trace_seq

2014-09-26 Thread Petr Mladek
On Fri 26-09-14 11:00:43, Steven Rostedt wrote: > As people are asking for this patch series to be added, I'm going back > through your comments. I never replied to this email (at least my email > client says I did not). It is great that you are on it again. I am looking forward to have the

Re: [RFC][PATCH 2/5 v2] tracing: Create seq_buf layer in trace_seq

2014-09-26 Thread Steven Rostedt
As people are asking for this patch series to be added, I'm going back through your comments. I never replied to this email (at least my email client says I did not). On Fri, 27 Jun 2014 18:52:04 +0200 Petr Mládek wrote: > On Fri 2014-06-27 11:39:09, Steven Rostedt wrote: > > On Fri, 27 Jun

Re: [RFC][PATCH 2/5 v2] tracing: Create seq_buf layer in trace_seq

2014-09-26 Thread Steven Rostedt
As people are asking for this patch series to be added, I'm going back through your comments. I never replied to this email (at least my email client says I did not). On Fri, 27 Jun 2014 18:52:04 +0200 Petr Mládek pmla...@suse.cz wrote: On Fri 2014-06-27 11:39:09, Steven Rostedt wrote: On

Re: [RFC][PATCH 2/5 v2] tracing: Create seq_buf layer in trace_seq

2014-09-26 Thread Petr Mladek
On Fri 26-09-14 11:00:43, Steven Rostedt wrote: As people are asking for this patch series to be added, I'm going back through your comments. I never replied to this email (at least my email client says I did not). It is great that you are on it again. I am looking forward to have the proposed

Re: [RFC][PATCH 2/5 v2] tracing: Create seq_buf layer in trace_seq

2014-06-27 Thread Petr Mládek
On Fri 2014-06-27 11:39:09, Steven Rostedt wrote: > On Fri, 27 Jun 2014 17:18:04 +0200 > Petr Mládek wrote: > > > > > This patch uses seq_buf for the NMI code so it will fill to the end of > > > the buffer and just truncate what can't fit. > > > > I think that NMI code could live with the

Re: [RFC][PATCH 2/5 v2] tracing: Create seq_buf layer in trace_seq

2014-06-27 Thread Steven Rostedt
On Fri, 27 Jun 2014 17:18:04 +0200 Petr Mládek wrote: > > This patch uses seq_buf for the NMI code so it will fill to the end of > > the buffer and just truncate what can't fit. > > I think that NMI code could live with the trace_seq behavior. The > lines are short. If we miss few characters

Re: [RFC][PATCH 2/5 v2] tracing: Create seq_buf layer in trace_seq

2014-06-27 Thread Petr Mládek
On Fri 2014-06-27 10:19:07, Steven Rostedt wrote: > On Fri, 27 Jun 2014 15:45:38 +0200 > Petr Mládek wrote: > > > On Thu 2014-06-26 17:49:03, Steven Rostedt wrote: > > > From: "Steven Rostedt (Red Hat)" > > > > > > Create a seq_buf layer that trace_seq sits on. The seq_buf will not > > > be

Re: [RFC][PATCH 2/5 v2] tracing: Create seq_buf layer in trace_seq

2014-06-27 Thread Petr Mládek
On Fri 2014-06-27 10:21:34, Steven Rostedt wrote: > On Fri, 27 Jun 2014 15:45:38 +0200 > Petr Mládek wrote: > > > ad 4th: > > > >Both "full" and "overflow" flags seems to have the same meaning. > >For example, trace_seq_printf() sets "full" on failure even > >when s->seq.len !=

Re: [RFC][PATCH 2/5 v2] tracing: Create seq_buf layer in trace_seq

2014-06-27 Thread Steven Rostedt
On Fri, 27 Jun 2014 15:45:38 +0200 Petr Mládek wrote: > ad 4th: > >Both "full" and "overflow" flags seems to have the same meaning. >For example, trace_seq_printf() sets "full" on failure even >when s->seq.len != s->size. > > > Best Regards, > Petr > > [...] BTW, you shouldn't

Re: [RFC][PATCH 2/5 v2] tracing: Create seq_buf layer in trace_seq

2014-06-27 Thread Steven Rostedt
On Fri, 27 Jun 2014 15:45:38 +0200 Petr Mládek wrote: > On Thu 2014-06-26 17:49:03, Steven Rostedt wrote: > > From: "Steven Rostedt (Red Hat)" > > > > Create a seq_buf layer that trace_seq sits on. The seq_buf will not > > be limited to page size. This will allow other usages of seq_buf > >

Re: [RFC][PATCH 2/5 v2] tracing: Create seq_buf layer in trace_seq

2014-06-27 Thread Petr Mládek
On Thu 2014-06-26 17:49:03, Steven Rostedt wrote: > From: "Steven Rostedt (Red Hat)" > > Create a seq_buf layer that trace_seq sits on. The seq_buf will not > be limited to page size. This will allow other usages of seq_buf > instead of a hard set PAGE_SIZE one that trace_seq has. > >

Re: [RFC][PATCH 2/5 v2] tracing: Create seq_buf layer in trace_seq

2014-06-27 Thread Petr Mládek
On Thu 2014-06-26 17:49:03, Steven Rostedt wrote: From: Steven Rostedt (Red Hat) rost...@goodmis.org Create a seq_buf layer that trace_seq sits on. The seq_buf will not be limited to page size. This will allow other usages of seq_buf instead of a hard set PAGE_SIZE one that trace_seq has.

Re: [RFC][PATCH 2/5 v2] tracing: Create seq_buf layer in trace_seq

2014-06-27 Thread Steven Rostedt
On Fri, 27 Jun 2014 15:45:38 +0200 Petr Mládek pmla...@suse.cz wrote: On Thu 2014-06-26 17:49:03, Steven Rostedt wrote: From: Steven Rostedt (Red Hat) rost...@goodmis.org Create a seq_buf layer that trace_seq sits on. The seq_buf will not be limited to page size. This will allow other

Re: [RFC][PATCH 2/5 v2] tracing: Create seq_buf layer in trace_seq

2014-06-27 Thread Steven Rostedt
On Fri, 27 Jun 2014 15:45:38 +0200 Petr Mládek pmla...@suse.cz wrote: ad 4th: Both full and overflow flags seems to have the same meaning. For example, trace_seq_printf() sets full on failure even when s-seq.len != s-size. Best Regards, Petr [...] BTW, you shouldn't sign

Re: [RFC][PATCH 2/5 v2] tracing: Create seq_buf layer in trace_seq

2014-06-27 Thread Petr Mládek
On Fri 2014-06-27 10:21:34, Steven Rostedt wrote: On Fri, 27 Jun 2014 15:45:38 +0200 Petr Mládek pmla...@suse.cz wrote: ad 4th: Both full and overflow flags seems to have the same meaning. For example, trace_seq_printf() sets full on failure even when s-seq.len != s-size.

Re: [RFC][PATCH 2/5 v2] tracing: Create seq_buf layer in trace_seq

2014-06-27 Thread Petr Mládek
On Fri 2014-06-27 10:19:07, Steven Rostedt wrote: On Fri, 27 Jun 2014 15:45:38 +0200 Petr Mládek pmla...@suse.cz wrote: On Thu 2014-06-26 17:49:03, Steven Rostedt wrote: From: Steven Rostedt (Red Hat) rost...@goodmis.org Create a seq_buf layer that trace_seq sits on. The seq_buf

Re: [RFC][PATCH 2/5 v2] tracing: Create seq_buf layer in trace_seq

2014-06-27 Thread Steven Rostedt
On Fri, 27 Jun 2014 17:18:04 +0200 Petr Mládek pmla...@suse.cz wrote: This patch uses seq_buf for the NMI code so it will fill to the end of the buffer and just truncate what can't fit. I think that NMI code could live with the trace_seq behavior. The lines are short. If we miss few

Re: [RFC][PATCH 2/5 v2] tracing: Create seq_buf layer in trace_seq

2014-06-27 Thread Petr Mládek
On Fri 2014-06-27 11:39:09, Steven Rostedt wrote: On Fri, 27 Jun 2014 17:18:04 +0200 Petr Mládek pmla...@suse.cz wrote: This patch uses seq_buf for the NMI code so it will fill to the end of the buffer and just truncate what can't fit. I think that NMI code could live with the

[RFC][PATCH 2/5 v2] tracing: Create seq_buf layer in trace_seq

2014-06-26 Thread Steven Rostedt
From: "Steven Rostedt (Red Hat)" Create a seq_buf layer that trace_seq sits on. The seq_buf will not be limited to page size. This will allow other usages of seq_buf instead of a hard set PAGE_SIZE one that trace_seq has. Signed-off-by: Steven Rostedt --- include/linux/seq_buf.h

[RFC][PATCH 2/5 v2] tracing: Create seq_buf layer in trace_seq

2014-06-26 Thread Steven Rostedt
From: Steven Rostedt (Red Hat) rost...@goodmis.org Create a seq_buf layer that trace_seq sits on. The seq_buf will not be limited to page size. This will allow other usages of seq_buf instead of a hard set PAGE_SIZE one that trace_seq has. Signed-off-by: Steven Rostedt rost...@goodmis.org ---