Re: [RFC][PATCH 2/7] get mount write in __dentry_open()

2007-10-11 Thread Dave Hansen
On Thu, 2007-10-11 at 20:31 +0200, Miklos Szeredi wrote: > > On Thu, 2007-10-11 at 17:08 +0200, Miklos Szeredi wrote: > > > > diff -puN fs/namei.c~get-write-in-__dentry_open fs/namei.c > > > > --- lxc/fs/namei.c~get-write-in-__dentry_open 2007-10-03 > > > > 14:44:52.0 -0700 > > > > +++ l

Re: [RFC][PATCH 2/7] get mount write in __dentry_open()

2007-10-11 Thread Miklos Szeredi
> On Thu, 2007-10-11 at 17:08 +0200, Miklos Szeredi wrote: > > > diff -puN fs/namei.c~get-write-in-__dentry_open fs/namei.c > > > --- lxc/fs/namei.c~get-write-in-__dentry_open 2007-10-03 > > > 14:44:52.0 -0700 > > > +++ lxc-dave/fs/namei.c 2007-10-04 18:02:48.0 -0700 > > > @@

Re: [RFC][PATCH 2/7] get mount write in __dentry_open()

2007-10-11 Thread Dave Hansen
On Thu, 2007-10-11 at 17:08 +0200, Miklos Szeredi wrote: > > diff -puN fs/namei.c~get-write-in-__dentry_open fs/namei.c > > --- lxc/fs/namei.c~get-write-in-__dentry_open 2007-10-03 > > 14:44:52.0 -0700 > > +++ lxc-dave/fs/namei.c 2007-10-04 18:02:48.0 -0700 > > @@ -1621,1

Re: [RFC][PATCH 2/7] get mount write in __dentry_open()

2007-10-11 Thread Miklos Szeredi
> > > The first patch fixes an actual bug. I think the > reset will reduce the chance for any future bugs > to creep in. > > -- > > The r/o bind mount patches require matching mnt_want_write() > at filp creation time with a mnt_drop_write() at __fput(). > > We used to do this in may_open(), b

[RFC][PATCH 2/7] get mount write in __dentry_open()

2007-10-10 Thread Dave Hansen
The first patch fixes an actual bug. I think the reset will reduce the chance for any future bugs to creep in. -- The r/o bind mount patches require matching mnt_want_write() at filp creation time with a mnt_drop_write() at __fput(). We used to do this in may_open(), but Miklos pointed out tha