Re: [RFC][PATCH 2/7] memcg: don't use mem_cgroup_get() when creating a kmemcg cache

>>> You are putting references but I do not see any single css_{try}get >>> here. /me puzzled. >>> >> >> There are two things being done in this code: >> First, we acquired a css_ref to make sure that the underlying cgroup >> would not go away. That is a short lived reference, and it is put as >>

Re: [RFC][PATCH 2/7] memcg: don't use mem_cgroup_get() when creating a kmemcg cache

You are putting references but I do not see any single css_{try}get here. /me puzzled. There are two things being done in this code: First, we acquired a css_ref to make sure that the underlying cgroup would not go away. That is a short lived reference, and it is put as soon as the cache

Re: [RFC][PATCH 2/7] memcg: don't use mem_cgroup_get() when creating a kmemcg cache

On Fri 05-04-13 14:51:10, KAMEZAWA Hiroyuki wrote: > (2013/04/03 18:12), Li Zefan wrote: > > Use css_get()/css_put() instead of mem_cgroup_get()/mem_cgroup_put(). > > > > Signed-off-by: Li Zefan > > --- > > mm/memcontrol.c | 10 +- > > 1 file changed, 5 insertions(+), 5 deletions(-) >

Re: [RFC][PATCH 2/7] memcg: don't use mem_cgroup_get() when creating a kmemcg cache

On Fri 05-04-13 14:28:12, Glauber Costa wrote: > On 04/03/2013 07:31 PM, Michal Hocko wrote: > > On Wed 03-04-13 17:12:21, Li Zefan wrote: > >> Use css_get()/css_put() instead of mem_cgroup_get()/mem_cgroup_put(). > >> > >> Signed-off-by: Li Zefan > >> --- > >> mm/memcontrol.c | 10 +- >

Re: [RFC][PATCH 2/7] memcg: don't use mem_cgroup_get() when creating a kmemcg cache

On 04/03/2013 07:31 PM, Michal Hocko wrote: > On Wed 03-04-13 17:12:21, Li Zefan wrote: >> Use css_get()/css_put() instead of mem_cgroup_get()/mem_cgroup_put(). >> >> Signed-off-by: Li Zefan >> --- >> mm/memcontrol.c | 10 +- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> diff

Re: [RFC][PATCH 2/7] memcg: don't use mem_cgroup_get() when creating a kmemcg cache

On 04/03/2013 07:31 PM, Michal Hocko wrote: On Wed 03-04-13 17:12:21, Li Zefan wrote: Use css_get()/css_put() instead of mem_cgroup_get()/mem_cgroup_put(). Signed-off-by: Li Zefan lize...@huawei.com --- mm/memcontrol.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

Re: [RFC][PATCH 2/7] memcg: don't use mem_cgroup_get() when creating a kmemcg cache

On Fri 05-04-13 14:28:12, Glauber Costa wrote: On 04/03/2013 07:31 PM, Michal Hocko wrote: On Wed 03-04-13 17:12:21, Li Zefan wrote: Use css_get()/css_put() instead of mem_cgroup_get()/mem_cgroup_put(). Signed-off-by: Li Zefan lize...@huawei.com --- mm/memcontrol.c | 10 +-

Re: [RFC][PATCH 2/7] memcg: don't use mem_cgroup_get() when creating a kmemcg cache

On Fri 05-04-13 14:51:10, KAMEZAWA Hiroyuki wrote: (2013/04/03 18:12), Li Zefan wrote: Use css_get()/css_put() instead of mem_cgroup_get()/mem_cgroup_put(). Signed-off-by: Li Zefan lize...@huawei.com --- mm/memcontrol.c | 10 +- 1 file changed, 5 insertions(+), 5

Re: [RFC][PATCH 2/7] memcg: don't use mem_cgroup_get() when creating a kmemcg cache

(2013/04/03 18:12), Li Zefan wrote: > Use css_get()/css_put() instead of mem_cgroup_get()/mem_cgroup_put(). > > Signed-off-by: Li Zefan > --- > mm/memcontrol.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index

Re: [RFC][PATCH 2/7] memcg: don't use mem_cgroup_get() when creating a kmemcg cache

(2013/04/03 18:12), Li Zefan wrote: Use css_get()/css_put() instead of mem_cgroup_get()/mem_cgroup_put(). Signed-off-by: Li Zefan lize...@huawei.com --- mm/memcontrol.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c

Re: [RFC][PATCH 2/7] memcg: don't use mem_cgroup_get() when creating a kmemcg cache

On Wed 03-04-13 17:12:21, Li Zefan wrote: > Use css_get()/css_put() instead of mem_cgroup_get()/mem_cgroup_put(). > > Signed-off-by: Li Zefan > --- > mm/memcontrol.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index

Re: [RFC][PATCH 2/7] memcg: don't use mem_cgroup_get() when creating a kmemcg cache

On 04/03/2013 01:12 PM, Li Zefan wrote: > Use css_get()/css_put() instead of mem_cgroup_get()/mem_cgroup_put(). > > Signed-off-by: Li Zefan > --- > mm/memcontrol.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index

[RFC][PATCH 2/7] memcg: don't use mem_cgroup_get() when creating a kmemcg cache

Use css_get()/css_put() instead of mem_cgroup_get()/mem_cgroup_put(). Signed-off-by: Li Zefan --- mm/memcontrol.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 43ca91d..dafacb8 100644 --- a/mm/memcontrol.c +++

[RFC][PATCH 2/7] memcg: don't use mem_cgroup_get() when creating a kmemcg cache

Use css_get()/css_put() instead of mem_cgroup_get()/mem_cgroup_put(). Signed-off-by: Li Zefan lize...@huawei.com --- mm/memcontrol.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 43ca91d..dafacb8 100644 ---

Re: [RFC][PATCH 2/7] memcg: don't use mem_cgroup_get() when creating a kmemcg cache

On 04/03/2013 01:12 PM, Li Zefan wrote: Use css_get()/css_put() instead of mem_cgroup_get()/mem_cgroup_put(). Signed-off-by: Li Zefan lize...@huawei.com --- mm/memcontrol.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c

Re: [RFC][PATCH 2/7] memcg: don't use mem_cgroup_get() when creating a kmemcg cache

On Wed 03-04-13 17:12:21, Li Zefan wrote: Use css_get()/css_put() instead of mem_cgroup_get()/mem_cgroup_put(). Signed-off-by: Li Zefan lize...@huawei.com --- mm/memcontrol.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c