Re: [RFC][PATCH 2/8] mm/migrate: Defer allocating new page until needed

2020-07-01 Thread Yang Shi
On 7/1/20 7:46 AM, Dave Hansen wrote: On 7/1/20 1:47 AM, Greg Thelen wrote: Dave Hansen wrote: From: Keith Busch Defer allocating the page until we are actually ready to make use of it, after locking the original page. This simplifies error handling, but should not have any functional

Re: [RFC][PATCH 2/8] mm/migrate: Defer allocating new page until needed

2020-07-01 Thread Dave Hansen
On 7/1/20 1:47 AM, Greg Thelen wrote: > Dave Hansen wrote: >> From: Keith Busch >> Defer allocating the page until we are actually ready to make use of >> it, after locking the original page. This simplifies error handling, >> but should not have any functional change in behavior. This is just

Re: [RFC][PATCH 2/8] mm/migrate: Defer allocating new page until needed

2020-07-01 Thread Greg Thelen
Dave Hansen wrote: > From: Keith Busch > > Migrating pages had been allocating the new page before it was actually > needed. Subsequent operations may still fail, which would have to handle > cleaning up the newly allocated page when it was never used. > > Defer allocating the page until we are

[RFC][PATCH 2/8] mm/migrate: Defer allocating new page until needed

2020-06-29 Thread Dave Hansen
From: Keith Busch Migrating pages had been allocating the new page before it was actually needed. Subsequent operations may still fail, which would have to handle cleaning up the newly allocated page when it was never used. Defer allocating the page until we are actually ready to make use of