On Wed, Dec 20, 2006 at 06:35:41PM +0900, Keiichi KII wrote:
> >> static struct netpoll np = {
> >> > .name = "netconsole",
> >> > .dev_name = "eth0",
> >> > @@ -69,23 +84,91 @@ static struct netpoll np = {
> >> > .drop = netpoll_queue,
> >> > };
> >
> > Shouldn't this piece get dr
>> static struct netpoll np = {
>> > .name = "netconsole",
>> > .dev_name = "eth0",
>> > @@ -69,23 +84,91 @@ static struct netpoll np = {
>> > .drop = netpoll_queue,
>> > };
>
> Shouldn't this piece get dropped in this patch?
>
This piece isn't in -mm tree, but this piece is in 2
On Tue, Dec 12, 2006 at 12:42:50PM -0600, Matt Mackall wrote:
> > + new_dev = (struct netconsole_device*)kmalloc(
> > + sizeof(struct netconsole_device), GFP_ATOMIC);
>
> Cast of void * is unnecessary.
Also,
1. use kzalloc rather than kmalloc+memset
2. use p = kzalloc(sizeof(*p) rathe
On Tue, Dec 12, 2006 at 03:29:57PM +0900, Keiichi KII wrote:
> From: Keiichi KII <[EMAIL PROTECTED]>
>
> This patch contains the following changes for supporting multiple logging
> agents.
>
> 1. extend netconsole to multiple netpolls
>To send kernel messages to multiple logging agents, exte
4 matches
Mail list logo