Re: [RFC][PATCH 25/26] sched, numa: Only migrate long-running entities

2012-07-09 Thread Peter Zijlstra
On Mon, 2012-07-09 at 10:53 -0400, Rik van Riel wrote: > On 07/09/2012 08:26 AM, Peter Zijlstra wrote: > > On Sun, 2012-07-08 at 14:34 -0400, Rik van Riel wrote: > > >> Do we really want to calculate the amount of CPU time used > >> by a process, and start migrating after just one second? > >> > >

Re: [RFC][PATCH 25/26] sched, numa: Only migrate long-running entities

2012-07-09 Thread Rik van Riel
On 07/09/2012 08:26 AM, Peter Zijlstra wrote: On Sun, 2012-07-08 at 14:34 -0400, Rik van Riel wrote: Do we really want to calculate the amount of CPU time used by a process, and start migrating after just one second? Or would it be ok to start migrating once a process has been scanned once or

Re: [RFC][PATCH 25/26] sched, numa: Only migrate long-running entities

2012-07-09 Thread Peter Zijlstra
On Sun, 2012-07-08 at 14:34 -0400, Rik van Riel wrote: > On 03/16/2012 10:40 AM, Peter Zijlstra wrote: > > > +static u64 process_cpu_runtime(struct numa_entity *ne) > > +{ > > + struct task_struct *p, *t; > > + u64 runtime = 0; > > + > > + rcu_read_lock(); > > + t = p = ne_owner(ne); > > +

Re: [RFC][PATCH 25/26] sched, numa: Only migrate long-running entities

2012-07-08 Thread Rik van Riel
On 03/16/2012 10:40 AM, Peter Zijlstra wrote: +static u64 process_cpu_runtime(struct numa_entity *ne) +{ + struct task_struct *p, *t; + u64 runtime = 0; + + rcu_read_lock(); + t = p = ne_owner(ne); + if (p) do { + runtime += t->se.sum_exec_runtime; //