Re: [RFC][PATCH 7/7] cpufreq: intel_pstate: Change P-state selection algorithm for Core

2016-08-23 Thread Rafael J. Wysocki
On Tuesday, August 23, 2016 12:50:14 PM Wanpeng Li wrote: > 2016-08-23 12:08 GMT+08:00 Srinivas Pandruvada > : > > On Tue, 2016-08-23 at 11:48 +0800, Wanpeng Li wrote: > >> Hi Rafael, > >> 2016-08-01 7:38 GMT+08:00 Rafael J. Wysocki : > >> > > >> > From: Rafael J. Wysocki > >> > > >> > The PID-bas

Re: [RFC][PATCH 7/7] cpufreq: intel_pstate: Change P-state selection algorithm for Core

2016-08-22 Thread Wanpeng Li
2016-08-23 12:08 GMT+08:00 Srinivas Pandruvada : > On Tue, 2016-08-23 at 11:48 +0800, Wanpeng Li wrote: >> Hi Rafael, >> 2016-08-01 7:38 GMT+08:00 Rafael J. Wysocki : >> > >> > From: Rafael J. Wysocki >> > >> > The PID-base P-state selection algorithm used by intel_pstate for >> > Core processors

Re: [RFC][PATCH 7/7] cpufreq: intel_pstate: Change P-state selection algorithm for Core

2016-08-22 Thread Srinivas Pandruvada
On Tue, 2016-08-23 at 11:48 +0800, Wanpeng Li wrote: > Hi Rafael, > 2016-08-01 7:38 GMT+08:00 Rafael J. Wysocki : > > > > From: Rafael J. Wysocki > > > > The PID-base P-state selection algorithm used by intel_pstate for > > Core processors is based on very weak foundations.  Namely, its > > deci

Re: [RFC][PATCH 7/7] cpufreq: intel_pstate: Change P-state selection algorithm for Core

2016-08-22 Thread Wanpeng Li
Hi Rafael, 2016-08-01 7:38 GMT+08:00 Rafael J. Wysocki : > From: Rafael J. Wysocki > > The PID-base P-state selection algorithm used by intel_pstate for > Core processors is based on very weak foundations. Namely, its > decisions are mostly based on the values of the APERF and MPERF > feedback re

RE: [RFC][PATCH 7/7] cpufreq: intel_pstate: Change P-state selection algorithm for Core

2016-08-22 Thread Doug Smythies
On 2016.08.22 11:54 Srinivas Pandruvada wrote: > I am not able to apply this patch. Can you send as a patch on top of > Rafael's RFC 7/7. Since test takes long time, I want to apply correct > patch. ...[cut]... O.K. I have included a couple of changes as per the feedback from Peter Zijlstra, bu

Re: [RFC][PATCH 7/7] cpufreq: intel_pstate: Change P-state selection algorithm for Core

2016-08-22 Thread Srinivas Pandruvada
Hi Doug, I am not able to apply this patch. Can you send as a patch on top of Rafael's RFC 7/7. Since test takes long time, I want to apply correct patch. Thanks, Srinivas On Sat, 2016-08-13 at 08:59 -0700, Doug Smythies wrote: > On 2016.08.05 17:02 Rafael J. Wysocki wrote: > > > > > > > > On

RE: [RFC][PATCH 7/7] cpufreq: intel_pstate: Change P-state selection algorithm for Core

2016-08-19 Thread Doug Smythies
On 2016.08.19 07:47 Peter Zijlstra wrote: > On Sat, Aug 13, 2016 at 08:59:01AM -0700, Doug Smythies wrote: >> My previous replies (and see below) have suggested that some filtering >> is needed on the target pstate, otherwise, and dependant on the type of >> workload, it tends to oscillate. >> >>

Re: [RFC][PATCH 7/7] cpufreq: intel_pstate: Change P-state selection algorithm for Core

2016-08-19 Thread Rafael J. Wysocki
On Friday, August 19, 2016 04:47:29 PM Peter Zijlstra wrote: > On Sat, Aug 13, 2016 at 08:59:01AM -0700, Doug Smythies wrote: > > My previous replies (and see below) have suggested that some filtering > > is needed on the target pstate, otherwise, and dependant on the type of > > workload, it tends

Re: [RFC][PATCH 7/7] cpufreq: intel_pstate: Change P-state selection algorithm for Core

2016-08-19 Thread Peter Zijlstra
On Sat, Aug 13, 2016 at 08:59:01AM -0700, Doug Smythies wrote: > My previous replies (and see below) have suggested that some filtering > is needed on the target pstate, otherwise, and dependant on the type of > workload, it tends to oscillate. > > I added the IIR (Infinite Impulse Response) filte

RE: [RFC][PATCH 7/7] cpufreq: intel_pstate: Change P-state selection algorithm for Core

2016-08-13 Thread Doug Smythies
On 2016.08.05 17:02 Rafael J. Wysocki wrote: >> On 2016.08.03 21:19 Doug Smythies wrote: >>> On 2016.07.31 16:49 Rafael J. Wysocki wrote: >>> >>> The PID-base P-state selection algorithm used by intel_pstate for >>> Core processors is based on very weak foundations. >> >> ...[cut]... >> >>> +stat

RE: [RFC][PATCH 7/7] cpufreq: intel_pstate: Change P-state selection algorithm for Core

2016-08-09 Thread Doug Smythies
On 2016.08.05 17:02 Rafael J. Wysocki wrote: > On 2016.08.03 21:19 Doug Smythies wrote: >> On 2016.07.31 16:49 Rafael J. Wysocki wrote: >> >> >>> +static inline int32_t get_target_pstate_default(struct cpudata *cpu) >>> +{ >>> + struct sample *sample = &cpu->sample; >>> + int32_t busy_frac; >>

Re: [RFC][PATCH 7/7] cpufreq: intel_pstate: Change P-state selection algorithm for Core

2016-08-06 Thread Rafael J. Wysocki
On Wednesday, August 03, 2016 11:53:23 PM Doug Smythies wrote: > On 2016.08.03 21:19 Doug Smythies wrote: > > Re-sending without the previously attached graph. > > Hi Rafael, > > Hope this feedback and test results help. > > On 2016.07.31 16:49 Rafael J. Wysocki wrote: > > > The PID-base P-sta

RE: [RFC][PATCH 7/7] cpufreq: intel_pstate: Change P-state selection algorithm for Core

2016-08-03 Thread Doug Smythies
On 2016.08.03 21:19 Doug Smythies wrote: Re-sending without the previously attached graph. Hi Rafael, Hope this feedback and test results help. On 2016.07.31 16:49 Rafael J. Wysocki wrote: > The PID-base P-state selection algorithm used by intel_pstate for > Core processors is based on very we

[RFC][PATCH 7/7] cpufreq: intel_pstate: Change P-state selection algorithm for Core

2016-07-31 Thread Rafael J. Wysocki
From: Rafael J. Wysocki The PID-base P-state selection algorithm used by intel_pstate for Core processors is based on very weak foundations. Namely, its decisions are mostly based on the values of the APERF and MPERF feedback registers and it only estimates the actual utilization to check if it