Re: [RFC][PATCH v2] tracing: Add __bitmask() macro to trace events to cpumasks and other bitmasks

2014-05-14 Thread Steven Rostedt
On Wed, 14 May 2014 16:50:53 +0100 Javi Merino wrote: > > OK, let me pull this patch out of my tree (thank god I never pushed > > it), and work on it a bit more. > > Ok, well keep me posted on this, I've tried to use it but trace-cmd > says "[FAILED TO PARSE]" and I'm still trying to figure

Re: [RFC][PATCH v2] tracing: Add __bitmask() macro to trace events to cpumasks and other bitmasks

2014-05-14 Thread Javi Merino
On Wed, May 14, 2014 at 04:36:23PM +0100, Steven Rostedt wrote: > On Wed, 14 May 2014 15:23:24 +0100 > Javi Merino wrote: > > > > diff --git a/include/trace/ftrace.h b/include/trace/ftrace.h > > > index 0a1a4f7..d9c44af 100644 > > > --- a/include/trace/ftrace.h > > > +++ b/include/trace/ftrace.h

Re: [RFC][PATCH v2] tracing: Add __bitmask() macro to trace events to cpumasks and other bitmasks

2014-05-14 Thread Steven Rostedt
On Wed, 14 May 2014 15:23:24 +0100 Javi Merino wrote: > > diff --git a/include/trace/ftrace.h b/include/trace/ftrace.h > > index 0a1a4f7..d9c44af 100644 > > --- a/include/trace/ftrace.h > > +++ b/include/trace/ftrace.h > > @@ -53,6 +53,9 @@ > > #undef __string > > #define __string(item, src)

Re: [RFC][PATCH v2] tracing: Add __bitmask() macro to trace events to cpumasks and other bitmasks

2014-05-14 Thread Javi Merino
Hi Steven, On Wed, May 07, 2014 at 04:12:38AM +0100, Steven Rostedt wrote: > > Being able to show a cpumask of events can be useful as some events > may affect only some CPUs. There is no standard way to record the > cpumask and converting it to a string is rather expensive during > the trace as

Re: [RFC][PATCH v2] tracing: Add __bitmask() macro to trace events to cpumasks and other bitmasks

2014-05-14 Thread Javi Merino
Hi Steven, On Wed, May 07, 2014 at 04:12:38AM +0100, Steven Rostedt wrote: Being able to show a cpumask of events can be useful as some events may affect only some CPUs. There is no standard way to record the cpumask and converting it to a string is rather expensive during the trace as

Re: [RFC][PATCH v2] tracing: Add __bitmask() macro to trace events to cpumasks and other bitmasks

2014-05-14 Thread Javi Merino
On Wed, May 14, 2014 at 04:36:23PM +0100, Steven Rostedt wrote: On Wed, 14 May 2014 15:23:24 +0100 Javi Merino javi.mer...@arm.com wrote: diff --git a/include/trace/ftrace.h b/include/trace/ftrace.h index 0a1a4f7..d9c44af 100644 --- a/include/trace/ftrace.h +++

Re: [RFC][PATCH v2] tracing: Add __bitmask() macro to trace events to cpumasks and other bitmasks

2014-05-14 Thread Steven Rostedt
On Wed, 14 May 2014 16:50:53 +0100 Javi Merino javi.mer...@arm.com wrote: OK, let me pull this patch out of my tree (thank god I never pushed it), and work on it a bit more. Ok, well keep me posted on this, I've tried to use it but trace-cmd says [FAILED TO PARSE] and I'm still trying to

Re: [RFC][PATCH v2] tracing: Add __bitmask() macro to trace events to cpumasks and other bitmasks

2014-05-07 Thread Steven Rostedt
On Wed, 7 May 2014 11:40:21 + (UTC) Mathieu Desnoyers wrote: > - Original Message - > > From: "Steven Rostedt" > > To: "LKML" > > Cc: "Mathieu Desnoyers" , "Javi Merino" > > , "Andrew Morton" > > , "Ingo Molnar" , "Namhyung > > Kim" , "Jiri Olsa" > > > > Sent: Tuesday, May 6,

Re: [RFC][PATCH v2] tracing: Add __bitmask() macro to trace events to cpumasks and other bitmasks

2014-05-07 Thread Mathieu Desnoyers
- Original Message - > From: "Steven Rostedt" > To: "LKML" > Cc: "Mathieu Desnoyers" , "Javi Merino" > , "Andrew Morton" > , "Ingo Molnar" , "Namhyung Kim" > , "Jiri Olsa" > > Sent: Tuesday, May 6, 2014 11:12:38 PM > Subject: [RFC][PATCH v2] tracing: Add __bitmask() macro to trace

Re: [RFC][PATCH v2] tracing: Add __bitmask() macro to trace events to cpumasks and other bitmasks

2014-05-07 Thread Mathieu Desnoyers
- Original Message - From: Steven Rostedt rost...@goodmis.org To: LKML linux-kernel@vger.kernel.org Cc: Mathieu Desnoyers mathieu.desnoy...@efficios.com, Javi Merino javi.mer...@arm.com, Andrew Morton a...@linux-foundation.org, Ingo Molnar mi...@kernel.org, Namhyung Kim

Re: [RFC][PATCH v2] tracing: Add __bitmask() macro to trace events to cpumasks and other bitmasks

2014-05-07 Thread Steven Rostedt
On Wed, 7 May 2014 11:40:21 + (UTC) Mathieu Desnoyers mathieu.desnoy...@efficios.com wrote: - Original Message - From: Steven Rostedt rost...@goodmis.org To: LKML linux-kernel@vger.kernel.org Cc: Mathieu Desnoyers mathieu.desnoy...@efficios.com, Javi Merino

[RFC][PATCH v2] tracing: Add __bitmask() macro to trace events to cpumasks and other bitmasks

2014-05-06 Thread Steven Rostedt
Being able to show a cpumask of events can be useful as some events may affect only some CPUs. There is no standard way to record the cpumask and converting it to a string is rather expensive during the trace as traces happen in hotpaths. It would be better to record the raw event mask and be

[RFC][PATCH v2] tracing: Add __bitmask() macro to trace events to cpumasks and other bitmasks

2014-05-06 Thread Steven Rostedt
Being able to show a cpumask of events can be useful as some events may affect only some CPUs. There is no standard way to record the cpumask and converting it to a string is rather expensive during the trace as traces happen in hotpaths. It would be better to record the raw event mask and be