Re: [RFC] Cleanup line-wrapping in pgtable.h

2005-08-22 Thread Pavel Machek
Hi! > The line-wrapping in most of the include/asm/pgtable.h pte test/set > macros looks horrible in my 80 column terminal. The following "test the > waters" patch is how I would like to see them laid out. I realize that > the braces don't adhere to CodingStyle but the advantage is (when taking

Re: [RFC] Cleanup line-wrapping in pgtable.h

2005-08-22 Thread Matthew Helsley
On Wed, 2005-08-17 at 12:45 -0500, Adam Litke wrote: > The line-wrapping in most of the include/asm/pgtable.h pte test/set > macros looks horrible in my 80 column terminal. The following "test the > waters" patch is how I would like to see them laid out. I realize that > the braces don't adhere t

Re: [RFC] Cleanup line-wrapping in pgtable.h

2005-08-17 Thread Alexey Dobriyan
On Wed, Aug 17, 2005 at 06:56:01PM +0100, Christoph Hellwig wrote: > > +static inline int pte_user(pte_t pte) > > + { return (pte).pte_low & _PAGE_USER; } > > Once you start reformatting things please make sure the result version > matches the documented codingstyle. That would be: > > static

Re: [RFC] Cleanup line-wrapping in pgtable.h

2005-08-17 Thread Dave Hansen
On Wed, 2005-08-17 at 12:45 -0500, Adam Litke wrote: > The line-wrapping in most of the include/asm/pgtable.h pte test/set > macros looks horrible in my 80 column terminal. The following "test the > waters" patch is how I would like to see them laid out. I realize that > the braces don't adhere t

Re: [RFC] Cleanup line-wrapping in pgtable.h

2005-08-17 Thread Tommy Reynolds
Uttered Adam Litke <[EMAIL PROTECTED]>, spake thus: > The line-wrapping in most of the include/asm/pgtable.h pte test/set > macros looks horrible in my 80 column terminal. The following "test the > waters" patch is how I would like to see them laid out. I realize that > the braces don't adhere t

Re: [RFC] Cleanup line-wrapping in pgtable.h

2005-08-17 Thread Christoph Hellwig
> +static inline int pte_user(pte_t pte) > + { return (pte).pte_low & _PAGE_USER; } Once you start reformatting things please make sure the result version matches the documented codingstyle. That would be: static inline int pte_user(pte_t pte) { return (pte).pte_low & _PAGE_USER; }

[RFC] Cleanup line-wrapping in pgtable.h

2005-08-17 Thread Adam Litke
The line-wrapping in most of the include/asm/pgtable.h pte test/set macros looks horrible in my 80 column terminal. The following "test the waters" patch is how I would like to see them laid out. I realize that the braces don't adhere to CodingStyle but the advantage is (when taking wrapping into