Re: [RFC] Crash on modpost, addend_386_rel()

2007-05-23 Thread Mika Penttilä
Atsushi Nemoto wrote: On Tue, 22 May 2007 17:48:09 +0300, Mika_Penttilä <[EMAIL PROTECTED]> wrote: I can't see how this use of r_attend is going to work. find_elf_symbol compares relsym->st_value to Elf_Rela->r_attend. I think it doesn't work for RELA archs and even with this patch for REL.

Re: [RFC] Crash on modpost, addend_386_rel()

2007-05-23 Thread Atsushi Nemoto
On Wed, 23 May 2007 18:23:17 +0300, Mika_Penttilä <[EMAIL PROTECTED]> wrote: > So with mips64 you are lucky because the relocation symbol is .init.text > and hence addend matches (has to match) symbol's offset. I can't find > any spec where it is stated that addend == address, maybe it's in mips

Re: [RFC] Crash on modpost, addend_386_rel()

2007-05-23 Thread Atsushi Nemoto
On Tue, 22 May 2007 17:48:09 +0300, Mika_Penttilä <[EMAIL PROTECTED]> wrote: > I can't see how this use of r_attend is going to work. find_elf_symbol > compares relsym->st_value to Elf_Rela->r_attend. I think it doesn't work > for RELA archs and even with this patch for REL. It seems works fine wi

Re: [RFC] Crash on modpost, addend_386_rel()

2007-05-22 Thread Mika Penttilä
Atsushi Nemoto kirjoitti: On Tue, 22 May 2007 14:29:29 +0900 (JST), Atsushi Nemoto <[EMAIL PROTECTED]> wrote: Subject: [PATCH] kbuild: make better section mismatch reports on i386, arm and mips (take 3) Updated again to get a little bit better report on i386 relocatable vmlinux. Su

Re: [RFC] Crash on modpost, addend_386_rel()

2007-05-22 Thread Atsushi Nemoto
On Tue, 22 May 2007 14:29:29 +0900 (JST), Atsushi Nemoto <[EMAIL PROTECTED]> wrote: > Subject: [PATCH] kbuild: make better section mismatch reports on i386, arm > and mips (take 3) Updated again to get a little bit better report on i386 relocatable vmlinux. Subject: [PATCH] kbuild: make better

Re: [RFC] Crash on modpost, addend_386_rel()

2007-05-21 Thread Sam Ravnborg
On Mon, May 21, 2007 at 10:01:27PM -0400, Ben Collins wrote: > Got this crash in modpost. Bisect blames this commit: > > commit f892b7d480eec809a5dfbd6e65742b3f3155e50e > Author: Atsushi Nemoto <[EMAIL PROTECTED]> > Date: Thu May 17 01:14:38 2007 +0900 > kbuild: make better section mismatch

Re: [RFC] Crash on modpost, addend_386_rel()

2007-05-21 Thread Atsushi Nemoto
On Mon, 21 May 2007 21:52:59 -0700 (PDT), Linus Torvalds <[EMAIL PROTECTED]> wrote: > Would you mind also just making this whole logic (that is generic and > shared with all the different arch versions) be an inline function of its > own? > > > + Elf_Shdr *sechdrs = elf->sechdrs; > > + uns

Re: [RFC] Crash on modpost, addend_386_rel()

2007-05-21 Thread Linus Torvalds
On Tue, 22 May 2007, Atsushi Nemoto wrote: > > Anyway, here is a updated patch tested on i386 (RELOCATABLE=y/n), arm, > and mips. On calculation of 'location', sh_addr should be subtracted > (thank you for debugging, Linus). And this patch contains an another > fix and an improvement of added_

Re: [RFC] Crash on modpost, addend_386_rel()

2007-05-21 Thread Atsushi Nemoto
On Mon, 21 May 2007 22:01:27 -0400, Ben Collins <[EMAIL PROTECTED]> wrote: > Got this crash in modpost. Bisect blames this commit: > > commit f892b7d480eec809a5dfbd6e65742b3f3155e50e > Author: Atsushi Nemoto <[EMAIL PROTECTED]> > Date: Thu May 17 01:14:38 2007 +0900 > kbuild: make better se