Re: [RFC] Merging ftrace_stack, perf_callchain, oprofile->backtrace and stack_trace

2018-10-22 Thread Aleksa Sarai
On 2018-10-21, Peter Zijlstra wrote: > > Hi all, > > > > I'm currently working on a patchset to make kretprobes produce > > reasonable stack traces[1], and it appears this is a generic problem > > across the entire kernel -- you can see the same kretprobe_trampoline() > > issue when using ftrace

Re: [RFC] Merging ftrace_stack, perf_callchain, oprofile->backtrace and stack_trace

2018-10-22 Thread Peter Zijlstra
On Sun, Oct 21, 2018 at 08:31:06PM +1100, Aleksa Sarai wrote: > Hi all, > > I'm currently working on a patchset to make kretprobes produce > reasonable stack traces[1], and it appears this is a generic problem > across the entire kernel -- you can see the same kretprobe_trampoline() > issue when u

Re: [RFC] Merging ftrace_stack, perf_callchain, oprofile->backtrace and stack_trace

2018-10-21 Thread Aleksa Sarai
On 2018-10-21, Aleksa Sarai wrote: > However, in working on this patch, I've noticed that there appear to be > several different implementations of "get the stack trace from this > pt_regs" which all appear quite similar. Namely: > > * struct ftrace_stack; Sorry, I made a mistake here. ftrace_

[RFC] Merging ftrace_stack, perf_callchain, oprofile->backtrace and stack_trace

2018-10-21 Thread Aleksa Sarai
Hi all, I'm currently working on a patchset to make kretprobes produce reasonable stack traces[1], and it appears this is a generic problem across the entire kernel -- you can see the same kretprobe_trampoline() issue when using ftrace just as much as bpf_trace. However, in working on this patch,