Le 19/12/2016 à 14:54, Vladimir Zapolskiy a écrit :
Functionally it looks good, I have two comments though.
1) you don't need to revert 151b8c5ba1eb, the commit is a proper fix
per se but incomplete, please add your change on top of it,
2) minimizing the lines of code by removing duplicates
Le 19/12/2016 à 14:54, Vladimir Zapolskiy a écrit :
Functionally it looks good, I have two comments though.
1) you don't need to revert 151b8c5ba1eb, the commit is a proper fix
per se but incomplete, please add your change on top of it,
2) minimizing the lines of code by removing duplicates
Hi,
On 12/19/2016 08:19 AM, Marion & Christophe JAILLET wrote:
> Hi,
>
> while playing with coccinelle, a missing 'of_node_put()' triggered in
> 'atlas7_pinmux_probe()', in file 'drivers/pinctrl/sirf/pinctrl-atlas7.c'.
>
> /* The sd3 and sd9 shared all pins, and the function select by
>
Hi,
On 12/19/2016 08:19 AM, Marion & Christophe JAILLET wrote:
> Hi,
>
> while playing with coccinelle, a missing 'of_node_put()' triggered in
> 'atlas7_pinmux_probe()', in file 'drivers/pinctrl/sirf/pinctrl-atlas7.c'.
>
> /* The sd3 and sd9 shared all pins, and the function select by
>
Hi,
while playing with coccinelle, a missing 'of_node_put()' triggered in
'atlas7_pinmux_probe()', in file 'drivers/pinctrl/sirf/pinctrl-atlas7.c'.
/* The sd3 and sd9 shared all pins, and the function select by
* SYS2PCI_SDIO9SEL register
*/
sys2pci_np =
Hi,
while playing with coccinelle, a missing 'of_node_put()' triggered in
'atlas7_pinmux_probe()', in file 'drivers/pinctrl/sirf/pinctrl-atlas7.c'.
/* The sd3 and sd9 shared all pins, and the function select by
* SYS2PCI_SDIO9SEL register
*/
sys2pci_np =
6 matches
Mail list logo
