Re: [RFC] Slab allocators: Drop support for destructors

2007-05-10 Thread Paul Mundt
On Fri, May 11, 2007 at 08:35:27AM +0900, Paul Mundt wrote: > On Thu, May 10, 2007 at 12:00:08PM -0700, Christoph Lameter wrote: > > As far as I can tell there is only a single slab destructor left (there > > is currently another in i386 but its going to go as soon as Andi merges > > i386s suppor

Re: [RFC] Slab allocators: Drop support for destructors

2007-05-10 Thread Paul Mundt
On Thu, May 10, 2007 at 12:00:08PM -0700, Christoph Lameter wrote: > As far as I can tell there is only a single slab destructor left (there > is currently another in i386 but its going to go as soon as Andi merges > i386s support for quicklists). > > I wonder how difficult it would be to remove

Re: [RFC] Slab allocators: Drop support for destructors

2007-05-10 Thread William Lee Irwin III
On 5/10/07, Christoph Lameter <[EMAIL PROTECTED]> wrote: >> Or are there valid reason to keep them around? It seems they were mainly >> used for list management which required them to take a spinlock. Taking a >> spinlock in a destructor is a bit risky since the slab allocators may run >> the destr

Re: [RFC] Slab allocators: Drop support for destructors

2007-05-10 Thread Christoph Lameter
On Thu, 10 May 2007, Pekka Enberg wrote: > > Or do we want to continue support destructors? If so why? > > Well, constructors are on their way out too because they don't seem to > give the performance benefit they were designed for anymore. As for > destructors, they have been pretty useless in L

Re: [RFC] Slab allocators: Drop support for destructors

2007-05-10 Thread William Lee Irwin III
On Thu, May 10, 2007 at 12:00:08PM -0700, Christoph Lameter wrote: > As far as I can tell there is only a single slab destructor left (there > is currently another in i386 but its going to go as soon as Andi merges > i386s support for quicklists). > I wonder how difficult it would be to remove it

Re: [RFC] Slab allocators: Drop support for destructors

2007-05-10 Thread Pekka Enberg
On 5/10/07, Christoph Lameter <[EMAIL PROTECTED]> wrote: Or are there valid reason to keep them around? It seems they were mainly used for list management which required them to take a spinlock. Taking a spinlock in a destructor is a bit risky since the slab allocators may run the destructors any

[RFC] Slab allocators: Drop support for destructors

2007-05-10 Thread Christoph Lameter
As far as I can tell there is only a single slab destructor left (there is currently another in i386 but its going to go as soon as Andi merges i386s support for quicklists). I wonder how difficult it would be to remove it? If we have no need for destructors anymore then maybe we could remove d