* Mathieu Desnoyers <[EMAIL PROTECTED]> wrote:
> Thread Migration Preemption
>
> This patch adds the ability to protect critical sections from
> migration to another CPU without disabling preemption.
>
> This will be useful to minimize the amount of preemption disabling for
> the -rt patch. [
On 07/14, Mathieu Desnoyers wrote:
>
> * Oleg Nesterov ([EMAIL PROTECTED]) wrote:
> > On 07/14, Mathieu Desnoyers wrote:
> > >
> > > @@ -4891,10 +4948,42 @@ static int migration_thread(void *data)
> > > list_del_init(head->next);
> > >
> > > spin_unlock(&rq->lock);
> > > -
* Oleg Nesterov ([EMAIL PROTECTED]) wrote:
> On 07/14, Mathieu Desnoyers wrote:
> >
> > @@ -4891,10 +4948,42 @@ static int migration_thread(void *data)
> > list_del_init(head->next);
> >
> > spin_unlock(&rq->lock);
> > - __migrate_task(req->task, cpu, req->dest_c
* Peter Zijlstra ([EMAIL PROTECTED]) wrote:
> On Sat, 2007-07-14 at 14:42 -0400, Mathieu Desnoyers wrote:
>
> > Note: (or we could say FIXME)
> > Is we ever want to check migration pending in assembly code, we will have to
> > make sure we test the right thread flag bits on each architectures. Car
* Peter Zijlstra ([EMAIL PROTECTED]) wrote:
> Would have been nice if you'd CC'ed me :-/
>
Sorry
> On Sat, 2007-07-14 at 14:42 -0400, Mathieu Desnoyers wrote:
>
> > @@ -4891,10 +4948,42 @@ static int migration_thread(void *data)
> > list_del_init(head->next);
> >
> > sp
On 07/14, Mathieu Desnoyers wrote:
>
> @@ -4891,10 +4948,42 @@ static int migration_thread(void *data)
> list_del_init(head->next);
>
> spin_unlock(&rq->lock);
> - __migrate_task(req->task, cpu, req->dest_cpu);
> + migrated = __migrate_task(req-
On 07/14, Mathieu Desnoyers wrote:
>
> * Oleg Nesterov ([EMAIL PROTECTED]) wrote:
> > > /* Affinity changed (again). */
> > > if (!cpu_isset(dest_cpu, p->cpus_allowed))
> > > goto out;
> > >
> > > on_rq = p->se.on_rq;
> > > +#ifdef CONFIG_PREEMPT
> > > + if (!on_rq && task_thread_
On Sat, 2007-07-14 at 14:42 -0400, Mathieu Desnoyers wrote:
> Note: (or we could say FIXME)
> Is we ever want to check migration pending in assembly code, we will have to
> make sure we test the right thread flag bits on each architectures. Care
> should
> also be taken to check that the thread f
Would have been nice if you'd CC'ed me :-/
On Sat, 2007-07-14 at 14:42 -0400, Mathieu Desnoyers wrote:
> @@ -4891,10 +4948,42 @@ static int migration_thread(void *data)
> list_del_init(head->next);
>
> spin_unlock(&rq->lock);
> - __migrate_task(req->task,
Thread Migration Preemption
(v3 did not have the latest updates from Oleg review)
This patch adds the ability to protect critical sections from migration to
another CPU without disabling preemption.
This will be useful to minimize the amount of preemption disabling for the -rt
patch. It will hel
Thread Migration Preemption
This patch adds the ability to protect critical sections from migration to
another CPU without disabling preemption.
This will be useful to minimize the amount of preemption disabling for the -rt
patch. It will help leveraging improvements brought by the local_t types
* Oleg Nesterov ([EMAIL PROTECTED]) wrote:
> On 07/11, Mathieu Desnoyers wrote:
> >
> > This patch adds the ability to protect critical sections from migration to
> > another CPU without disabling preemption.
> >
> > This will be useful to minimize the amount of preemption disabling for the
> >
On 07/11, Mathieu Desnoyers wrote:
>
> This patch adds the ability to protect critical sections from migration to
> another CPU without disabling preemption.
>
> This will be useful to minimize the amount of preemption disabling for the -rt
> patch. It will help leveraging improvements brought by
* Andi Kleen ([EMAIL PROTECTED]) wrote:
> On Fri, Jul 06, 2007 at 10:41:44AM -0400, Mathieu Desnoyers wrote:
> > I haven't thought about making it the default for kernel space
> > preemption, but yes, it would make sense.
>
> Now it's too late -- getcpu() has infected the kernel everywhere.
> It w
Hi,
Still as an RFC, here is an updated version of the migration handling
code in sched.c that supports migrate_disable()/migrate_enable().
I have taken care of the comments I received, thanks. I switched to
migrate_enable/disable following Matt Mackall's comments. He also
suggested to create, fo
Mathieu Desnoyers wrote:
* Matt Mackall ([EMAIL PROTECTED]) wrote:
On Wed, Jul 11, 2007 at 10:02:23AM +1000, Nick Piggin wrote:
I like this patch a lot. Even if we don't add the underlying mechanism
right now, adding migration_disable as an alias for preempt_disable
will much better document
* Matt Mackall ([EMAIL PROTECTED]) wrote:
> On Wed, Jul 11, 2007 at 10:02:23AM +1000, Nick Piggin wrote:
> > >I like this patch a lot. Even if we don't add the underlying mechanism
> > >right now, adding migration_disable as an alias for preempt_disable
> > >will much better document quite a number
On Wed, Jul 11, 2007 at 10:02:23AM +1000, Nick Piggin wrote:
> >I like this patch a lot. Even if we don't add the underlying mechanism
> >right now, adding migration_disable as an alias for preempt_disable
> >will much better document quite a number of the users.
>
> I'd have no problem with that,
Matt Mackall wrote:
On Fri, Jul 06, 2007 at 04:12:10PM +1000, Nick Piggin wrote:
Mathieu Desnoyers wrote:
Thread Migration Preemption
This patch adds the ability to protect critical sections from migration to
another CPU without disabling preemption.
This will be useful to minimize the amou
On Fri, Jul 06, 2007 at 04:12:10PM +1000, Nick Piggin wrote:
> Mathieu Desnoyers wrote:
> >Thread Migration Preemption
> >
> >This patch adds the ability to protect critical sections from migration to
> >another CPU without disabling preemption.
> >
> >This will be useful to minimize the amount of
Steven Rostedt wrote:
On Fri, 2007-07-06 at 16:12 +1000, Nick Piggin wrote:
Mathieu Desnoyers wrote:
migration_disable();
local_inc(&__get_cpu_var(&my_local_t_var));
migration_enable();
[...]
This seems like way too much stuff to add just for this type of thing. Why
not just disable
On Fri, Jul 06, 2007 at 10:41:44AM -0400, Mathieu Desnoyers wrote:
> I haven't thought about making it the default for kernel space
> preemption, but yes, it would make sense.
Now it's too late -- getcpu() has infected the kernel everywhere.
It would have made sense a few years ago.
> ... getcpu
On Fri, 2007-07-06 at 10:34 -0400, Steven Rostedt wrote:
> thing is that in RT an IRQ thread might service a softirq if that
> softirq thread is of the same priority as the IRQ thread. The difference
> between an IRQ thread and a softirq thread is that the IRQ thread may
> migrate but the softirq
On 07/06, Mathieu Desnoyers wrote:
>
> * Oleg Nesterov ([EMAIL PROTECTED]) wrote:
> > Mathieu Desnoyers wrote:
> > >
> > > This patch adds the ability to protect critical sections from migration to
> > > another CPU without disabling preemption.
> > >
> > > Typical use:
> > >
> > > migration_disabl
* Andi Kleen ([EMAIL PROTECTED]) wrote:
> Mathieu Desnoyers <[EMAIL PROTECTED]> writes:
>
> > Thread Migration Preemption
> >
> > This patch adds the ability to protect critical sections from migration to
> > another CPU without disabling preemption.
>
> Good idea.
>
> I sometimes think we coul
* Nick Piggin ([EMAIL PROTECTED]) wrote:
> Mathieu Desnoyers wrote:
> >Thread Migration Preemption
> >
> >This patch adds the ability to protect critical sections from migration to
> >another CPU without disabling preemption.
> >
> >This will be useful to minimize the amount of preemption disabling
On Fri, 2007-07-06 at 16:12 +1000, Nick Piggin wrote:
> Mathieu Desnoyers wrote:
> > migration_disable();
> > local_inc(&__get_cpu_var(&my_local_t_var));
> > migration_enable();
> >
[...]
> This seems like way too much stuff to add just for this type of thing. Why
> not just disable and reenabl
* Oleg Nesterov ([EMAIL PROTECTED]) wrote:
> Mathieu Desnoyers wrote:
> >
> > This patch adds the ability to protect critical sections from migration to
> > another CPU without disabling preemption.
> >
> > Typical use:
> >
> > migration_disable();
> > local_inc(&__get_cpu_var(&my_local_t_var));
>
Mathieu Desnoyers <[EMAIL PROTECTED]> writes:
> Thread Migration Preemption
>
> This patch adds the ability to protect critical sections from migration to
> another CPU without disabling preemption.
Good idea.
I sometimes think we could have avoided _much_ trouble
if that had been always defaul
Mathieu Desnoyers wrote:
Thread Migration Preemption
This patch adds the ability to protect critical sections from migration to
another CPU without disabling preemption.
This will be useful to minimize the amount of preemption disabling for the -rt
patch. It will help leveraging improvements br
Mathieu Desnoyers wrote:
>
> This patch adds the ability to protect critical sections from migration to
> another CPU without disabling preemption.
>
> Typical use:
>
> migration_disable();
> local_inc(&__get_cpu_var(&my_local_t_var));
> migration_enable();
>
> --- linux-2.6-lttng.orig/kernel/sched
On Thu, 2007-07-05 at 17:51 -0400, Mathieu Desnoyers wrote:
> Thread Migration Preemption
>
> This patch adds the ability to protect critical sections from migration to
> another CPU without disabling preemption.
>
> This will be useful to minimize the amount of preemption disabling for the -rt
>
Thread Migration Preemption
This patch adds the ability to protect critical sections from migration to
another CPU without disabling preemption.
This will be useful to minimize the amount of preemption disabling for the -rt
patch. It will help leveraging improvements brought by the local_t types
33 matches
Mail list logo
