Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-22 Thread Pranavkumar Sawargaonkar
On 22 April 2013 10:45, Rusty Russell wrote: > Anup Patel writes: >> On 22 April 2013 06:51, Rusty Russell wrote: >>> >>> Pranavkumar Sawargaonkar writes: >>> > On 18 April 2013 12:21, Rusty Russell wrote: >>> >> >>> >> PranavkumarSawargaonkar writes: >>> >> > From: Pranavkumar Sawargaonkar

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-22 Thread Alexander Graf
On 22.04.2013, at 05:10, Anup Patel wrote: > On 22 April 2013 06:51, Rusty Russell wrote: >> >> Pranavkumar Sawargaonkar writes: >>> On 18 April 2013 12:21, Rusty Russell wrote: PranavkumarSawargaonkar writes: > From: Pranavkumar Sawargaonkar > > This patch implement

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-22 Thread Rusty Russell
Anup Patel writes: > On 22 April 2013 06:51, Rusty Russell wrote: >> >> Pranavkumar Sawargaonkar writes: >> > On 18 April 2013 12:21, Rusty Russell wrote: >> >> >> >> PranavkumarSawargaonkar writes: >> >> > From: Pranavkumar Sawargaonkar >> >> > >> >> > This patch implements early printk supp

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-21 Thread Anup Patel
On 22 April 2013 06:51, Rusty Russell wrote: > > Pranavkumar Sawargaonkar writes: > > On 18 April 2013 12:21, Rusty Russell wrote: > >> > >> PranavkumarSawargaonkar writes: > >> > From: Pranavkumar Sawargaonkar > >> > > >> > This patch implements early printk support for virtio-mmio console >

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-21 Thread Rusty Russell
Pranavkumar Sawargaonkar writes: > On 18 April 2013 12:21, Rusty Russell wrote: >> >> PranavkumarSawargaonkar writes: >> > From: Pranavkumar Sawargaonkar >> > >> > This patch implements early printk support for virtio-mmio console devices >> > without using any hypercalls. >> >> This makes som

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-19 Thread Peter Maydell
On 19 April 2013 18:14, Catalin Marinas wrote: > On Fri, Apr 19, 2013 at 05:33:18PM +0100, Peter Maydell wrote: >> The command line lives in the DTB anyway so if you can't look >> in the DTB you can't get at earlyprintk config either way. > > Linux indeed looks in the DT for the command line and t

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-19 Thread Catalin Marinas
On Fri, Apr 19, 2013 at 05:33:18PM +0100, Peter Maydell wrote: > On 19 April 2013 17:22, Catalin Marinas wrote: > > earlyprintk is used for debugging early problems, like DT parsing. You > > don't have to use it unless you are debugging something. Without > > earlyprintk you just get a normal cons

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-19 Thread Peter Maydell
On 19 April 2013 17:22, Catalin Marinas wrote: > earlyprintk is used for debugging early problems, like DT parsing. You > don't have to use it unless you are debugging something. Without > earlyprintk you just get a normal console during boot, based on the DT > description. The command line lives

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-19 Thread Catalin Marinas
On Fri, Apr 19, 2013 at 05:14:36PM +0100, Peter Maydell wrote: > On 19 April 2013 17:12, Catalin Marinas wrote: > > On Fri, Apr 19, 2013 at 11:05:47AM +0100, Peter Maydell wrote: > >> Please make the kernel pick the device out of the device tree > >> blob. The whole point of device tree is that it

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-19 Thread Peter Maydell
On 19 April 2013 17:12, Catalin Marinas wrote: > On Fri, Apr 19, 2013 at 11:05:47AM +0100, Peter Maydell wrote: >> Please make the kernel pick the device out of the device tree >> blob. The whole point of device tree is that it's how to tell >> the kernel where things live -- making kvmtool/QEMU a

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-19 Thread Catalin Marinas
On Fri, Apr 19, 2013 at 11:05:47AM +0100, Peter Maydell wrote: > On 19 April 2013 10:39, Will Deacon wrote: > > The point of mach-virt is that it is completely parameterised. So, if you're > > not emulating an 8250, then don't tell the kernel that you have one! > > Similarly, if you *do* emulate i

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-19 Thread Peter Maydell
On 19 April 2013 10:39, Will Deacon wrote: > The point of mach-virt is that it is completely parameterised. So, if you're > not emulating an 8250, then don't tell the kernel that you have one! > Similarly, if you *do* emulate it, then either create a device-tree node for > it or pass the appropria

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-19 Thread Will Deacon
On Fri, Apr 19, 2013 at 10:34:56AM +0100, Pranavkumar Sawargaonkar wrote: > On 19 April 2013 15:00, Peter Maydell wrote: > > On 19 April 2013 10:27, Will Deacon wrote: > >> On Fri, Apr 19, 2013 at 10:25:35AM +0100, Pranavkumar Sawargaonkar wrote: > >>> I am not against using 8250 emulation (as fa

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-19 Thread Will Deacon
On Fri, Apr 19, 2013 at 10:30:40AM +0100, Peter Maydell wrote: > On 19 April 2013 10:27, Will Deacon wrote: > > On Fri, Apr 19, 2013 at 10:25:35AM +0100, Pranavkumar Sawargaonkar wrote: > >> I am not against using 8250 emulation (as far as it solves printk > >> issues for kernel booting logs), but

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-19 Thread Pranavkumar Sawargaonkar
On 19 April 2013 15:00, Peter Maydell wrote: > On 19 April 2013 10:27, Will Deacon wrote: >> On Fri, Apr 19, 2013 at 10:25:35AM +0100, Pranavkumar Sawargaonkar wrote: >>> I am not against using 8250 emulation (as far as it solves printk >>> issues for kernel booting logs), but my point is why not

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-19 Thread Peter Maydell
On 19 April 2013 10:27, Will Deacon wrote: > On Fri, Apr 19, 2013 at 10:25:35AM +0100, Pranavkumar Sawargaonkar wrote: >> I am not against using 8250 emulation (as far as it solves printk >> issues for kernel booting logs), but my point is why not to add early >> read-write support for virtio cons

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-19 Thread Will Deacon
On Fri, Apr 19, 2013 at 10:25:35AM +0100, Pranavkumar Sawargaonkar wrote: > On 19 April 2013 14:35, Will Deacon wrote: > > On Thu, Apr 18, 2013 at 09:48:49AM +0100, Pranavkumar Sawargaonkar wrote: > >> Actually i thought adding a config register will be easier to add a > >> code than writing entir

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-19 Thread Pranavkumar Sawargaonkar
Hi Will, On 19 April 2013 14:35, Will Deacon wrote: > Hello, > > On Thu, Apr 18, 2013 at 09:48:49AM +0100, Pranavkumar Sawargaonkar wrote: >> Actually i thought adding a config register will be easier to add a >> code than writing entire emulation as 8250 emulation will require to >> deal with dea

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-19 Thread Will Deacon
Hello, On Thu, Apr 18, 2013 at 09:48:49AM +0100, Pranavkumar Sawargaonkar wrote: > Actually i thought adding a config register will be easier to add a > code than writing entire emulation as 8250 emulation will require to > deal with dealing with more registers and more code. kvmtool already has

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-18 Thread Pranavkumar Sawargaonkar
On 18 April 2013 13:06, Marc Zyngier wrote: > On Thu, 18 Apr 2013 12:47:18 +0530, Pranavkumar Sawargaonkar > wrote: >> Hi Marc, >> >> On 18 April 2013 12:19, Marc Zyngier wrote: >> >>> Hi Pranavkumar, >>> >>> On Thu, 18 Apr 2013 11:22:24 +0530, PranavkumarSawargaonkar >>> wrote: >>> > From: Pra

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-18 Thread Pranavkumar Sawargaonkar
On 18 April 2013 21:29, Marc Zyngier wrote: > On Thu, 18 Apr 2013 11:25:56 -0400, Christopher Covington > wrote: >> Hi Pranavkumar, >> >> On 04/18/2013 01:52 AM, PranavkumarSawargaonkar wrote: >>> From: Pranavkumar Sawargaonkar >>> >>> This patch implements early printk support for virtio-mmio c

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-18 Thread Marc Zyngier
On Thu, 18 Apr 2013 11:25:56 -0400, Christopher Covington wrote: > Hi Pranavkumar, > > On 04/18/2013 01:52 AM, PranavkumarSawargaonkar wrote: >> From: Pranavkumar Sawargaonkar >> >> This patch implements early printk support for virtio-mmio console >> devices >> without using any hypercalls. >

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-18 Thread Christopher Covington
Hi Pranavkumar, On 04/18/2013 01:52 AM, PranavkumarSawargaonkar wrote: > From: Pranavkumar Sawargaonkar > > This patch implements early printk support for virtio-mmio console devices > without using any hypercalls. Is it possible that using DCC might be an easier solution? [...] Regards, Chr

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-18 Thread Jean-Christophe PLAGNIOL-VILLARD
On 13:02 Thu 18 Apr , Pranavkumar Sawargaonkar wrote: > On 18 April 2013 12:21, Rusty Russell wrote: > > > > PranavkumarSawargaonkar writes: > > > From: Pranavkumar Sawargaonkar > > > > > > This patch implements early printk support for virtio-mmio console > > > devices without using any hy

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-18 Thread Pranavkumar Sawargaonkar
Hi, On 18 April 2013 14:14, Alexander Graf wrote: > > > Am 18.04.2013 um 09:32 schrieb Pranavkumar Sawargaonkar > : > >> On 18 April 2013 12:21, Rusty Russell wrote: >>> >>> PranavkumarSawargaonkar writes: From: Pranavkumar Sawargaonkar This patch implements early printk suppor

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-18 Thread Alexander Graf
Am 18.04.2013 um 10:48 schrieb Pranavkumar Sawargaonkar : > Hi Marc, > > On 18 April 2013 13:06, Marc Zyngier wrote: >> On Thu, 18 Apr 2013 12:47:18 +0530, Pranavkumar Sawargaonkar >> wrote: >>> Hi Marc, >>> >>> On 18 April 2013 12:19, Marc Zyngier wrote: >>> Hi Pranavkumar, >>

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-18 Thread Marc Zyngier
On Thu, 18 Apr 2013 09:30:52 +0100, Peter Maydell wrote: > On 18 April 2013 07:49, Marc Zyngier wrote: >> If you need an early console, why not simply wire the 8250 emulation in >> kvmtool to be useable from the MMIO bus? I reckon this would solve your >> problem in a more elegant way... > > The

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-18 Thread Alexander Graf
Am 18.04.2013 um 10:30 schrieb Peter Maydell : > On 18 April 2013 07:49, Marc Zyngier wrote: >> If you need an early console, why not simply wire the 8250 emulation in >> kvmtool to be useable from the MMIO bus? I reckon this would solve your >> problem in a more elegant way... > > The other a

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-18 Thread Pranavkumar Sawargaonkar
Hi Marc, On 18 April 2013 13:06, Marc Zyngier wrote: > On Thu, 18 Apr 2013 12:47:18 +0530, Pranavkumar Sawargaonkar > wrote: >> Hi Marc, >> >> On 18 April 2013 12:19, Marc Zyngier wrote: >> >>> Hi Pranavkumar, >>> >>> On Thu, 18 Apr 2013 11:22:24 +0530, PranavkumarSawargaonkar >>> wrote: >>> >

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-18 Thread Alexander Graf
Am 18.04.2013 um 09:32 schrieb Pranavkumar Sawargaonkar : > On 18 April 2013 12:21, Rusty Russell wrote: >> >> PranavkumarSawargaonkar writes: >>> From: Pranavkumar Sawargaonkar >>> >>> This patch implements early printk support for virtio-mmio console devices >>> without using any hyperc

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-18 Thread Peter Maydell
On 18 April 2013 07:49, Marc Zyngier wrote: > If you need an early console, why not simply wire the 8250 emulation in > kvmtool to be useable from the MMIO bus? I reckon this would solve your > problem in a more elegant way... The other approach I thought of would be something involving defining

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-18 Thread Marc Zyngier
On Thu, 18 Apr 2013 12:47:18 +0530, Pranavkumar Sawargaonkar wrote: > Hi Marc, > > On 18 April 2013 12:19, Marc Zyngier wrote: > >> Hi Pranavkumar, >> >> On Thu, 18 Apr 2013 11:22:24 +0530, PranavkumarSawargaonkar >> wrote: >> > From: Pranavkumar Sawargaonkar >> > >> > This patch implements e

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-18 Thread Pranavkumar Sawargaonkar
On 18 April 2013 12:21, Rusty Russell wrote: > > PranavkumarSawargaonkar writes: > > From: Pranavkumar Sawargaonkar > > > > This patch implements early printk support for virtio-mmio console devices > > without using any hypercalls. > > This makes some sense, though not sure that early console

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-18 Thread Pranavkumar Sawargaonkar
Hi Marc, On 18 April 2013 12:19, Marc Zyngier wrote: > Hi Pranavkumar, > > On Thu, 18 Apr 2013 11:22:24 +0530, PranavkumarSawargaonkar > wrote: >> From: Pranavkumar Sawargaonkar >> >> This patch implements early printk support for virtio-mmio console > devices >> without using any hypercalls. >

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-18 Thread Marc Zyngier
Hi Pranavkumar, On Thu, 18 Apr 2013 11:22:24 +0530, PranavkumarSawargaonkar wrote: > From: Pranavkumar Sawargaonkar > > This patch implements early printk support for virtio-mmio console devices > without using any hypercalls. > > The current virtio early printk code in kernel expects that hyp

Re: [RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-17 Thread Rusty Russell
PranavkumarSawargaonkar writes: > From: Pranavkumar Sawargaonkar > > This patch implements early printk support for virtio-mmio console devices > without using any hypercalls. This makes some sense, though not sure that early console *read* makes much sense. I can see the PCI version of this b

[RFC] arm64: Early printk support for virtio-mmio console devices.

2013-04-17 Thread PranavkumarSawargaonkar
From: Pranavkumar Sawargaonkar This patch implements early printk support for virtio-mmio console devices without using any hypercalls. The current virtio early printk code in kernel expects that hypervisor will provide some mechanism generally a hypercall to support early printk. This patch