Re: [RFC] clocksouce implementation for powerpc

2007-06-22 Thread Sergei Shtylyov
Tony Breeds wrote: Thanks for taking the time to look over my patch. I guess it's been based on the prior work by John Stultz (and me too :-)? At some level I guess so. John did send me a patch a while ago. If you mean the init. part, this has been already done by me --

Re: [RFC] clocksouce implementation for powerpc

2007-06-22 Thread Tony Breeds
On Wed, Jun 20, 2007 at 02:06:01PM -0700, john stultz wrote: Hi John. > Hey Tony, > Thanks for sending this out! I really appreciate this work, as its been > on my todo forever, and I've just not been able to focus on it. > Currently it seems a bit minimal of a conversion (ideally there

Re: [RFC] clocksouce implementation for powerpc

2007-06-22 Thread Tony Breeds
On Wed, Jun 20, 2007 at 07:57:19AM -0700, Daniel Walker wrote: Hi Daniel. > As I said in our private thread, I do think you should be using > update_vsyscall() .. update_vsyscall() is just called when the time is > set, usually that happens in the timer interrupt and sometimes that > happens in

Re: [RFC] clocksouce implementation for powerpc

2007-06-22 Thread Tony Breeds
On Wed, Jun 20, 2007 at 08:53:47PM +0400, Sergei Shtylyov wrote: Hi Sergei, Thanks for taking the time to look over my patch. >I guess it's been based on the prior work by John Stultz (and me too :-)? At some level I guess so. John did send me a patch a while ago. >If you

Re: [RFC] clocksouce implementation for powerpc

2007-06-22 Thread Tony Breeds
On Wed, Jun 20, 2007 at 08:53:47PM +0400, Sergei Shtylyov wrote: Hi Sergei, Thanks for taking the time to look over my patch. I guess it's been based on the prior work by John Stultz (and me too :-)? At some level I guess so. John did send me a patch a while ago. If you mean

Re: [RFC] clocksouce implementation for powerpc

2007-06-22 Thread Tony Breeds
On Wed, Jun 20, 2007 at 07:57:19AM -0700, Daniel Walker wrote: Hi Daniel. As I said in our private thread, I do think you should be using update_vsyscall() .. update_vsyscall() is just called when the time is set, usually that happens in the timer interrupt and sometimes that happens in

Re: [RFC] clocksouce implementation for powerpc

2007-06-22 Thread Tony Breeds
On Wed, Jun 20, 2007 at 02:06:01PM -0700, john stultz wrote: Hi John. Hey Tony, Thanks for sending this out! I really appreciate this work, as its been on my todo forever, and I've just not been able to focus on it. Currently it seems a bit minimal of a conversion (ideally there should

Re: [RFC] clocksouce implementation for powerpc

2007-06-22 Thread Sergei Shtylyov
Tony Breeds wrote: Thanks for taking the time to look over my patch. I guess it's been based on the prior work by John Stultz (and me too :-)? At some level I guess so. John did send me a patch a while ago. If you mean the init. part, this has been already done by me --

Re: [RFC] clocksouce implementation for powerpc

2007-06-20 Thread john stultz
On Wed, 2007-06-20 at 16:57 +1000, Tony Breeds wrote: > On Sat, Jun 16, 2007 at 08:51:23AM -0700, Daniel Walker wrote: > > On Sat, 2007-06-16 at 10:36 +, Thomas Gleixner wrote: > > > plain text document attachment > > > (clocksource-add-settimeofday-hook.patch) > > > From: Tony Breeds <[EMAIL

Re: [RFC] clocksouce implementation for powerpc

2007-06-20 Thread Sergei Shtylyov
Hello. Thomas Gleixner wrote: +void update_vsyscall(struct timespec *wall_time, struct clocksource *clock) +{ + timer_recalc_offset(tb_last_jiffy); + timer_check_rtc(); +} Hmm .. This doesn't look like it's taking into account that the time has changed .. Why? By the time

Re: [RFC] clocksouce implementation for powerpc

2007-06-20 Thread Thomas Gleixner
On Wed, 2007-06-20 at 21:20 +0400, Sergei Shtylyov wrote: > >>+void update_vsyscall(struct timespec *wall_time, struct clocksource *clock) > >>+{ > >>+ timer_recalc_offset(tb_last_jiffy); > >>+ timer_check_rtc(); > >>+} > > > Hmm .. This doesn't look like it's taking into account that the

Re: [RFC] clocksouce implementation for powerpc

2007-06-20 Thread Sergei Shtylyov
Daniel Walker wrote: +static void clocksource_settimeofday(struct clocksource *cs, + struct timespec *ts) +{ + u64 new_xsec; + +#ifdef CONFIG_PPC_ISERIES + if (firmware_has_feature(FW_FEATURE_ISERIES) && first_settimeofday) { +

Re: [RFC] clocksouce implementation for powerpc

2007-06-20 Thread Sergei Shtylyov
Hello. Tony Breeds wrote: plain text document attachment (clocksource-add-settimeofday-hook.patch) From: Tony Breeds <[EMAIL PROTECTED] > I'm working on a clocksource implementation for all powerpc platforms. some of these platforms needs to do a little work as part of the settimeofday()

Re: [RFC] clocksouce implementation for powerpc

2007-06-20 Thread Daniel Walker
On Wed, 2007-06-20 at 16:57 +1000, Tony Breeds wrote: > On Sat, Jun 16, 2007 at 08:51:23AM -0700, Daniel Walker wrote: > > On Sat, 2007-06-16 at 10:36 +, Thomas Gleixner wrote: > > > plain text document attachment > > > (clocksource-add-settimeofday-hook.patch) > > > From: Tony Breeds <[EMAIL

[RFC] clocksouce implementation for powerpc

2007-06-20 Thread Tony Breeds
On Sat, Jun 16, 2007 at 08:51:23AM -0700, Daniel Walker wrote: > On Sat, 2007-06-16 at 10:36 +, Thomas Gleixner wrote: > > plain text document attachment > > (clocksource-add-settimeofday-hook.patch) > > From: Tony Breeds <[EMAIL PROTECTED] > > > > > I'm working on a clocksource

[RFC] clocksouce implementation for powerpc

2007-06-20 Thread Tony Breeds
On Sat, Jun 16, 2007 at 08:51:23AM -0700, Daniel Walker wrote: On Sat, 2007-06-16 at 10:36 +, Thomas Gleixner wrote: plain text document attachment (clocksource-add-settimeofday-hook.patch) From: Tony Breeds [EMAIL PROTECTED] I'm working on a clocksource implementation for all

Re: [RFC] clocksouce implementation for powerpc

2007-06-20 Thread Daniel Walker
On Wed, 2007-06-20 at 16:57 +1000, Tony Breeds wrote: On Sat, Jun 16, 2007 at 08:51:23AM -0700, Daniel Walker wrote: On Sat, 2007-06-16 at 10:36 +, Thomas Gleixner wrote: plain text document attachment (clocksource-add-settimeofday-hook.patch) From: Tony Breeds [EMAIL PROTECTED]

Re: [RFC] clocksouce implementation for powerpc

2007-06-20 Thread Sergei Shtylyov
Hello. Tony Breeds wrote: plain text document attachment (clocksource-add-settimeofday-hook.patch) From: Tony Breeds [EMAIL PROTECTED] I'm working on a clocksource implementation for all powerpc platforms. some of these platforms needs to do a little work as part of the settimeofday()

Re: [RFC] clocksouce implementation for powerpc

2007-06-20 Thread Sergei Shtylyov
Daniel Walker wrote: +static void clocksource_settimeofday(struct clocksource *cs, + struct timespec *ts) +{ + u64 new_xsec; + +#ifdef CONFIG_PPC_ISERIES + if (firmware_has_feature(FW_FEATURE_ISERIES) first_settimeofday) { +

Re: [RFC] clocksouce implementation for powerpc

2007-06-20 Thread Thomas Gleixner
On Wed, 2007-06-20 at 21:20 +0400, Sergei Shtylyov wrote: +void update_vsyscall(struct timespec *wall_time, struct clocksource *clock) +{ + timer_recalc_offset(tb_last_jiffy); + timer_check_rtc(); +} Hmm .. This doesn't look like it's taking into account that the time has changed ..

Re: [RFC] clocksouce implementation for powerpc

2007-06-20 Thread Sergei Shtylyov
Hello. Thomas Gleixner wrote: +void update_vsyscall(struct timespec *wall_time, struct clocksource *clock) +{ + timer_recalc_offset(tb_last_jiffy); + timer_check_rtc(); +} Hmm .. This doesn't look like it's taking into account that the time has changed .. Why? By the time

Re: [RFC] clocksouce implementation for powerpc

2007-06-20 Thread john stultz
On Wed, 2007-06-20 at 16:57 +1000, Tony Breeds wrote: On Sat, Jun 16, 2007 at 08:51:23AM -0700, Daniel Walker wrote: On Sat, 2007-06-16 at 10:36 +, Thomas Gleixner wrote: plain text document attachment (clocksource-add-settimeofday-hook.patch) From: Tony Breeds [EMAIL PROTECTED]