Re: [RFC] dealing with proc_ns_follow_link() and "namespace" dentries

2014-11-24 Thread Al Viro
On Sat, Nov 01, 2014 at 06:30:37PM +, Al Viro wrote: > On Sat, Nov 01, 2014 at 03:06:20PM +, Al Viro wrote: > > On Sat, Nov 01, 2014 at 08:38:04AM +, Al Viro wrote: > > > OK, interim branch (_completely_ untested, and there's quite a bit of > > > work remaining) is in vfs.git#nsfs. > >

Re: [RFC] dealing with proc_ns_follow_link() and namespace dentries

2014-11-24 Thread Al Viro
On Sat, Nov 01, 2014 at 06:30:37PM +, Al Viro wrote: On Sat, Nov 01, 2014 at 03:06:20PM +, Al Viro wrote: On Sat, Nov 01, 2014 at 08:38:04AM +, Al Viro wrote: OK, interim branch (_completely_ untested, and there's quite a bit of work remaining) is in vfs.git#nsfs. ...

Re: [RFC] dealing with proc_ns_follow_link() and "namespace" dentries

2014-11-01 Thread Al Viro
On Sat, Nov 01, 2014 at 06:38:02PM +, Al Viro wrote: > On Sat, Nov 01, 2014 at 11:23:34AM -0700, Eric W.Biederman wrote: > > > >From your description I am concerned about using the letter combination > > >nsfs. I once used nsfd, and that was so close to nfsd that Linus got > > >confused,

Re: [RFC] dealing with proc_ns_follow_link() and "namespace" dentries

2014-11-01 Thread Al Viro
On Sat, Nov 01, 2014 at 11:23:34AM -0700, Eric W.Biederman wrote: > >From your description I am concerned about using the letter combination > >nsfs. I once used nsfd, and that was so close to nfsd that Linus got > >confused, and hilarity ensued. nsfs isn't quite as bad but the >

Re: [RFC] dealing with proc_ns_follow_link() and "namespace" dentries

2014-11-01 Thread Al Viro
On Sat, Nov 01, 2014 at 03:06:20PM +, Al Viro wrote: > On Sat, Nov 01, 2014 at 08:38:04AM +, Al Viro wrote: > > OK, interim branch (_completely_ untested, and there's quite a bit of > > work remaining) is in vfs.git#nsfs. > > ... except that what got pushed was completely buggered - the

Re: [RFC] dealing with proc_ns_follow_link() and "namespace" dentries

2014-11-01 Thread Eric W.Biederman
On November 1, 2014 8:06:20 AM PDT, Al Viro wrote: >On Sat, Nov 01, 2014 at 08:38:04AM +, Al Viro wrote: >> OK, interim branch (_completely_ untested, and there's quite a bit of >> work remaining) is in vfs.git#nsfs. > >... except that what got pushed was completely buggered - the last

Re: [RFC] dealing with proc_ns_follow_link() and "namespace" dentries

2014-11-01 Thread Al Viro
On Sat, Nov 01, 2014 at 08:38:04AM +, Al Viro wrote: > OK, interim branch (_completely_ untested, and there's quite a bit of > work remaining) is in vfs.git#nsfs. ... except that what got pushed was completely buggered - the last changes not committed *and* include/linux/ns_common.h not

Re: [RFC] dealing with proc_ns_follow_link() and "namespace" dentries

2014-11-01 Thread Al Viro
On Mon, Oct 13, 2014 at 03:42:28PM -0700, Eric W. Biederman wrote: > >From looking at your proposed code that doesn't look like it will be > any more difficult to maintain from the namespace side. So I have no > objects with moving the code in that direction. > > > It's obviously a project

Re: [RFC] dealing with proc_ns_follow_link() and namespace dentries

2014-11-01 Thread Al Viro
On Mon, Oct 13, 2014 at 03:42:28PM -0700, Eric W. Biederman wrote: From looking at your proposed code that doesn't look like it will be any more difficult to maintain from the namespace side. So I have no objects with moving the code in that direction. It's obviously a project for

Re: [RFC] dealing with proc_ns_follow_link() and namespace dentries

2014-11-01 Thread Al Viro
On Sat, Nov 01, 2014 at 08:38:04AM +, Al Viro wrote: OK, interim branch (_completely_ untested, and there's quite a bit of work remaining) is in vfs.git#nsfs. ... except that what got pushed was completely buggered - the last changes not committed *and* include/linux/ns_common.h not

Re: [RFC] dealing with proc_ns_follow_link() and namespace dentries

2014-11-01 Thread Eric W.Biederman
On November 1, 2014 8:06:20 AM PDT, Al Viro v...@zeniv.linux.org.uk wrote: On Sat, Nov 01, 2014 at 08:38:04AM +, Al Viro wrote: OK, interim branch (_completely_ untested, and there's quite a bit of work remaining) is in vfs.git#nsfs. ... except that what got pushed was completely buggered

Re: [RFC] dealing with proc_ns_follow_link() and namespace dentries

2014-11-01 Thread Al Viro
On Sat, Nov 01, 2014 at 03:06:20PM +, Al Viro wrote: On Sat, Nov 01, 2014 at 08:38:04AM +, Al Viro wrote: OK, interim branch (_completely_ untested, and there's quite a bit of work remaining) is in vfs.git#nsfs. ... except that what got pushed was completely buggered - the last

Re: [RFC] dealing with proc_ns_follow_link() and namespace dentries

2014-11-01 Thread Al Viro
On Sat, Nov 01, 2014 at 11:23:34AM -0700, Eric W.Biederman wrote: From your description I am concerned about using the letter combination nsfs. I once used nsfd, and that was so close to nfsd that Linus got confused, and hilarity ensued. nsfs isn't quite as bad but the abbreviation

Re: [RFC] dealing with proc_ns_follow_link() and namespace dentries

2014-11-01 Thread Al Viro
On Sat, Nov 01, 2014 at 06:38:02PM +, Al Viro wrote: On Sat, Nov 01, 2014 at 11:23:34AM -0700, Eric W.Biederman wrote: From your description I am concerned about using the letter combination nsfs. I once used nsfd, and that was so close to nfsd that Linus got confused, and

Re: [RFC] dealing with proc_ns_follow_link() and "namespace" dentries

2014-10-13 Thread Al Viro
On Mon, Oct 13, 2014 at 07:29:45AM +0100, Al Viro wrote: > there and get rid of pointless aliases. Oh, and we get a decent chance to > kill d_instantiate_unique(), which is also nice. Or at least fold it into > d_add_unique(), if we can't kill that sucker as well. And if we manage to > kill it

Re: [RFC] dealing with proc_ns_follow_link() and "namespace" dentries

2014-10-13 Thread Eric W. Biederman
Al Viro writes: > But more fundamentally, this stuff has no business being in procfs. The > *only* reason why we are putting them there (and get those inodes and > dentries duplicated for different procfs instances) is this in > do_loopback(): > if (!check_mnt(parent) ||

[RFC] dealing with proc_ns_follow_link() and "namespace" dentries

2014-10-13 Thread Al Viro
proc_ns_follow_link() is unique among the ->follow_link() instances in several respects, some of them violating general asserts expected by all kinds of VFS code. First of all, it can lead to pairs with dentry being completely unrelated to vfsmount. Suppose we bind such a

[RFC] dealing with proc_ns_follow_link() and namespace dentries

2014-10-13 Thread Al Viro
proc_ns_follow_link() is unique among the -follow_link() instances in several respects, some of them violating general asserts expected by all kinds of VFS code. First of all, it can lead to vfsmount,dentry pairs with dentry being completely unrelated to vfsmount. Suppose we bind

Re: [RFC] dealing with proc_ns_follow_link() and namespace dentries

2014-10-13 Thread Eric W. Biederman
Al Viro v...@zeniv.linux.org.uk writes: But more fundamentally, this stuff has no business being in procfs. The *only* reason why we are putting them there (and get those inodes and dentries duplicated for different procfs instances) is this in do_loopback(): if (!check_mnt(parent)

Re: [RFC] dealing with proc_ns_follow_link() and namespace dentries

2014-10-13 Thread Al Viro
On Mon, Oct 13, 2014 at 07:29:45AM +0100, Al Viro wrote: there and get rid of pointless aliases. Oh, and we get a decent chance to kill d_instantiate_unique(), which is also nice. Or at least fold it into d_add_unique(), if we can't kill that sucker as well. And if we manage to kill it