Re: [RFC] ext4-block-reservation.patch

2006-12-23 Thread Alex Tomas
Hi, > Andrew Morton (AM) writes: AM> Should be cacheline_aligned_in_smp. AM> That's assuming it needs to be cacheline aligned at all. It can consume a AM> lot of space. the idea is to make block reservation cheap because it's called for every page. AM> AM> oh, this should be

Re: [RFC] ext4-block-reservation.patch

2006-12-23 Thread Andrew Morton
On Fri, 22 Dec 2006 23:25:16 +0300 Alex Tomas <[EMAIL PROTECTED]> wrote: Once this code is settled in we should consider removal of the existing reservations code from ext4. > + > +struct ext4_reservation_slot { > + __u64 rs_reserved; > + spinlock_t rs_lock; > +}

Re: [RFC] ext4-block-reservation.patch

2006-12-23 Thread Andrew Morton
On Fri, 22 Dec 2006 23:25:16 +0300 Alex Tomas [EMAIL PROTECTED] wrote: Once this code is settled in we should consider removal of the existing reservations code from ext4. + +struct ext4_reservation_slot { + __u64 rs_reserved; + spinlock_t rs_lock; +}

Re: [RFC] ext4-block-reservation.patch

2006-12-23 Thread Alex Tomas
Hi, Andrew Morton (AM) writes: AM Should be cacheline_aligned_in_smp. AM That's assuming it needs to be cacheline aligned at all. It can consume a AM lot of space. the idea is to make block reservation cheap because it's called for every page. AM looks AM oh, this should be

[RFC] ext4-block-reservation.patch

2006-12-22 Thread Alex Tomas
Index: linux-2.6.20-rc1/include/linux/ext4_fs.h === --- linux-2.6.20-rc1.orig/include/linux/ext4_fs.h 2006-12-14 04:14:23.0 +0300 +++ linux-2.6.20-rc1/include/linux/ext4_fs.h2006-12-22 20:21:12.0 +0300 @@

[RFC] ext4-block-reservation.patch

2006-12-22 Thread Alex Tomas
Index: linux-2.6.20-rc1/include/linux/ext4_fs.h === --- linux-2.6.20-rc1.orig/include/linux/ext4_fs.h 2006-12-14 04:14:23.0 +0300 +++ linux-2.6.20-rc1/include/linux/ext4_fs.h2006-12-22 20:21:12.0 +0300 @@