Re: [RFC] firmware: annotate thou shalt not request fw on init or probe

On Thu, Sep 03, 2015 at 07:56:33AM +0200, Julia Lawall wrote: > > > On Thu, 3 Sep 2015, Luis R. Rodriguez wrote: > > > On Sat, Aug 29, 2015 at 06:18:20PM +0200, Julia Lawall wrote: > > > > +@ defines_module_init exists @ > > > > +declarer name module_init; > > > > +identifier init; > > > > +@@

Re: [RFC] firmware: annotate thou shalt not request fw on init or probe

On Thu, Sep 03, 2015 at 07:56:33AM +0200, Julia Lawall wrote: > > > On Thu, 3 Sep 2015, Luis R. Rodriguez wrote: > > > On Sat, Aug 29, 2015 at 06:18:20PM +0200, Julia Lawall wrote: > > > > +@ defines_module_init exists @ > > > > +declarer name module_init; > > > > +identifier init; > > > > +@@

Re: [Cocci] [RFC] firmware: annotate thou shalt not request fw on init or probe

> +@ calls_fw_on_init depends on defines_module_init @ > +identifier defines_module_init.init; > +position p1; > +@@ > + > +init(void) > +{ > + ... Would it make sense to use the specification "when any" for such a SmPL ellipsis? http://coccinelle.lip6.fr/docs/main_grammar004.html > +( >

Re: [Cocci] [RFC] firmware: annotate thou shalt not request fw on init or probe

> +@ calls_fw_on_init depends on defines_module_init @ > +identifier defines_module_init.init; > +position p1; > +@@ > + > +init(void) > +{ > + ... Would it make sense to use the specification "when any" for such a SmPL ellipsis? http://coccinelle.lip6.fr/docs/main_grammar004.html > +( >

Re: [RFC] firmware: annotate thou shalt not request fw on init or probe

On Thu, 3 Sep 2015, Luis R. Rodriguez wrote: > On Sat, Aug 29, 2015 at 06:18:20PM +0200, Julia Lawall wrote: > > > +@ defines_module_init exists @ > > > +declarer name module_init; > > > +identifier init; > > > +@@ > > > + > > > +module_init(init); > > > + > > > +@ has_probe depends on

Re: [RFC] firmware: annotate thou shalt not request fw on init or probe

On Tue, Sep 01, 2015 at 01:28:27PM -0400, Josh Boyer wrote: > On Fri, Aug 28, 2015 at 9:18 PM, Luis R. Rodriguez > wrote: > > From: "Luis R. Rodriguez" > > > > We are phasing out the usermode helper from the kernel, > > systemd already ripped support for this a while ago, the > > only remaining

Re: [RFC] firmware: annotate thou shalt not request fw on init or probe

On Sat, Aug 29, 2015 at 06:18:20PM +0200, Julia Lawall wrote: > > +@ defines_module_init exists @ > > +declarer name module_init; > > +identifier init; > > +@@ > > + > > +module_init(init); > > + > > +@ has_probe depends on defines_module_init @ > > +identifier drv_calls, drv_probe; > > +type

Re: [RFC] firmware: annotate thou shalt not request fw on init or probe

On Sat, Aug 29, 2015 at 06:18:20PM +0200, Julia Lawall wrote: > > +@ defines_module_init exists @ > > +declarer name module_init; > > +identifier init; > > +@@ > > + > > +module_init(init); > > + > > +@ has_probe depends on defines_module_init @ > > +identifier drv_calls, drv_probe; > > +type

Re: [RFC] firmware: annotate thou shalt not request fw on init or probe

On Tue, Sep 01, 2015 at 01:28:27PM -0400, Josh Boyer wrote: > On Fri, Aug 28, 2015 at 9:18 PM, Luis R. Rodriguez > wrote: > > From: "Luis R. Rodriguez" > > > > We are phasing out the usermode helper from the kernel, > > systemd already ripped support for

Re: [RFC] firmware: annotate thou shalt not request fw on init or probe

On Thu, 3 Sep 2015, Luis R. Rodriguez wrote: > On Sat, Aug 29, 2015 at 06:18:20PM +0200, Julia Lawall wrote: > > > +@ defines_module_init exists @ > > > +declarer name module_init; > > > +identifier init; > > > +@@ > > > + > > > +module_init(init); > > > + > > > +@ has_probe depends on

Re: [RFC] firmware: annotate thou shalt not request fw on init or probe

On Fri, Aug 28, 2015 at 9:18 PM, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > We are phasing out the usermode helper from the kernel, > systemd already ripped support for this a while ago, the > only remaining valid user is the Dell rbu driver. The Actually, I don't think that is

Re: [RFC] firmware: annotate thou shalt not request fw on init or probe

On Fri, Aug 28, 2015 at 9:18 PM, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > We are phasing out the usermode helper from the kernel, > systemd already ripped support for this a while ago, the > only remaining valid user is the Dell rbu

Re: [RFC] firmware: annotate thou shalt not request fw on init or probe

> +@ defines_module_init exists @ > +declarer name module_init; > +identifier init; > +@@ > + > +module_init(init); > + > +@ has_probe depends on defines_module_init @ > +identifier drv_calls, drv_probe; > +type bus_driver; > +identifier probe_op =~ "(probe)"; > +@@ > + > +bus_driver drv_calls = {

Re: [RFC] firmware: annotate thou shalt not request fw on init or probe

+@ defines_module_init exists @ +declarer name module_init; +identifier init; +@@ + +module_init(init); + +@ has_probe depends on defines_module_init @ +identifier drv_calls, drv_probe; +type bus_driver; +identifier probe_op =~ (probe); +@@ + +bus_driver drv_calls = { +

[RFC] firmware: annotate thou shalt not request fw on init or probe

From: "Luis R. Rodriguez" We are phasing out the usermode helper from the kernel, systemd already ripped support for this a while ago, the only remaining valid user is the Dell rbu driver. The firmware is now being read directly from the filesystem by the kernel. What this means is that if you

[RFC] firmware: annotate thou shalt not request fw on init or probe

From: Luis R. Rodriguez mcg...@suse.com We are phasing out the usermode helper from the kernel, systemd already ripped support for this a while ago, the only remaining valid user is the Dell rbu driver. The firmware is now being read directly from the filesystem by the kernel. What this means is