Re: [RFC] hwmon: (fam15h_power) Add bit masking for tdp_limit

2016-01-27 Thread Gi-Oh Kim
On 27.01.2016 07:45, Huang Rui wrote: On Tue, Jan 26, 2016 at 11:57:35AM +0100, Gi-Oh Kim wrote: On 26.01.2016 03:25, Huang Rui wrote: On Mon, Jan 25, 2016 at 07:41:07PM +0800, Gioh Kim wrote: Thanks for your reply. I'm not completely sure that the reserved bits are always zero. Are they al

Re: [RFC] hwmon: (fam15h_power) Add bit masking for tdp_limit

2016-01-26 Thread Huang Rui
On Tue, Jan 26, 2016 at 11:57:35AM +0100, Gi-Oh Kim wrote: > > > On 26.01.2016 03:25, Huang Rui wrote: > >On Mon, Jan 25, 2016 at 07:41:07PM +0800, Gioh Kim wrote: > Thanks for your reply. > I'm not completely sure that the reserved bits are always zero. > Are they always zero? > Or do we need b

Re: [RFC] hwmon: (fam15h_power) Add bit masking for tdp_limit

2016-01-26 Thread Gi-Oh Kim
On 26.01.2016 03:25, Huang Rui wrote: On Mon, Jan 25, 2016 at 07:41:07PM +0800, Gioh Kim wrote: The bits [31:29] of D18F5xE8 TDP Limit3 are reserved. I think it'd better to add masking to read ApmTdpLimit[28:16] precisely. Signed-off-by: Gioh Kim --- drivers/hwmon/fam15h_power.c | 2 +- 1

Re: [RFC] hwmon: (fam15h_power) Add bit masking for tdp_limit

2016-01-25 Thread Guenter Roeck
On 01/25/2016 06:25 PM, Huang Rui wrote: On Mon, Jan 25, 2016 at 07:41:07PM +0800, Gioh Kim wrote: The bits [31:29] of D18F5xE8 TDP Limit3 are reserved. I think it'd better to add masking to read ApmTdpLimit[28:16] precisely. Signed-off-by: Gioh Kim --- drivers/hwmon/fam15h_power.c | 2 +-

Re: [RFC] hwmon: (fam15h_power) Add bit masking for tdp_limit

2016-01-25 Thread Huang Rui
On Mon, Jan 25, 2016 at 07:41:07PM +0800, Gioh Kim wrote: > The bits [31:29] of D18F5xE8 TDP Limit3 are reserved. > I think it'd better to add masking to read ApmTdpLimit[28:16] precisely. > > Signed-off-by: Gioh Kim > --- > drivers/hwmon/fam15h_power.c | 2 +- > 1 file changed, 1 insertion(+),

[RFC] hwmon: (fam15h_power) Add bit masking for tdp_limit

2016-01-25 Thread Gioh Kim
The bits [31:29] of D18F5xE8 TDP Limit3 are reserved. I think it'd better to add masking to read ApmTdpLimit[28:16] precisely. Signed-off-by: Gioh Kim --- drivers/hwmon/fam15h_power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/fam15h_power.c b/drivers/hwmon