Re: [RFC] linux-next panic in hugepage_subpool_put_pages()

2021-02-23 Thread Andrew Morton
On Tue, 23 Feb 2021 17:29:48 -0800 Mike Kravetz wrote: > >> I will do a bit more verification and put together a patch (it should > >> be simple). > > > > There's also Michel's documentation request: > > https://lkml.kernel.org/r/20210127102645.gh...@dhcp22.suse.cz > > > > Thanks Andrew, I

Re: [RFC] linux-next panic in hugepage_subpool_put_pages()

2021-02-23 Thread Mike Kravetz
On 2/23/21 3:58 PM, Andrew Morton wrote: > On Tue, 23 Feb 2021 10:06:12 -0800 Mike Kravetz > wrote: > >> On 2/23/21 6:57 AM, Gerald Schaefer wrote: >>> Hi, >>> >>> LTP triggered a panic on s390 in hugepage_subpool_put_pages() with >>> linux-next 5.12.0-20210222, see below. >>> >>> It crashes on

Re: [RFC] linux-next panic in hugepage_subpool_put_pages()

2021-02-23 Thread Andrew Morton
On Tue, 23 Feb 2021 10:06:12 -0800 Mike Kravetz wrote: > On 2/23/21 6:57 AM, Gerald Schaefer wrote: > > Hi, > > > > LTP triggered a panic on s390 in hugepage_subpool_put_pages() with > > linux-next 5.12.0-20210222, see below. > > > > It crashes on the spin_lock(>lock) at the beginning, because

Re: [RFC] linux-next panic in hugepage_subpool_put_pages()

2021-02-23 Thread Mike Kravetz
On 2/23/21 6:57 AM, Gerald Schaefer wrote: > Hi, > > LTP triggered a panic on s390 in hugepage_subpool_put_pages() with > linux-next 5.12.0-20210222, see below. > > It crashes on the spin_lock(>lock) at the beginning, because the > passed-in *spool points to 004e, which is not

Re: [RFC] linux-next panic in hugepage_subpool_put_pages()

2021-02-23 Thread Gerald Schaefer
On Tue, 23 Feb 2021 15:57:40 +0100 Gerald Schaefer wrote: [...] > What I do not understand is how __free_huge_page() would be called at all > in the call trace below (set_max_huge_pages -> alloc_pool_huge_page -> > __free_huge_page -> hugepage_subpool_put_pages). From the code it seems > that

[RFC] linux-next panic in hugepage_subpool_put_pages()

2021-02-23 Thread Gerald Schaefer
Hi, LTP triggered a panic on s390 in hugepage_subpool_put_pages() with linux-next 5.12.0-20210222, see below. It crashes on the spin_lock(>lock) at the beginning, because the passed-in *spool points to 004e, which is not addressable memory. It rather looks like some flags and not a