Re: [RFC] memory: exynos5422-dmc: Document mutex scope

2020-08-11 Thread Lukasz Luba
On 8/9/20 10:12 AM, Krzysztof Kozlowski wrote: On Tue, Aug 04, 2020 at 11:40:07AM +0100, Lukasz Luba wrote: Hi Krzysztof, On 7/24/20 7:08 PM, Krzysztof Kozlowski wrote: Document scope of the mutex used by driver. Signed-off-by: Krzysztof Kozlowski --- It seems mutex was introduced to pr

Re: [RFC] memory: exynos5422-dmc: Document mutex scope

2020-08-09 Thread Krzysztof Kozlowski
On Tue, Aug 04, 2020 at 11:40:07AM +0100, Lukasz Luba wrote: > Hi Krzysztof, > > On 7/24/20 7:08 PM, Krzysztof Kozlowski wrote: > > Document scope of the mutex used by driver. > > > > Signed-off-by: Krzysztof Kozlowski > > > > --- > > > > It seems mutex was introduced to protect: > > 1. setting ac

Re: [RFC] memory: exynos5422-dmc: Document mutex scope

2020-08-04 Thread Lukasz Luba
Hi Krzysztof, On 7/24/20 7:08 PM, Krzysztof Kozlowski wrote: Document scope of the mutex used by driver. Signed-off-by: Krzysztof Kozlowski --- It seems mutex was introduced to protect: 1. setting actual frequency/voltage, 2. dmc->curr_rate (in exynos5_dmc_get_cur_freq()). However dmc->curr

[RFC] memory: exynos5422-dmc: Document mutex scope

2020-07-24 Thread Krzysztof Kozlowski
Document scope of the mutex used by driver. Signed-off-by: Krzysztof Kozlowski --- It seems mutex was introduced to protect: 1. setting actual frequency/voltage, 2. dmc->curr_rate (in exynos5_dmc_get_cur_freq()). However dmc->curr_rate in exynos5_dmc_get_status() is not protected. Is it a bug?