Re: [RFC] mmc: cqhci: commit descriptors before setting the doorbell

2019-10-18 Thread Faiz Abbas
Hi Uffe, On 18/10/19 4:28 PM, Ulf Hansson wrote: > On Mon, 14 Oct 2019 at 20:37, Faiz Abbas wrote: >> >> Add a write memory barrier to make sure that descriptors are actually >> written to memory before ringing the doorbell. >> >> Signed-off-by: Faiz Abbas > > Applied for fixes and by adding a

Re: [RFC] mmc: cqhci: commit descriptors before setting the doorbell

2019-10-18 Thread Ulf Hansson
On Mon, 14 Oct 2019 at 20:37, Faiz Abbas wrote: > > Add a write memory barrier to make sure that descriptors are actually > written to memory before ringing the doorbell. > > Signed-off-by: Faiz Abbas Applied for fixes and by adding a stable tag, thanks! BTW, do you have a valid commit that it

Re: [RFC] mmc: cqhci: commit descriptors before setting the doorbell

2019-10-18 Thread Adrian Hunter
On 18/10/19 10:22 AM, Faiz Abbas wrote: > Adrian, > > On 16/10/19 5:46 PM, Faiz Abbas wrote: >> Adrian, >> >> On 15/10/19 7:15 PM, Adrian Hunter wrote: >>> On 15/10/19 10:55 AM, Faiz Abbas wrote: Hi, On 15/10/19 12:08 AM, Faiz Abbas wrote: > Add a write memory barrier to make su

Re: [RFC] mmc: cqhci: commit descriptors before setting the doorbell

2019-10-18 Thread Faiz Abbas
Adrian, On 16/10/19 5:46 PM, Faiz Abbas wrote: > Adrian, > > On 15/10/19 7:15 PM, Adrian Hunter wrote: >> On 15/10/19 10:55 AM, Faiz Abbas wrote: >>> Hi, >>> >>> On 15/10/19 12:08 AM, Faiz Abbas wrote: Add a write memory barrier to make sure that descriptors are actually written to memo

Re: [RFC] mmc: cqhci: commit descriptors before setting the doorbell

2019-10-16 Thread Faiz Abbas
Adrian, On 15/10/19 7:15 PM, Adrian Hunter wrote: > On 15/10/19 10:55 AM, Faiz Abbas wrote: >> Hi, >> >> On 15/10/19 12:08 AM, Faiz Abbas wrote: >>> Add a write memory barrier to make sure that descriptors are actually >>> written to memory before ringing the doorbell. >>> >>> Signed-off-by: Faiz

Re: [RFC] mmc: cqhci: commit descriptors before setting the doorbell

2019-10-15 Thread Adrian Hunter
On 15/10/19 10:55 AM, Faiz Abbas wrote: > Hi, > > On 15/10/19 12:08 AM, Faiz Abbas wrote: >> Add a write memory barrier to make sure that descriptors are actually >> written to memory before ringing the doorbell. >> >> Signed-off-by: Faiz Abbas >> --- >> >> This patch fixes a very infrequent ADMA

Re: [RFC] mmc: cqhci: commit descriptors before setting the doorbell

2019-10-15 Thread Faiz Abbas
Hi, On 15/10/19 12:08 AM, Faiz Abbas wrote: > Add a write memory barrier to make sure that descriptors are actually > written to memory before ringing the doorbell. > > Signed-off-by: Faiz Abbas > --- > > This patch fixes a very infrequent ADMA error (1 out of 100 times) that > I have been seei

[RFC] mmc: cqhci: commit descriptors before setting the doorbell

2019-10-14 Thread Faiz Abbas
Add a write memory barrier to make sure that descriptors are actually written to memory before ringing the doorbell. Signed-off-by: Faiz Abbas --- This patch fixes a very infrequent ADMA error (1 out of 100 times) that I have been seeing after enabling command queuing for J721e. Also looking at