Re: [RFC] perf record: dead code perf_event__synthesize_id_index()

2018-05-03 Thread Adrian Hunter
On 02/05/18 19:57, Jiri Olsa wrote: > On Wed, May 02, 2018 at 04:38:33PM +, Stephane Eranian wrote: >> Hi, >> >> It looks like perf_event__synthesize_id_index() is dead code in the current >> tip >> tree. I don't see any invocation of the function anywhere in perf.I >> understand why >> you'd

Re: [RFC] perf record: dead code perf_event__synthesize_id_index()

2018-05-03 Thread Adrian Hunter
On 02/05/18 19:57, Jiri Olsa wrote: > On Wed, May 02, 2018 at 04:38:33PM +, Stephane Eranian wrote: >> Hi, >> >> It looks like perf_event__synthesize_id_index() is dead code in the current >> tip >> tree. I don't see any invocation of the function anywhere in perf.I >> understand why >> you'd

Re: [RFC] perf record: dead code perf_event__synthesize_id_index()

2018-05-02 Thread Jiri Olsa
On Wed, May 02, 2018 at 04:38:33PM +, Stephane Eranian wrote: > Hi, > > It looks like perf_event__synthesize_id_index() is dead code in the current > tip > tree. I don't see any invocation of the function anywhere in perf.I > understand why > you'd want to keep the rest of the code related to

Re: [RFC] perf record: dead code perf_event__synthesize_id_index()

2018-05-02 Thread Jiri Olsa
On Wed, May 02, 2018 at 04:38:33PM +, Stephane Eranian wrote: > Hi, > > It looks like perf_event__synthesize_id_index() is dead code in the current > tip > tree. I don't see any invocation of the function anywhere in perf.I > understand why > you'd want to keep the rest of the code related to

[RFC] perf record: dead code perf_event__synthesize_id_index()

2018-05-02 Thread Stephane Eranian
Hi, It looks like perf_event__synthesize_id_index() is dead code in the current tip tree. I don't see any invocation of the function anywhere in perf.I understand why you'd want to keep the rest of the code related to PERF_RECORD_ID_INDEX because some perf.data file may have this user-level

[RFC] perf record: dead code perf_event__synthesize_id_index()

2018-05-02 Thread Stephane Eranian
Hi, It looks like perf_event__synthesize_id_index() is dead code in the current tip tree. I don't see any invocation of the function anywhere in perf.I understand why you'd want to keep the rest of the code related to PERF_RECORD_ID_INDEX because some perf.data file may have this user-level