Re: [jenny...@intel.com: [RFC] power_supply: Introduce generic psy charging driver]

2014-05-07 Thread Pavel Machek
Hi! > > > +#define PSY_MAX_CV(psy) \ > > > + psy_get_ps_int_property(psy,\ > > > + POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX) > > > +#define PSY_VOLTAGE_NOW(psy) \ > > > + psy_get_ps_int_property(psy, POWER_SUPPLY_PROP_VOLTAGE_NOW) > > > +#define

Re: [jenny...@intel.com: [RFC] power_supply: Introduce generic psy charging driver]

2014-05-07 Thread Jenny Tc
> > +static struct charger_cable cable_list[] = { > > + { > > +.psy_cable_type = PSY_CHARGER_CABLE_TYPE_USB_SDP, > > +}, > > + { > > +.psy_cable_type = PSY_CHARGER_CABLE_TYPE_USB_CDP, > > +}, > > + { > > +.psy_cable_type = PSY_CHARGER_CABLE_TYPE_USB_DCP, > > +}, > > +

Re: [jenny...@intel.com: [RFC] power_supply: Introduce generic psy charging driver]

2014-05-07 Thread Jenny Tc
+static struct charger_cable cable_list[] = { + { +.psy_cable_type = PSY_CHARGER_CABLE_TYPE_USB_SDP, +}, + { +.psy_cable_type = PSY_CHARGER_CABLE_TYPE_USB_CDP, +}, + { +.psy_cable_type = PSY_CHARGER_CABLE_TYPE_USB_DCP, +}, + { +

Re: [jenny...@intel.com: [RFC] power_supply: Introduce generic psy charging driver]

2014-05-07 Thread Pavel Machek
Hi! +#define PSY_MAX_CV(psy) \ + psy_get_ps_int_property(psy,\ + POWER_SUPPLY_PROP_CONSTANT_CHARGE_VOLTAGE_MAX) +#define PSY_VOLTAGE_NOW(psy) \ + psy_get_ps_int_property(psy, POWER_SUPPLY_PROP_VOLTAGE_NOW) +#define PSY_VOLTAGE_OCV(psy) \ +

Re: [jenny...@intel.com: [RFC] power_supply: Introduce generic psy charging driver]

2014-05-05 Thread Pavel Machek
Hi! (Only part of original cc-list preserved.) > RFC: Fixed comments for patch v8, removed sorting and string comparisons Ok, its better now. > The Power Supply charging driver connects multiple subsystems > to do charging in a generic way. The subsystems involves power_supply, > thermal and

Re: [jenny...@intel.com: [RFC] power_supply: Introduce generic psy charging driver]

2014-05-05 Thread Pavel Machek
Hi! (Only part of original cc-list preserved.) RFC: Fixed comments for patch v8, removed sorting and string comparisons Ok, its better now. The Power Supply charging driver connects multiple subsystems to do charging in a generic way. The subsystems involves power_supply, thermal and

Re: [RFC] power_supply: Introduce generic psy charging driver

2014-04-28 Thread Jenny Tc
On Mon, Apr 28, 2014 at 07:56:06PM +0200, Pavel Machek wrote: > On Mon 2014-04-28 22:24:36, Jenny Tc wrote: > > Dmitry/Pavel, > > > > Request your feedback on this. Fixed the comments from Pavel and waiting > > for > > your feedback on the changes > > IIRC, my latest comments were "this is

Re: [RFC] power_supply: Introduce generic psy charging driver

2014-04-28 Thread Pavel Machek
On Mon 2014-04-28 22:24:36, Jenny Tc wrote: > Dmitry/Pavel, > > Request your feedback on this. Fixed the comments from Pavel and waiting for > your feedback on the changes IIRC, my latest comments were "this is completely misdesigned, it is using strings and table searches where it should use

Re: [RFC] power_supply: Introduce generic psy charging driver

2014-04-28 Thread Pavel Machek
On Mon 2014-04-28 22:24:36, Jenny Tc wrote: Dmitry/Pavel, Request your feedback on this. Fixed the comments from Pavel and waiting for your feedback on the changes IIRC, my latest comments were this is completely misdesigned, it is using strings and table searches where it should use

Re: [RFC] power_supply: Introduce generic psy charging driver

2014-04-28 Thread Jenny Tc
On Mon, Apr 28, 2014 at 07:56:06PM +0200, Pavel Machek wrote: On Mon 2014-04-28 22:24:36, Jenny Tc wrote: Dmitry/Pavel, Request your feedback on this. Fixed the comments from Pavel and waiting for your feedback on the changes IIRC, my latest comments were this is completely