Re: [RFC] restore user defined min_free_kbytes when disabling thp

2014-01-22 Thread Mel Gorman
On Wed, Jan 22, 2014 at 02:05:06PM +0800, Han Pingtian wrote: > On Tue, Jan 21, 2014 at 10:23:51AM +, Mel Gorman wrote: > > On Tue, Jan 21, 2014 at 05:38:59PM +0800, Han Pingtian wrote: > > > The testcase 'thp04' of LTP will enable THP, do some testing, then > > > disable it if it wasn't

Re: [RFC] restore user defined min_free_kbytes when disabling thp

2014-01-22 Thread Mel Gorman
On Wed, Jan 22, 2014 at 02:05:06PM +0800, Han Pingtian wrote: On Tue, Jan 21, 2014 at 10:23:51AM +, Mel Gorman wrote: On Tue, Jan 21, 2014 at 05:38:59PM +0800, Han Pingtian wrote: The testcase 'thp04' of LTP will enable THP, do some testing, then disable it if it wasn't enabled. But

Re: [RFC] restore user defined min_free_kbytes when disabling thp

2014-01-21 Thread Han Pingtian
On Tue, Jan 21, 2014 at 10:23:51AM +, Mel Gorman wrote: > On Tue, Jan 21, 2014 at 05:38:59PM +0800, Han Pingtian wrote: > > The testcase 'thp04' of LTP will enable THP, do some testing, then > > disable it if it wasn't enabled. But this will leave a different value > > of min_free_kbytes if it

Re: [RFC] restore user defined min_free_kbytes when disabling thp

2014-01-21 Thread Mel Gorman
On Tue, Jan 21, 2014 at 05:38:59PM +0800, Han Pingtian wrote: > The testcase 'thp04' of LTP will enable THP, do some testing, then > disable it if it wasn't enabled. But this will leave a different value > of min_free_kbytes if it has been set by admin. So I think it's better > to restore the user

[RFC] restore user defined min_free_kbytes when disabling thp

2014-01-21 Thread Han Pingtian
The testcase 'thp04' of LTP will enable THP, do some testing, then disable it if it wasn't enabled. But this will leave a different value of min_free_kbytes if it has been set by admin. So I think it's better to restore the user defined value after disabling THP. --- thp increases the value of

[RFC] restore user defined min_free_kbytes when disabling thp

2014-01-21 Thread Han Pingtian
The testcase 'thp04' of LTP will enable THP, do some testing, then disable it if it wasn't enabled. But this will leave a different value of min_free_kbytes if it has been set by admin. So I think it's better to restore the user defined value after disabling THP. --- thp increases the value of

Re: [RFC] restore user defined min_free_kbytes when disabling thp

2014-01-21 Thread Mel Gorman
On Tue, Jan 21, 2014 at 05:38:59PM +0800, Han Pingtian wrote: The testcase 'thp04' of LTP will enable THP, do some testing, then disable it if it wasn't enabled. But this will leave a different value of min_free_kbytes if it has been set by admin. So I think it's better to restore the user

Re: [RFC] restore user defined min_free_kbytes when disabling thp

2014-01-21 Thread Han Pingtian
On Tue, Jan 21, 2014 at 10:23:51AM +, Mel Gorman wrote: On Tue, Jan 21, 2014 at 05:38:59PM +0800, Han Pingtian wrote: The testcase 'thp04' of LTP will enable THP, do some testing, then disable it if it wasn't enabled. But this will leave a different value of min_free_kbytes if it has