Re: [RFC] rmap: fix "race" between do_wp_page and shrink_active_list

2015-05-17 Thread yalin
On Mon, May 11, 2015 at 04:59:27PM +0800, yalin wang wrote: i am confused about your analysis , for the race stack: CPU0 CPU1 do_wp_pageshrink_active_list lock_page

Re: [RFC] rmap: fix race between do_wp_page and shrink_active_list

2015-05-17 Thread yalin
On Mon, May 11, 2015 at 04:59:27PM +0800, yalin wang wrote: i am confused about your analysis , for the race stack: CPU0 CPU1 do_wp_pageshrink_active_list lock_page

Re: [RFC] rmap: fix "race" between do_wp_page and shrink_active_list

2015-05-12 Thread Vladimir Davydov
On Mon, May 11, 2015 at 12:36:52PM +0300, Kirill A. Shutemov wrote: > On Mon, May 11, 2015 at 10:51:17AM +0300, Vladimir Davydov wrote: > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > > index 5e7c4f50a644..a529e0a35fe9 100644 > > --- a/include/linux/page-flags.h > > +++

Re: [RFC] rmap: fix "race" between do_wp_page and shrink_active_list

2015-05-12 Thread Vladimir Davydov
On Mon, May 11, 2015 at 07:24:02AM -0700, Paul E. McKenney wrote: > On Mon, May 11, 2015 at 10:51:17AM +0300, Vladimir Davydov wrote: > > Hi, > > > > I've been arguing with Minchan for a while about whether store-tearing > > is possible while setting page->mapping in __page_set_anon_rmap and > >

Re: [RFC] rmap: fix "race" between do_wp_page and shrink_active_list

2015-05-12 Thread Vladimir Davydov
On Mon, May 11, 2015 at 04:59:27PM +0800, yalin wang wrote: > i am confused about your analysis , > for the race stack: > > CPU0 CPU1 > > > >do_wp_pageshrink_active_list > > lock_page

Re: [RFC] rmap: fix race between do_wp_page and shrink_active_list

2015-05-12 Thread Vladimir Davydov
On Mon, May 11, 2015 at 04:59:27PM +0800, yalin wang wrote: i am confused about your analysis , for the race stack: CPU0 CPU1 do_wp_pageshrink_active_list lock_page

Re: [RFC] rmap: fix race between do_wp_page and shrink_active_list

2015-05-12 Thread Vladimir Davydov
On Mon, May 11, 2015 at 07:24:02AM -0700, Paul E. McKenney wrote: On Mon, May 11, 2015 at 10:51:17AM +0300, Vladimir Davydov wrote: Hi, I've been arguing with Minchan for a while about whether store-tearing is possible while setting page-mapping in __page_set_anon_rmap and friends, see

Re: [RFC] rmap: fix race between do_wp_page and shrink_active_list

2015-05-12 Thread Vladimir Davydov
On Mon, May 11, 2015 at 12:36:52PM +0300, Kirill A. Shutemov wrote: On Mon, May 11, 2015 at 10:51:17AM +0300, Vladimir Davydov wrote: diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h index 5e7c4f50a644..a529e0a35fe9 100644 --- a/include/linux/page-flags.h +++

Re: [RFC] rmap: fix "race" between do_wp_page and shrink_active_list

2015-05-11 Thread Paul E. McKenney
On Mon, May 11, 2015 at 10:51:17AM +0300, Vladimir Davydov wrote: > Hi, > > I've been arguing with Minchan for a while about whether store-tearing > is possible while setting page->mapping in __page_set_anon_rmap and > friends, see > >

Re: [RFC] rmap: fix "race" between do_wp_page and shrink_active_list

2015-05-11 Thread Kirill A. Shutemov
On Mon, May 11, 2015 at 10:51:17AM +0300, Vladimir Davydov wrote: > Hi, > > I've been arguing with Minchan for a while about whether store-tearing > is possible while setting page->mapping in __page_set_anon_rmap and > friends, see > >

Re: [RFC] rmap: fix "race" between do_wp_page and shrink_active_list

2015-05-11 Thread yalin wang
2015-05-11 15:51 GMT+08:00 Vladimir Davydov : > Hi, > > I've been arguing with Minchan for a while about whether store-tearing > is possible while setting page->mapping in __page_set_anon_rmap and > friends, see > > http://thread.gmane.org/gmane.linux.kernel.mm/131949/focus=132132 > > This patch

[RFC] rmap: fix "race" between do_wp_page and shrink_active_list

2015-05-11 Thread Vladimir Davydov
Hi, I've been arguing with Minchan for a while about whether store-tearing is possible while setting page->mapping in __page_set_anon_rmap and friends, see http://thread.gmane.org/gmane.linux.kernel.mm/131949/focus=132132 This patch is intended to draw attention to this discussion. It fixes a

[RFC] rmap: fix race between do_wp_page and shrink_active_list

2015-05-11 Thread Vladimir Davydov
Hi, I've been arguing with Minchan for a while about whether store-tearing is possible while setting page-mapping in __page_set_anon_rmap and friends, see http://thread.gmane.org/gmane.linux.kernel.mm/131949/focus=132132 This patch is intended to draw attention to this discussion. It fixes a

Re: [RFC] rmap: fix race between do_wp_page and shrink_active_list

2015-05-11 Thread Kirill A. Shutemov
On Mon, May 11, 2015 at 10:51:17AM +0300, Vladimir Davydov wrote: Hi, I've been arguing with Minchan for a while about whether store-tearing is possible while setting page-mapping in __page_set_anon_rmap and friends, see http://thread.gmane.org/gmane.linux.kernel.mm/131949/focus=132132

Re: [RFC] rmap: fix race between do_wp_page and shrink_active_list

2015-05-11 Thread yalin wang
2015-05-11 15:51 GMT+08:00 Vladimir Davydov vdavy...@parallels.com: Hi, I've been arguing with Minchan for a while about whether store-tearing is possible while setting page-mapping in __page_set_anon_rmap and friends, see http://thread.gmane.org/gmane.linux.kernel.mm/131949/focus=132132

Re: [RFC] rmap: fix race between do_wp_page and shrink_active_list

2015-05-11 Thread Paul E. McKenney
On Mon, May 11, 2015 at 10:51:17AM +0300, Vladimir Davydov wrote: Hi, I've been arguing with Minchan for a while about whether store-tearing is possible while setting page-mapping in __page_set_anon_rmap and friends, see http://thread.gmane.org/gmane.linux.kernel.mm/131949/focus=132132