Re: [RFC] tracing: Add support for critical section event tracing

Hi Steven, On Jun 30, 2017 5:32 AM, "Steven Rostedt" wrote: [..] >> Did you have any comments about this patch? It was sent a while ago >> and if you can provide me your initial thoughts on it, I would >> appreciate it. (Sorry to ping you about it during the busy merge >>

Re: [RFC] tracing: Add support for critical section event tracing

Hi Steven, On Jun 30, 2017 5:32 AM, "Steven Rostedt" wrote: [..] >> Did you have any comments about this patch? It was sent a while ago >> and if you can provide me your initial thoughts on it, I would >> appreciate it. (Sorry to ping you about it during the busy merge >> window time, but I was

Re: [RFC] tracing: Add support for critical section event tracing

On Fri, Jun 30, 2017 at 2:07 PM, Steven Rostedt wrote: > On Fri, 30 Jun 2017 14:03:14 -0700 > Joel Fernandes wrote: > >> Hi Steven, >> >> Thanks a lot for the comments, I agree with all of them and had a >> comment about one of them: >> >> On Fri, Jun 30,

Re: [RFC] tracing: Add support for critical section event tracing

On Fri, Jun 30, 2017 at 2:07 PM, Steven Rostedt wrote: > On Fri, 30 Jun 2017 14:03:14 -0700 > Joel Fernandes wrote: > >> Hi Steven, >> >> Thanks a lot for the comments, I agree with all of them and had a >> comment about one of them: >> >> On Fri, Jun 30, 2017 at 5:51 AM, Steven Rostedt wrote:

Re: [RFC] tracing: Add support for critical section event tracing

On Fri, 30 Jun 2017 14:03:14 -0700 Joel Fernandes wrote: > Hi Steven, > > Thanks a lot for the comments, I agree with all of them and had a > comment about one of them: > > On Fri, Jun 30, 2017 at 5:51 AM, Steven Rostedt wrote: > [..] > > Are you not

Re: [RFC] tracing: Add support for critical section event tracing

On Fri, 30 Jun 2017 14:03:14 -0700 Joel Fernandes wrote: > Hi Steven, > > Thanks a lot for the comments, I agree with all of them and had a > comment about one of them: > > On Fri, Jun 30, 2017 at 5:51 AM, Steven Rostedt wrote: > [..] > > Are you not worried about recursion here? There's no

Re: [RFC] tracing: Add support for critical section event tracing

Hi Steven, Thanks a lot for the comments, I agree with all of them and had a comment about one of them: On Fri, Jun 30, 2017 at 5:51 AM, Steven Rostedt wrote: [..] > Are you not worried about recursion here? There's no protection. > Wouldn't it be better to have: > >

Re: [RFC] tracing: Add support for critical section event tracing

Hi Steven, Thanks a lot for the comments, I agree with all of them and had a comment about one of them: On Fri, Jun 30, 2017 at 5:51 AM, Steven Rostedt wrote: [..] > Are you not worried about recursion here? There's no protection. > Wouldn't it be better to have: > > if

Re: [RFC] tracing: Add support for critical section event tracing

On Tue, 11 Apr 2017 22:38:51 -0700 Joel Fernandes wrote: > diff --git a/include/trace/events/critical.h b/include/trace/events/critical.h > new file mode 100644 > index ..bfd58dd4f48f > --- /dev/null > +++ b/include/trace/events/critical.h > @@ -0,0 +1,55 @@ >

Re: [RFC] tracing: Add support for critical section event tracing

On Tue, 11 Apr 2017 22:38:51 -0700 Joel Fernandes wrote: > diff --git a/include/trace/events/critical.h b/include/trace/events/critical.h > new file mode 100644 > index ..bfd58dd4f48f > --- /dev/null > +++ b/include/trace/events/critical.h > @@ -0,0 +1,55 @@ > +#undef TRACE_SYSTEM >

Re: [RFC] tracing: Add support for critical section event tracing

On Thu, 29 Jun 2017 22:17:22 -0700 Joel Fernandes wrote: > Hi Steven, > > Did you have any comments about this patch? It was sent a while ago > and if you can provide me your initial thoughts on it, I would > appreciate it. (Sorry to ping you about it during the busy merge >

Re: [RFC] tracing: Add support for critical section event tracing

On Thu, 29 Jun 2017 22:17:22 -0700 Joel Fernandes wrote: > Hi Steven, > > Did you have any comments about this patch? It was sent a while ago > and if you can provide me your initial thoughts on it, I would > appreciate it. (Sorry to ping you about it during the busy merge > window time, but I

Re: [RFC] tracing: Add support for critical section event tracing

Hi Steven, Did you have any comments about this patch? It was sent a while ago and if you can provide me your initial thoughts on it, I would appreciate it. (Sorry to ping you about it during the busy merge window time, but I was thinking if I can get any initial early comments from you then I

Re: [RFC] tracing: Add support for critical section event tracing

Hi Steven, Did you have any comments about this patch? It was sent a while ago and if you can provide me your initial thoughts on it, I would appreciate it. (Sorry to ping you about it during the busy merge window time, but I was thinking if I can get any initial early comments from you then I

[RFC] tracing: Add support for critical section event tracing

Critical section trace events can be used for tracing the start and end of a critical section which can be used by a trace viewer like systrace to graphically view the start and end of a critical section and correlate them with latencies and scheduling issues. Reason for starting critical

[RFC] tracing: Add support for critical section event tracing

Critical section trace events can be used for tracing the start and end of a critical section which can be used by a trace viewer like systrace to graphically view the start and end of a critical section and correlate them with latencies and scheduling issues. Reason for starting critical