Re: [RFC] tty: Always allow tcflow(TCOON) to unwedge terminal

2014-09-11 Thread Theodore Ts'o
On Thu, Sep 11, 2014 at 11:40:20AM -0400, Peter Hurley wrote: > > This is the basic interpretation I assumed, and most of what the tty core > already did. Yes, I know. :-) So it's been a long time since I've had anything to do with the tty code, but FWIW, I'd agree with merging Peter's patch.

Re: [RFC] tty: Always allow tcflow(TCOON) to unwedge terminal

2014-09-11 Thread Peter Hurley
On 09/11/2014 09:56 AM, Theodore Ts'o wrote: > On Wed, Sep 10, 2014 at 08:45:01PM -0400, Peter Hurley wrote: >>> I'm all for working around broken hardware in the kernel, but this seems >>> like a very old issue, if it's even one at all, that we would be >>> changing for no one who has reported it

Re: [RFC] tty: Always allow tcflow(TCOON) to unwedge terminal

2014-09-11 Thread Theodore Ts'o
On Wed, Sep 10, 2014 at 08:45:01PM -0400, Peter Hurley wrote: > > I'm all for working around broken hardware in the kernel, but this seems > > like a very old issue, if it's even one at all, that we would be > > changing for no one who has reported it (that I know of...) > > How to unwedge a termi

Re: [RFC] tty: Always allow tcflow(TCOON) to unwedge terminal

2014-09-11 Thread Peter Hurley
On 09/11/2014 06:19 AM, One Thousand Gnomes wrote: >> It's not common knowledge (and its certainly counterintuitive) that >> turning off output when output is already turned off (ie., tcflow(TCOOFF)) >> is the required trickery to unwedge a terminal. >> >> Unwedging directly seems the straightforwa

Re: [RFC] tty: Always allow tcflow(TCOON) to unwedge terminal

2014-09-11 Thread One Thousand Gnomes
> It's not common knowledge (and its certainly counterintuitive) that > turning off output when output is already turned off (ie., tcflow(TCOOFF)) > is the required trickery to unwedge a terminal. > > Unwedging directly seems the straightforward approach. Putting the off/on in the man page might

Re: [RFC] tty: Always allow tcflow(TCOON) to unwedge terminal

2014-09-10 Thread Peter Hurley
behavior (for the better) but I'm not sure >>>> that it's consequence-free. Also, it might not be enough to unwedge the >>>> terminal if the driver got its own flow control state mangled. >>>> >>>> Thoughts? >>>> >>>&g

Re: [RFC] tty: Always allow tcflow(TCOON) to unwedge terminal

2014-09-10 Thread Greg Kroah-Hartman
that it's consequence-free. Also, it might not be enough to unwedge the > >> terminal if the driver got its own flow control state mangled. > >> > >> Thoughts? > >> > >> --- >% --- > >> Subject: [RFC] tty: Always allow tcflow(TCOON) to unwe

Re: [RFC] tty: Always allow tcflow(TCOON) to unwedge terminal

2014-09-10 Thread Peter Hurley
terminal if the driver got its own flow control state mangled. >> >> Thoughts? >> >> --- >% --- >> Subject: [RFC] tty: Always allow tcflow(TCOON) to unwedge terminal >> >> If terminal flow has been stopped, the terminal can be unwedged >> by: &

Re: [RFC] tty: Always allow tcflow(TCOON) to unwedge terminal

2014-09-10 Thread Greg Kroah-Hartman
gled. > > Thoughts? > > --- >% --- > Subject: [RFC] tty: Always allow tcflow(TCOON) to unwedge terminal > > If terminal flow has been stopped, the terminal can be unwedged > by: > tcflow(fd, TCOOFF); > tcflow(fd, TCOON); > This works because tcflow(TCO

[RFC] tty: Always allow tcflow(TCOON) to unwedge terminal

2014-09-10 Thread Peter Hurley
This patch changes user-space behavior (for the better) but I'm not sure that it's consequence-free. Also, it might not be enough to unwedge the terminal if the driver got its own flow control state mangled. Thoughts? --- >% --- Subject: [RFC] tty: Always allow tcflow(TCOON) to unw