Re: [RFC] x86/vdso: Align vdso after searching for free area

2018-06-12 Thread Dmitry Safonov
On Tue, 2018-06-12 at 14:39 -0700, H. Peter Anvin wrote: > On 06/12/18 14:24, Dmitry Safonov wrote: > > > > > > Move align_vdso_addr() after get_unmapped_area() to make sure > > > that > > > errata for AMD 15h is always applied. > > > > Alternative dirty-hacky idea: > > specify some (struct file*

Re: [RFC] x86/vdso: Align vdso after searching for free area

2018-06-12 Thread H. Peter Anvin
On 06/12/18 14:24, Dmitry Safonov wrote: >> >> Move align_vdso_addr() after get_unmapped_area() to make sure that >> errata for AMD 15h is always applied. > > Alternative dirty-hacky idea: > specify some (struct file*) to get_unmapped_area() for vdso vma, then > mapping would be automatically alig

Re: [RFC] x86/vdso: Align vdso after searching for free area

2018-06-12 Thread Dmitry Safonov
On Tue, 2018-06-12 at 21:49 +0100, Dmitry Safonov wrote: > There is errata for AMD family 15h CPUs [1] and since > commit dfb09f9b7ab03 ("x86, amd: Avoid cache aliasing penalties on > AMD > family 15h") bits [14:12] are being cleared for shared libraries. > Also per-boot ASLR applies over upper bit

[RFC] x86/vdso: Align vdso after searching for free area

2018-06-12 Thread Dmitry Safonov
There is errata for AMD family 15h CPUs [1] and since commit dfb09f9b7ab03 ("x86, amd: Avoid cache aliasing penalties on AMD family 15h") bits [14:12] are being cleared for shared libraries. Also per-boot ASLR applies over upper bits by OR directly over the address. As we need special alignment an