Re: [RFC 0/2] perf scripting cleanups

2015-04-02 Thread Adrian Hunter
On 2/04/2015 5:15 p.m., Arnaldo Carvalho de Melo wrote: Em Thu, Apr 02, 2015 at 12:16:40PM +0300, Adrian Hunter escreveu: On 01/04/15 19:36, Arnaldo Carvalho de Melo wrote: Hi David, Jiri, Please take a look if it is ok for you guys Adrian, there is another thing:

Re: [RFC 0/2] perf scripting cleanups

2015-04-02 Thread Arnaldo Carvalho de Melo
Em Thu, Apr 02, 2015 at 12:16:40PM +0300, Adrian Hunter escreveu: > On 01/04/15 19:36, Arnaldo Carvalho de Melo wrote: > > Hi David, Jiri, > > > > Please take a look if it is ok for you guys > > > > Adrian, there is another thing: > > > > db_export__sample(>dbe, event, sample, evsel,

Re: [RFC 0/2] perf scripting cleanups

2015-04-02 Thread Adrian Hunter
On 01/04/15 19:36, Arnaldo Carvalho de Melo wrote: > Hi David, Jiri, > > Please take a look if it is ok for you guys > > Adrian, there is another thing: > > db_export__sample(>dbe, event, sample, evsel, al->thread, al); > > In tools/perf/util/scripting-engines/trace-event-python.c has

Re: [RFC 0/2] perf scripting cleanups

2015-04-02 Thread Jiri Olsa
On Thu, Apr 02, 2015 at 05:16:09PM +0900, Namhyung Kim wrote: > On Wed, Apr 01, 2015 at 01:36:48PM -0300, Arnaldo Carvalho de Melo wrote: > > Hi David, Jiri, > > > > Please take a look if it is ok for you guys > > > > Adrian, there is another thing: > > > > db_export__sample(>dbe, event,

Re: [RFC 0/2] perf scripting cleanups

2015-04-02 Thread Namhyung Kim
On Wed, Apr 01, 2015 at 01:36:48PM -0300, Arnaldo Carvalho de Melo wrote: > Hi David, Jiri, > > Please take a look if it is ok for you guys > > Adrian, there is another thing: > > db_export__sample(>dbe, event, sample, evsel, al->thread, al); > > In

Re: [RFC 0/2] perf scripting cleanups

2015-04-02 Thread Jiri Olsa
On Thu, Apr 02, 2015 at 05:16:09PM +0900, Namhyung Kim wrote: On Wed, Apr 01, 2015 at 01:36:48PM -0300, Arnaldo Carvalho de Melo wrote: Hi David, Jiri, Please take a look if it is ok for you guys Adrian, there is another thing: db_export__sample(tables-dbe, event, sample,

Re: [RFC 0/2] perf scripting cleanups

2015-04-02 Thread Namhyung Kim
On Wed, Apr 01, 2015 at 01:36:48PM -0300, Arnaldo Carvalho de Melo wrote: Hi David, Jiri, Please take a look if it is ok for you guys Adrian, there is another thing: db_export__sample(tables-dbe, event, sample, evsel, al-thread, al); In

Re: [RFC 0/2] perf scripting cleanups

2015-04-02 Thread Adrian Hunter
On 01/04/15 19:36, Arnaldo Carvalho de Melo wrote: Hi David, Jiri, Please take a look if it is ok for you guys Adrian, there is another thing: db_export__sample(tables-dbe, event, sample, evsel, al-thread, al); In tools/perf/util/scripting-engines/trace-event-python.c has this

Re: [RFC 0/2] perf scripting cleanups

2015-04-02 Thread Adrian Hunter
On 2/04/2015 5:15 p.m., Arnaldo Carvalho de Melo wrote: Em Thu, Apr 02, 2015 at 12:16:40PM +0300, Adrian Hunter escreveu: On 01/04/15 19:36, Arnaldo Carvalho de Melo wrote: Hi David, Jiri, Please take a look if it is ok for you guys Adrian, there is another thing:

Re: [RFC 0/2] perf scripting cleanups

2015-04-02 Thread Arnaldo Carvalho de Melo
Em Thu, Apr 02, 2015 at 12:16:40PM +0300, Adrian Hunter escreveu: On 01/04/15 19:36, Arnaldo Carvalho de Melo wrote: Hi David, Jiri, Please take a look if it is ok for you guys Adrian, there is another thing: db_export__sample(tables-dbe, event, sample, evsel, al-thread,

[RFC 0/2] perf scripting cleanups

2015-04-01 Thread Arnaldo Carvalho de Melo
Hi David, Jiri, Please take a look if it is ok for you guys Adrian, there is another thing: db_export__sample(>dbe, event, sample, evsel, al->thread, al); In tools/perf/util/scripting-engines/trace-event-python.c has this redundancy as well, see the (al->thread, al), I'll probably

[RFC 0/2] perf scripting cleanups

2015-04-01 Thread Arnaldo Carvalho de Melo
Hi David, Jiri, Please take a look if it is ok for you guys Adrian, there is another thing: db_export__sample(tables-dbe, event, sample, evsel, al-thread, al); In tools/perf/util/scripting-engines/trace-event-python.c has this redundancy as well, see the (al-thread, al), I'll