Re: [RFC 00/47] mtd: nand: Add new driver supporting ST's BCH h/w

2014-04-30 Thread Lee Jones
> > > The BBT requirements are somewhere more complex. To provide you with > > > the complete picture, a little knowledge of driver history is > > > required. When it was initially created the MTD core only supported > > > OOB BBTs, but the ST BCH Controller doesn't support OOB access, so > > > Ang

Re: [RFC 00/47] mtd: nand: Add new driver supporting ST's BCH h/w

2014-04-10 Thread Brian Norris
On Tue, Apr 01, 2014 at 12:29:26PM +0100, Lee Jones wrote: > > The BBT requirements are somewhere more complex. To provide you with > > the complete picture, a little knowledge of driver history is > > required. When it was initially created the MTD core only supported > > OOB BBTs, but the ST BCH

Re: [RFC 00/47] mtd: nand: Add new driver supporting ST's BCH h/w

2014-04-01 Thread Lee Jones
> > > The call to nand_scan_tail() would remove the need to export those NAND > > > core functions, and remove the need to scan and print the bad blocks. > > > I don't know if you have a real reason for not doing it this way, or > > > maybe it's the way this driver was originally written. > > > >

Re: [RFC 00/47] mtd: nand: Add new driver supporting ST's BCH h/w

2014-03-27 Thread Lee Jones
> > After taking a quick glance at the whole driver I noticed you have something > > strange going on. AFAIK, the typical NAND driver probe() should be one of > > these two: > > > > * Call nand_scan() which calls nand_scan_ident() + nand_scan_tail(). > > > > * Call nand_scan_ident() to identify t

Re: [RFC 00/47] mtd: nand: Add new driver supporting ST's BCH h/w

2014-03-26 Thread Brian Norris
On Tue, Mar 25, 2014 at 07:00:45PM -0300, Ezequiel Garcia wrote: > After taking a quick glance at the whole driver I noticed you have something > strange going on. AFAIK, the typical NAND driver probe() should be one of > these two: > > * Call nand_scan() which calls nand_scan_ident() + nand_scan_

Re: [RFC 00/47] mtd: nand: Add new driver supporting ST's BCH h/w

2014-03-25 Thread Ezequiel Garcia
On Mar 25, Lee Jones wrote: > On Tue, 25 Mar 2014, Ezequiel Garcia wrote: > > > Hi Lee, > > > > On Mar 25, Lee Jones wrote: > > > > > > This patch-set was written against kernel version v3.4, but applies > > > cleanly to v3.13-rc7 which it is currently based. I understand that > > > the core has

Re: [RFC 00/47] mtd: nand: Add new driver supporting ST's BCH h/w

2014-03-25 Thread Lee Jones
On Tue, 25 Mar 2014, Ezequiel Garcia wrote: > Hi Lee, > > On Mar 25, Lee Jones wrote: > > > > This patch-set was written against kernel version v3.4, but applies > > cleanly to v3.13-rc7 which it is currently based. I understand that > > the core has changed significantly since and that some of

Re: [RFC 00/47] mtd: nand: Add new driver supporting ST's BCH h/w

2014-03-25 Thread Ezequiel Garcia
Hi Lee, On Mar 25, Lee Jones wrote: > > This patch-set was written against kernel version v3.4, but applies > cleanly to v3.13-rc7 which it is currently based. I understand that > the core has changed significantly since and that some of the > infrastructure this driver provides is now available

[RFC 00/47] mtd: nand: Add new driver supporting ST's BCH h/w

2014-03-25 Thread Lee Jones
All, This patch-set was written against kernel version v3.4, but applies cleanly to v3.13-rc7 which it is currently based. I understand that the core has changed significantly since and that some of the infrastructure this driver provides is now available either through the framework or similar me