Re: [RFC 1/1 linux-next] gfs2: convert simple_str to kstr

2015-04-30 Thread Alexey Dobriyan
[cc linux-kernel] On Thu, Apr 30, 2015 at 1:53 PM, Alexey Dobriyan wrote: >> By default I used destination type as a reference. Maybe it's wrong and >> we really want to read long, unsigned long from source ? > > long and unsigned long -- no. Always look at type of data. > There are many places

Re: [RFC 1/1 linux-next] gfs2: convert simple_str to kstr

2015-04-30 Thread Steven Whitehouse
Hi, On 29/04/15 19:54, Fabian Frederick wrote: -Remove obsolete simple_str functions. -Return error code when kstr failed. -This patch also calls functions corresponding to destination type. Basically it's an RFC because of the type mismatch all over the place. ie code was doing simple_strtol

Re: [RFC 1/1 linux-next] gfs2: convert simple_str to kstr

2015-04-30 Thread Steven Whitehouse
Hi, On 29/04/15 19:54, Fabian Frederick wrote: -Remove obsolete simple_str functions. -Return error code when kstr failed. -This patch also calls functions corresponding to destination type. Basically it's an RFC because of the type mismatch all over the place. ie code was doing simple_strtol

Re: [RFC 1/1 linux-next] gfs2: convert simple_str to kstr

2015-04-30 Thread Alexey Dobriyan
[cc linux-kernel] On Thu, Apr 30, 2015 at 1:53 PM, Alexey Dobriyan adobri...@gmail.com wrote: By default I used destination type as a reference. Maybe it's wrong and we really want to read long, unsigned long from source ? long and unsigned long -- no. Always look at type of data. There are

[RFC 1/1 linux-next] gfs2: convert simple_str to kstr

2015-04-29 Thread Fabian Frederick
-Remove obsolete simple_str functions. -Return error code when kstr failed. -This patch also calls functions corresponding to destination type. Basically it's an RFC because of the type mismatch all over the place. ie code was doing simple_strtol to integer... Newer kstr functions detect such

[RFC 1/1 linux-next] gfs2: convert simple_str to kstr

2015-04-29 Thread Fabian Frederick
-Remove obsolete simple_str functions. -Return error code when kstr failed. -This patch also calls functions corresponding to destination type. Basically it's an RFC because of the type mismatch all over the place. ie code was doing simple_strtol to integer... Newer kstr functions detect such