Re: [RFC 1/2] ASoC: dmaengine-pcm: Add support for querying DMA capabilities

2013-07-16 Thread Mark Brown
On Tue, Jul 16, 2013 at 11:07:07AM +0200, Lars-Peter Clausen wrote: > I would assume that most of them don't express hardware limitations but > rather are sensible lower limits which allow operation without > over-/underruns. But that's something that doesn't necessarily depend on the Yes,

Re: [RFC 1/2] ASoC: dmaengine-pcm: Add support for querying DMA capabilities

2013-07-16 Thread Lars-Peter Clausen
On 07/15/2013 09:51 PM, Mark Brown wrote: > On Mon, Jul 15, 2013 at 08:20:28PM +0200, Lars-Peter Clausen wrote: >> On 07/15/2013 07:57 PM, Mark Brown wrote: >>> On Mon, Jul 15, 2013 at 10:27:21PM +0530, Vinod Koul wrote: > >>> Right, we probably want to set an artificial floor here but it still

Re: [RFC 1/2] ASoC: dmaengine-pcm: Add support for querying DMA capabilities

2013-07-16 Thread Lars-Peter Clausen
On 07/15/2013 09:51 PM, Mark Brown wrote: On Mon, Jul 15, 2013 at 08:20:28PM +0200, Lars-Peter Clausen wrote: On 07/15/2013 07:57 PM, Mark Brown wrote: On Mon, Jul 15, 2013 at 10:27:21PM +0530, Vinod Koul wrote: Right, we probably want to set an artificial floor here but it still seems like

Re: [RFC 1/2] ASoC: dmaengine-pcm: Add support for querying DMA capabilities

2013-07-16 Thread Mark Brown
On Tue, Jul 16, 2013 at 11:07:07AM +0200, Lars-Peter Clausen wrote: I would assume that most of them don't express hardware limitations but rather are sensible lower limits which allow operation without over-/underruns. But that's something that doesn't necessarily depend on the Yes, indeed.

Re: [RFC 1/2] ASoC: dmaengine-pcm: Add support for querying DMA capabilities

2013-07-15 Thread Mark Brown
On Mon, Jul 15, 2013 at 08:20:28PM +0200, Lars-Peter Clausen wrote: > On 07/15/2013 07:57 PM, Mark Brown wrote: > >On Mon, Jul 15, 2013 at 10:27:21PM +0530, Vinod Koul wrote: > >Right, we probably want to set an artificial floor here but it still > >seems like we should be checking that the

Re: [RFC 1/2] ASoC: dmaengine-pcm: Add support for querying DMA capabilities

2013-07-15 Thread Lars-Peter Clausen
On 07/15/2013 07:57 PM, Mark Brown wrote: On Mon, Jul 15, 2013 at 10:27:21PM +0530, Vinod Koul wrote: On Mon, Jul 15, 2013 at 06:26:43PM +0100, Mark Brown wrote: On Mon, Jul 15, 2013 at 06:42:10PM +0200, Lars-Peter Clausen wrote: + hw.period_bytes_min = 16; + hw.period_bytes_max

Re: [RFC 1/2] ASoC: dmaengine-pcm: Add support for querying DMA capabilities

2013-07-15 Thread Mark Brown
On Mon, Jul 15, 2013 at 10:27:21PM +0530, Vinod Koul wrote: > On Mon, Jul 15, 2013 at 06:26:43PM +0100, Mark Brown wrote: > > On Mon, Jul 15, 2013 at 06:42:10PM +0200, Lars-Peter Clausen wrote: > > > + hw.period_bytes_min = 16; > > > + hw.period_bytes_max = dma_caps.max_sg_len; > > We can't read

Re: [RFC 1/2] ASoC: dmaengine-pcm: Add support for querying DMA capabilities

2013-07-15 Thread Vinod Koul
On Mon, Jul 15, 2013 at 06:26:43PM +0100, Mark Brown wrote: > On Mon, Jul 15, 2013 at 06:42:10PM +0200, Lars-Peter Clausen wrote: > > > + hw.period_bytes_min = 16; > > + hw.period_bytes_max = dma_caps.max_sg_len; > > We can't read the minimum period size from dmaengine? Seems like >

Re: [RFC 1/2] ASoC: dmaengine-pcm: Add support for querying DMA capabilities

2013-07-15 Thread Mark Brown
On Mon, Jul 15, 2013 at 06:42:10PM +0200, Lars-Peter Clausen wrote: > + hw.period_bytes_min = 16; > + hw.period_bytes_max = dma_caps.max_sg_len; We can't read the minimum period size from dmaengine? Seems like something might have a restriction other than 16 bytes here. signature.asc

[RFC 1/2] ASoC: dmaengine-pcm: Add support for querying DMA capabilities

2013-07-15 Thread Lars-Peter Clausen
Currently each platform making use the the generic dmaengine PCM driver still needs to provide a custom snd_pcm_hardware struct which specifies the capabilities of the DMA controller, e.g. the maximum period size that can be supported. This patch adds code which uses the newly introduced

[RFC 1/2] ASoC: dmaengine-pcm: Add support for querying DMA capabilities

2013-07-15 Thread Lars-Peter Clausen
Currently each platform making use the the generic dmaengine PCM driver still needs to provide a custom snd_pcm_hardware struct which specifies the capabilities of the DMA controller, e.g. the maximum period size that can be supported. This patch adds code which uses the newly introduced

Re: [RFC 1/2] ASoC: dmaengine-pcm: Add support for querying DMA capabilities

2013-07-15 Thread Mark Brown
On Mon, Jul 15, 2013 at 06:42:10PM +0200, Lars-Peter Clausen wrote: + hw.period_bytes_min = 16; + hw.period_bytes_max = dma_caps.max_sg_len; We can't read the minimum period size from dmaengine? Seems like something might have a restriction other than 16 bytes here. signature.asc

Re: [RFC 1/2] ASoC: dmaengine-pcm: Add support for querying DMA capabilities

2013-07-15 Thread Vinod Koul
On Mon, Jul 15, 2013 at 06:26:43PM +0100, Mark Brown wrote: On Mon, Jul 15, 2013 at 06:42:10PM +0200, Lars-Peter Clausen wrote: + hw.period_bytes_min = 16; + hw.period_bytes_max = dma_caps.max_sg_len; We can't read the minimum period size from dmaengine? Seems like something might

Re: [RFC 1/2] ASoC: dmaengine-pcm: Add support for querying DMA capabilities

2013-07-15 Thread Mark Brown
On Mon, Jul 15, 2013 at 10:27:21PM +0530, Vinod Koul wrote: On Mon, Jul 15, 2013 at 06:26:43PM +0100, Mark Brown wrote: On Mon, Jul 15, 2013 at 06:42:10PM +0200, Lars-Peter Clausen wrote: + hw.period_bytes_min = 16; + hw.period_bytes_max = dma_caps.max_sg_len; We can't read the

Re: [RFC 1/2] ASoC: dmaengine-pcm: Add support for querying DMA capabilities

2013-07-15 Thread Lars-Peter Clausen
On 07/15/2013 07:57 PM, Mark Brown wrote: On Mon, Jul 15, 2013 at 10:27:21PM +0530, Vinod Koul wrote: On Mon, Jul 15, 2013 at 06:26:43PM +0100, Mark Brown wrote: On Mon, Jul 15, 2013 at 06:42:10PM +0200, Lars-Peter Clausen wrote: + hw.period_bytes_min = 16; + hw.period_bytes_max

Re: [RFC 1/2] ASoC: dmaengine-pcm: Add support for querying DMA capabilities

2013-07-15 Thread Mark Brown
On Mon, Jul 15, 2013 at 08:20:28PM +0200, Lars-Peter Clausen wrote: On 07/15/2013 07:57 PM, Mark Brown wrote: On Mon, Jul 15, 2013 at 10:27:21PM +0530, Vinod Koul wrote: Right, we probably want to set an artificial floor here but it still seems like we should be checking that the device