Re: [RFC 1/3] atmel: drm: added drm driver for the atmel hlcd controller

2014-04-30 Thread Jean-Jacques Hiblot
Hi Boris, On 04/28/2014 09:22 PM, Boris BREZILLON wrote: > > > Hi, > > This is a first review, from someone who's clearly not a DRM/KMS expert > but who already thought about this specific driver :-). > > I strongly recommend that you wait for DRM/KMS maintainers and/or > experienced developer

Re: [RFC 1/3] atmel: drm: added drm driver for the atmel hlcd controller

2014-04-28 Thread Boris BREZILLON
Hi, This is a first review, from someone who's clearly not a DRM/KMS expert but who already thought about this specific driver :-). I strongly recommend that you wait for DRM/KMS maintainers and/or experienced developers reviews before modifying anything ;-). On 18/04/2014 11:45, Jean-Jacques

Re: [RFC 1/3] atmel: drm: added drm driver for the atmel hlcd controller

2014-04-19 Thread Jean-Jacques Hiblot
Thanks for the patch Robert. I've just noticed that I actually worked with an old version of the kernel (v3.14-rc3) when I thought it based on 3.15. JJ 2014-04-18 16:31 GMT+02:00 Robert Nelson : > > On Fri, Apr 18, 2014 at 8:21 AM, Boris BREZILLON > wrote: >> Hi JJ, >> >> On 18/04/2014 11:45, Je

Re: [RFC 1/3] atmel: drm: added drm driver for the atmel hlcd controller

2014-04-18 Thread Robert Nelson
On Fri, Apr 18, 2014 at 8:21 AM, Boris BREZILLON wrote: > Hi JJ, > > On 18/04/2014 11:45, Jean-Jacques Hiblot wrote: >> + >> +static void update_scanout(struct drm_crtc *crtc) >> +{ >> + struct atmel_hlcdc_crtc *hlcdc_crtc = to_atmel_hlcdc_crtc(crtc); >> + struct drm_device *dev = crtc->de

Re: [RFC 1/3] atmel: drm: added drm driver for the atmel hlcd controller

2014-04-18 Thread Boris BREZILLON
Hi JJ, On 18/04/2014 11:45, Jean-Jacques Hiblot wrote: > + > +static void update_scanout(struct drm_crtc *crtc) > +{ > + struct atmel_hlcdc_crtc *hlcdc_crtc = to_atmel_hlcdc_crtc(crtc); > + struct drm_device *dev = crtc->dev; > + struct atmel_hlcdc_drm_private *priv = dev->dev_private;