Re: [RFC 1/3] procfs: fdinfo -- Extend information about epoll target files

2017-02-22 Thread Cyrill Gorcunov
On Wed, Feb 22, 2017 at 11:29:23AM +0300, Pavel Emelyanov wrote: > On 02/22/2017 11:18 AM, Cyrill Gorcunov wrote: > > On Wed, Feb 22, 2017 at 11:09:23AM +0300, Pavel Emelyanov wrote: > > Actually it shouldn't. If you extend the kcmp argument to accept the > epollfd:epollslot pair, th

Re: [RFC 1/3] procfs: fdinfo -- Extend information about epoll target files

2017-02-22 Thread Pavel Emelyanov
On 02/22/2017 11:18 AM, Cyrill Gorcunov wrote: > On Wed, Feb 22, 2017 at 11:09:23AM +0300, Pavel Emelyanov wrote: Actually it shouldn't. If you extend the kcmp argument to accept the epollfd:epollslot pair, this would be effectively the same as if you had all your epoll-ed files

Re: [RFC 1/3] procfs: fdinfo -- Extend information about epoll target files

2017-02-22 Thread Cyrill Gorcunov
On Wed, Feb 22, 2017 at 11:09:23AM +0300, Pavel Emelyanov wrote: > >> > >> Actually it shouldn't. If you extend the kcmp argument to accept the > >> epollfd:epollslot pair, this would be effectively the same as if you > >> had all your epoll-ed files injected into your fdtable with "strange" > >> f

Re: [RFC 1/3] procfs: fdinfo -- Extend information about epoll target files

2017-02-22 Thread Pavel Emelyanov
On 02/22/2017 10:54 AM, Cyrill Gorcunov wrote: > On Wed, Feb 22, 2017 at 10:44:07AM +0300, Pavel Emelyanov wrote: >> On 02/21/2017 10:16 PM, Cyrill Gorcunov wrote: >>> On Tue, Feb 21, 2017 at 10:41:12AM -0800, Andy Lutomirski wrote: > Thus lets add file position, inode and device number where >

Re: [RFC 1/3] procfs: fdinfo -- Extend information about epoll target files

2017-02-21 Thread Cyrill Gorcunov
On Wed, Feb 22, 2017 at 10:44:07AM +0300, Pavel Emelyanov wrote: > On 02/21/2017 10:16 PM, Cyrill Gorcunov wrote: > > On Tue, Feb 21, 2017 at 10:41:12AM -0800, Andy Lutomirski wrote: > >>> Thus lets add file position, inode and device number where > >>> this target lays. This three fields can be us

Re: [RFC 1/3] procfs: fdinfo -- Extend information about epoll target files

2017-02-21 Thread Pavel Emelyanov
On 02/21/2017 10:16 PM, Cyrill Gorcunov wrote: > On Tue, Feb 21, 2017 at 10:41:12AM -0800, Andy Lutomirski wrote: >>> Thus lets add file position, inode and device number where >>> this target lays. This three fields can be used as a primary >>> key for sorting, and together with kcmp help CRIU can

Re: [RFC 1/3] procfs: fdinfo -- Extend information about epoll target files

2017-02-21 Thread Cyrill Gorcunov
On Tue, Feb 21, 2017 at 10:41:12AM -0800, Andy Lutomirski wrote: > > Thus lets add file position, inode and device number where > > this target lays. This three fields can be used as a primary > > key for sorting, and together with kcmp help CRIU can find > > out an exact file target (from the whol

Re: [RFC 1/3] procfs: fdinfo -- Extend information about epoll target files

2017-02-21 Thread Andy Lutomirski
On Tue, Feb 21, 2017 at 8:59 AM, Cyrill Gorcunov wrote: > Since it is possbile to have same number in tfd field (say > file added, closed, then nother file dup'ed to same number > and added back) it is imposible to distinguish such target > files solely by their numbers. > > Strictly speaking regu

[RFC 1/3] procfs: fdinfo -- Extend information about epoll target files

2017-02-21 Thread Cyrill Gorcunov
Since it is possbile to have same number in tfd field (say file added, closed, then nother file dup'ed to same number and added back) it is imposible to distinguish such target files solely by their numbers. Strictly speaking regular applications don't need to recognize these targets at all but fo