Re: [RFC 1/4] pwm: sifive: Add DT documentation for SiFive PWM Controller.

2018-11-09 Thread Paul Walmsley
On 10/16/18 3:04 PM, Thierry Reding wrote: > On Tue, Oct 16, 2018 at 10:31:42AM -0700, Paul Walmsley wrote: >> On 10/16/18 4:01 AM, Thierry Reding wrote: >>> On Mon, Oct 15, 2018 at 03:57:35PM -0700, Atish Patra wrote: On 10/10/18 6:49 AM, Thierry Reding wrote: > On Tue, Oct 09, 2018 at

Re: [RFC 1/4] pwm: sifive: Add DT documentation for SiFive PWM Controller.

2018-10-17 Thread Atish Patra
On 10/17/18 8:58 AM, Rob Herring wrote: On Tue, Oct 16, 2018 at 03:20:34PM -0700, Atish Patra wrote: On 10/16/18 3:04 PM, Thierry Reding wrote: On Tue, Oct 16, 2018 at 10:31:42AM -0700, Paul Walmsley wrote: On 10/16/18 4:01 AM, Thierry Reding wrote: On Mon, Oct 15, 2018 at 03:57:35PM -0700,

Re: [RFC 1/4] pwm: sifive: Add DT documentation for SiFive PWM Controller.

2018-10-17 Thread Rob Herring
On Tue, Oct 16, 2018 at 03:20:34PM -0700, Atish Patra wrote: > On 10/16/18 3:04 PM, Thierry Reding wrote: > > On Tue, Oct 16, 2018 at 10:31:42AM -0700, Paul Walmsley wrote: > > > > > > On 10/16/18 4:01 AM, Thierry Reding wrote: > > > > On Mon, Oct 15, 2018 at 03:57:35PM -0700, Atish Patra wrote: >

Re: [RFC 1/4] pwm: sifive: Add DT documentation for SiFive PWM Controller.

2018-10-16 Thread Atish Patra
On 10/16/18 3:51 AM, Thierry Reding wrote: On Mon, Oct 15, 2018 at 03:45:46PM -0700, Atish Patra wrote: On 10/10/18 6:51 AM, Thierry Reding wrote: On Tue, Oct 09, 2018 at 11:51:22AM -0700, Atish Patra wrote: [...] +- interrupts: one interrupt per PWM channel (currently unused in the driver)

Re: [RFC 1/4] pwm: sifive: Add DT documentation for SiFive PWM Controller.

2018-10-16 Thread Atish Patra
On 10/16/18 3:04 PM, Thierry Reding wrote: On Tue, Oct 16, 2018 at 10:31:42AM -0700, Paul Walmsley wrote: On 10/16/18 4:01 AM, Thierry Reding wrote: On Mon, Oct 15, 2018 at 03:57:35PM -0700, Atish Patra wrote: On 10/10/18 6:49 AM, Thierry Reding wrote: On Tue, Oct 09, 2018 at 11:51:22AM -070

Re: [RFC 1/4] pwm: sifive: Add DT documentation for SiFive PWM Controller.

2018-10-16 Thread Thierry Reding
On Tue, Oct 16, 2018 at 10:31:42AM -0700, Paul Walmsley wrote: > > On 10/16/18 4:01 AM, Thierry Reding wrote: > > On Mon, Oct 15, 2018 at 03:57:35PM -0700, Atish Patra wrote: > > > On 10/10/18 6:49 AM, Thierry Reding wrote: > > > > On Tue, Oct 09, 2018 at 11:51:22AM -0700, Atish Patra wrote: > > >

Re: [RFC 1/4] pwm: sifive: Add DT documentation for SiFive PWM Controller.

2018-10-16 Thread Paul Walmsley
On 10/16/18 4:01 AM, Thierry Reding wrote: On Mon, Oct 15, 2018 at 03:57:35PM -0700, Atish Patra wrote: On 10/10/18 6:49 AM, Thierry Reding wrote: On Tue, Oct 09, 2018 at 11:51:22AM -0700, Atish Patra wrote: +Required properties: +- compatible: should be one of + "sifive,fu540-c000-pwm

Re: [RFC 1/4] pwm: sifive: Add DT documentation for SiFive PWM Controller.

2018-10-16 Thread Thierry Reding
On Mon, Oct 15, 2018 at 04:19:20PM -0700, Wesley Terpstra wrote: > On Mon, Oct 15, 2018 at 3:57 PM Atish Patra wrote: > > >> +SiFive PWM controller > > >> + > > >> +Unlike most other PWM controllers, the SiFive PWM controller currently > > >> only > > >> +supports one period for all channels in t

Re: [RFC 1/4] pwm: sifive: Add DT documentation for SiFive PWM Controller.

2018-10-16 Thread Thierry Reding
On Mon, Oct 15, 2018 at 03:57:35PM -0700, Atish Patra wrote: > On 10/10/18 6:49 AM, Thierry Reding wrote: > > On Tue, Oct 09, 2018 at 11:51:22AM -0700, Atish Patra wrote: > > > From: "Wesley W. Terpstra" > > > > > > DT documentation for PWM controller added with updated compatible > > > string. >

Re: [RFC 1/4] pwm: sifive: Add DT documentation for SiFive PWM Controller.

2018-10-16 Thread Thierry Reding
On Mon, Oct 15, 2018 at 03:45:46PM -0700, Atish Patra wrote: > On 10/10/18 6:51 AM, Thierry Reding wrote: > > On Tue, Oct 09, 2018 at 11:51:22AM -0700, Atish Patra wrote: > > [...] > > > +- interrupts: one interrupt per PWM channel (currently unused in the > > > driver) > > > > This should probab

Re: [RFC 1/4] pwm: sifive: Add DT documentation for SiFive PWM Controller.

2018-10-15 Thread Wesley Terpstra
On Mon, Oct 15, 2018 at 3:57 PM Atish Patra wrote: > >> +SiFive PWM controller > >> + > >> +Unlike most other PWM controllers, the SiFive PWM controller currently > >> only > >> +supports one period for all channels in the PWM. This is set globally in > >> DTS. > >> +The period also has signific

Re: [RFC 1/4] pwm: sifive: Add DT documentation for SiFive PWM Controller.

2018-10-15 Thread Atish Patra
On 10/10/18 6:49 AM, Thierry Reding wrote: On Tue, Oct 09, 2018 at 11:51:22AM -0700, Atish Patra wrote: From: "Wesley W. Terpstra" DT documentation for PWM controller added with updated compatible string. Signed-off-by: Wesley W. Terpstra [Atish: Compatible string update] Signed-off-by: Atis

Re: [RFC 1/4] pwm: sifive: Add DT documentation for SiFive PWM Controller.

2018-10-15 Thread Atish Patra
On 10/10/18 6:51 AM, Thierry Reding wrote: On Tue, Oct 09, 2018 at 11:51:22AM -0700, Atish Patra wrote: [...] +- interrupts: one interrupt per PWM channel (currently unused in the driver) This should probably say what the interrupt is used for. And once you have that, remove the comment about

Re: [RFC 1/4] pwm: sifive: Add DT documentation for SiFive PWM Controller.

2018-10-10 Thread Thierry Reding
On Tue, Oct 09, 2018 at 11:51:22AM -0700, Atish Patra wrote: [...] > +- interrupts: one interrupt per PWM channel (currently unused in the driver) This should probably say what the interrupt is used for. And once you have that, remove the comment about it being unused in the driver. DT is OS agnos

Re: [RFC 1/4] pwm: sifive: Add DT documentation for SiFive PWM Controller.

2018-10-10 Thread Thierry Reding
On Tue, Oct 09, 2018 at 11:51:22AM -0700, Atish Patra wrote: > From: "Wesley W. Terpstra" > > DT documentation for PWM controller added with updated compatible > string. > > Signed-off-by: Wesley W. Terpstra > [Atish: Compatible string update] > Signed-off-by: Atish Patra > --- > .../devicetr

[RFC 1/4] pwm: sifive: Add DT documentation for SiFive PWM Controller.

2018-10-09 Thread Atish Patra
From: "Wesley W. Terpstra" DT documentation for PWM controller added with updated compatible string. Signed-off-by: Wesley W. Terpstra [Atish: Compatible string update] Signed-off-by: Atish Patra --- .../devicetree/bindings/pwm/pwm-sifive.txt | 32 ++ 1 file change