Re: [RFC 1/5] mm, page_alloc: clean up pageset high and batch update

2020-09-17 Thread Vlastimil Babka
On 9/10/20 10:31 AM, Oscar Salvador wrote: > On Mon, Sep 07, 2020 at 06:36:24PM +0200, Vlastimil Babka wrote: > >> -/* >> - * pageset_set_high() sets the high water mark for hot per_cpu_pagelist >> - * to the value high for the pageset p. >> - */ >> -static void pageset_set_high(struct

Re: [RFC 1/5] mm, page_alloc: clean up pageset high and batch update

2020-09-10 Thread David Hildenbrand
On 10.09.20 10:31, Oscar Salvador wrote: > On Mon, Sep 07, 2020 at 06:36:24PM +0200, Vlastimil Babka wrote: >> Signed-off-by: Vlastimil Babka > >> for_each_possible_cpu(cpu) >> -setup_pageset(_cpu(boot_pageset, cpu), 0); >> +setup_pageset(_cpu(boot_pageset, cpu)); >

Re: [RFC 1/5] mm, page_alloc: clean up pageset high and batch update

2020-09-10 Thread Oscar Salvador
On Thu, Sep 10, 2020 at 10:31:20AM +0200, Oscar Salvador wrote: > On Mon, Sep 07, 2020 at 06:36:24PM +0200, Vlastimil Babka wrote: > > Signed-off-by: Vlastimil Babka > > > for_each_possible_cpu(cpu) > > - setup_pageset(_cpu(boot_pageset, cpu), 0); > > +

Re: [RFC 1/5] mm, page_alloc: clean up pageset high and batch update

2020-09-10 Thread Oscar Salvador
On Mon, Sep 07, 2020 at 06:36:24PM +0200, Vlastimil Babka wrote: > Signed-off-by: Vlastimil Babka > for_each_possible_cpu(cpu) > - setup_pageset(_cpu(boot_pageset, cpu), 0); > + setup_pageset(_cpu(boot_pageset, cpu)); This is not really anything important but I

[RFC 1/5] mm, page_alloc: clean up pageset high and batch update

2020-09-07 Thread Vlastimil Babka
The updates to pcplists' high and batch valued are handled by multiple functions that make the calculations hard to follow. Consolidate everything to pageset_set_high_and_batch() and remove pageset_set_batch() and pageset_set_high() wrappers. The only special case using one of the removed