Re: [RFC 2/4] dma: add dmaengine driver for Samsung s3c24xx SoCs

2013-05-17 Thread Linus Walleij
On Wed, May 15, 2013 at 10:31 PM, Heiko Stübner wrote: > If I understand the writel semantics and the thread from you from 2011 [0] > correctly, only the writel to DMASKTRIG mustn't be relaxed to make sure the > settings registers are written to before, so like: > >writel_relaxed(txd->src

Re: [RFC 2/4] dma: add dmaengine driver for Samsung s3c24xx SoCs

2013-05-15 Thread Jingoo Han
On Tuesday, May 14, 2013 11:22 PM Tomasz Figa wrote: > > Hi Linus, Heiko, > > On Tuesday 14 of May 2013 14:47:19 Linus Walleij wrote: > > On Sat, May 11, 2013 at 1:31 PM, Heiko St?bner wrote: > > > Conceptually the s3c24xx-dma feels like a distant relative of the pl08x > > > with numerous virtua

Re: [RFC 2/4] dma: add dmaengine driver for Samsung s3c24xx SoCs

2013-05-15 Thread Tomasz Figa
On Thursday 16 of May 2013 00:45:03 Heiko Stübner wrote: > Am Donnerstag, 16. Mai 2013, 00:02:40 schrieb Tomasz Figa: > > On Wednesday 15 of May 2013 23:48:31 Heiko Stübner wrote: > > > Am Mittwoch, 15. Mai 2013, 23:20:08 schrieb Sylwester Nawrocki: > > > > On 05/15/2013 10:31 PM, Heiko Stübner wro

Re: [RFC 2/4] dma: add dmaengine driver for Samsung s3c24xx SoCs

2013-05-15 Thread Heiko Stübner
Am Donnerstag, 16. Mai 2013, 00:02:40 schrieb Tomasz Figa: > On Wednesday 15 of May 2013 23:48:31 Heiko Stübner wrote: > > Am Mittwoch, 15. Mai 2013, 23:20:08 schrieb Sylwester Nawrocki: > > > On 05/15/2013 10:31 PM, Heiko Stübner wrote: > > > >>> + BUG(); > > > >>> > > > >> > Isn't that a

Re: [RFC 2/4] dma: add dmaengine driver for Samsung s3c24xx SoCs

2013-05-15 Thread Tomasz Figa
On Wednesday 15 of May 2013 23:48:31 Heiko Stübner wrote: > Am Mittwoch, 15. Mai 2013, 23:20:08 schrieb Sylwester Nawrocki: > > On 05/15/2013 10:31 PM, Heiko Stübner wrote: > > >>> + BUG(); > > >>> > > >> > Isn't that a bit nasty. This macro should be used with care and > > >> > we > > >>

Re: [RFC 2/4] dma: add dmaengine driver for Samsung s3c24xx SoCs

2013-05-15 Thread Heiko Stübner
Am Mittwoch, 15. Mai 2013, 23:20:08 schrieb Sylwester Nawrocki: > On 05/15/2013 10:31 PM, Heiko Stübner wrote: > >>> + BUG(); > >>> > >> > Isn't that a bit nasty. This macro should be used with care and we > >> > should recover if possible. dev_err()? > > > > runtime_config already denies

Re: [RFC 2/4] dma: add dmaengine driver for Samsung s3c24xx SoCs

2013-05-15 Thread Sylwester Nawrocki
On 05/15/2013 10:31 PM, Heiko Stübner wrote: + BUG(); > > Isn't that a bit nasty. This macro should be used with care and we > should recover if possible. dev_err()? runtime_config already denies any settings not in the 1,2 or 4bytes range - the default-part should therefore never be r

Re: [RFC 2/4] dma: add dmaengine driver for Samsung s3c24xx SoCs

2013-05-15 Thread Heiko Stübner
Am Mittwoch, 15. Mai 2013, 20:53:32 schrieb Linus Walleij: > On Sat, May 11, 2013 at 1:31 PM, Heiko Stübner wrote: > > This adds a new driver to support the s3c24xx dma using the dmaengine > > and make the old one in mach-s3c24xx obsolete in the long run. > > > > Conceptually the s3c24xx-dma feel

Re: [RFC 2/4] dma: add dmaengine driver for Samsung s3c24xx SoCs

2013-05-15 Thread Linus Walleij
On Sat, May 11, 2013 at 1:31 PM, Heiko Stübner wrote: > This adds a new driver to support the s3c24xx dma using the dmaengine > and make the old one in mach-s3c24xx obsolete in the long run. > > Conceptually the s3c24xx-dma feels like a distant relative of the pl08x > with numerous virtual channe

Re: [RFC 2/4] dma: add dmaengine driver for Samsung s3c24xx SoCs

2013-05-15 Thread Linus Walleij
On Tue, May 14, 2013 at 3:51 PM, Heiko Stübner wrote: > Am Dienstag, 14. Mai 2013, 14:47:19 schrieb Linus Walleij: >> On Sat, May 11, 2013 at 1:31 PM, Heiko Stübner wrote: >> > Conceptually the s3c24xx-dma feels like a distant relative of the pl08x >> > with numerous virtual channels being mapped

Re: [RFC 2/4] dma: add dmaengine driver for Samsung s3c24xx SoCs

2013-05-14 Thread Tomasz Figa
Hi Linus, Heiko, On Tuesday 14 of May 2013 14:47:19 Linus Walleij wrote: > On Sat, May 11, 2013 at 1:31 PM, Heiko Stübner wrote: > > Conceptually the s3c24xx-dma feels like a distant relative of the pl08x > > with numerous virtual channels being mapped to a lot less physical ones. > > The driver

Re: [RFC 2/4] dma: add dmaengine driver for Samsung s3c24xx SoCs

2013-05-14 Thread Heiko Stübner
Am Dienstag, 14. Mai 2013, 14:47:19 schrieb Linus Walleij: > On Sat, May 11, 2013 at 1:31 PM, Heiko Stübner wrote: > > Conceptually the s3c24xx-dma feels like a distant relative of the pl08x > > with numerous virtual channels being mapped to a lot less physical ones. > > The driver therefore borro

Re: [RFC 2/4] dma: add dmaengine driver for Samsung s3c24xx SoCs

2013-05-14 Thread Linus Walleij
On Sat, May 11, 2013 at 1:31 PM, Heiko Stübner wrote: > Conceptually the s3c24xx-dma feels like a distant relative of the pl08x > with numerous virtual channels being mapped to a lot less physical ones. > The driver therefore borrows a lot from the amba-pl08x driver in this > regard. Functionalit

[RFC 2/4] dma: add dmaengine driver for Samsung s3c24xx SoCs

2013-05-11 Thread Heiko Stübner
This adds a new driver to support the s3c24xx dma using the dmaengine and make the old one in mach-s3c24xx obsolete in the long run. Conceptually the s3c24xx-dma feels like a distant relative of the pl08x with numerous virtual channels being mapped to a lot less physical ones. The driver therefore