Re: [RFC 3/4] trace_uprobe: Support SDT markers having semaphore

2018-03-07 Thread Peter Zijlstra
On Wed, Mar 07, 2018 at 02:16:13PM +0530, Ravi Bangoria wrote: > > W.T.H. is that called a semaphore? afaict its just a usage-counter. > > I totally agree with you. But it's not me who named it semaphore :) > > Please refer to "Semaphore Handling" section at: > https://sourceware.org/systemtap/wi

Re: [RFC 3/4] trace_uprobe: Support SDT markers having semaphore

2018-03-07 Thread Ravi Bangoria
On 03/06/2018 05:29 PM, Peter Zijlstra wrote: > On Wed, Feb 28, 2018 at 01:23:44PM +0530, Ravi Bangoria wrote: >> Userspace Statically Defined Tracepoints[1] are dtrace style markers >> inside userspace applications. These markers are added by developer at >> important places in the code. Each ma

Re: [RFC 3/4] trace_uprobe: Support SDT markers having semaphore

2018-03-06 Thread Peter Zijlstra
On Wed, Feb 28, 2018 at 01:23:44PM +0530, Ravi Bangoria wrote: > Userspace Statically Defined Tracepoints[1] are dtrace style markers > inside userspace applications. These markers are added by developer at > important places in the code. Each marker source expands to a single > nop instruction in

Re: [RFC 3/4] trace_uprobe: Support SDT markers having semaphore

2018-03-01 Thread Ravi Bangoria
On 03/01/2018 07:37 PM, Masami Hiramatsu wrote: > On Wed, 28 Feb 2018 13:23:44 +0530 > Ravi Bangoria wrote: > >> @@ -502,6 +504,16 @@ static int create_trace_uprobe(int argc, char **argv) >> for (i = 0; i < argc && i < MAX_TRACE_ARGS; i++) { >> struct probe_arg *parg = &tu->tp.

Re: [RFC 3/4] trace_uprobe: Support SDT markers having semaphore

2018-03-01 Thread Masami Hiramatsu
On Wed, 28 Feb 2018 13:23:44 +0530 Ravi Bangoria wrote: > Userspace Statically Defined Tracepoints[1] are dtrace style markers > inside userspace applications. These markers are added by developer at > important places in the code. Each marker source expands to a single > nop instruction in the c

[RFC 3/4] trace_uprobe: Support SDT markers having semaphore

2018-02-27 Thread Ravi Bangoria
Userspace Statically Defined Tracepoints[1] are dtrace style markers inside userspace applications. These markers are added by developer at important places in the code. Each marker source expands to a single nop instruction in the compiled code but there may be additional overhead for computing th