Re: [RFC 4/8] regulator: core: Check enabling bypass respects constraints

2017-04-13 Thread Leonard Crestez
On Fri, 2017-04-07 at 12:22 +0100, Mark Brown wrote: > On Fri, Apr 07, 2017 at 01:51:52PM +0300, Leonard Crestez wrote: > > It currently seems to work how I expect but from your statement it's > > not clear if it's entirely intentional. > The current behaviour of bypassed regulators is intentiona

Re: [RFC 4/8] regulator: core: Check enabling bypass respects constraints

2017-04-07 Thread Mark Brown
On Fri, Apr 07, 2017 at 01:51:52PM +0300, Leonard Crestez wrote: > It currently seems to work how I expect but from your statement it's > not clear if it's entirely intentional. The current behaviour of bypassed regulators is intentional. > > > Or should a bypassed regulator ignore all other req

Re: [RFC 4/8] regulator: core: Check enabling bypass respects constraints

2017-04-07 Thread Leonard Crestez
On Thu, 2017-04-06 at 19:52 +0100, Mark Brown wrote: > On Tue, Mar 28, 2017 at 10:49:55PM +0300, Leonard Crestez wrote: > > On Tue, 2017-03-28 at 17:47 +0100, Mark Brown wrote: > > > To repeat what I said previously the whole point of bypassing is to not > > > do regulation and generally the const

Re: [RFC 4/8] regulator: core: Check enabling bypass respects constraints

2017-04-06 Thread Mark Brown
On Tue, Mar 28, 2017 at 10:49:55PM +0300, Leonard Crestez wrote: > On Tue, 2017-03-28 at 17:47 +0100, Mark Brown wrote: > > To repeat what I said previously the whole point of bypassing is to not > > do regulation and generally the constraints in the unregulated idle case > > are substantially mor

Re: [RFC 4/8] regulator: core: Check enabling bypass respects constraints

2017-03-28 Thread Leonard Crestez
On Tue, 2017-03-28 at 17:47 +0100, Mark Brown wrote: > On Tue, Mar 28, 2017 at 03:39:41PM +0300, Leonard Crestez wrote: > > On Fri, 2017-03-24 at 12:52 +, Mark Brown wrote: > Please fix your mail client to word wrap within paragraphs at something > substantially less than 80 columns.  Doing th

Re: [RFC 4/8] regulator: core: Check enabling bypass respects constraints

2017-03-28 Thread Mark Brown
On Tue, Mar 28, 2017 at 03:39:41PM +0300, Leonard Crestez wrote: > On Fri, 2017-03-24 at 12:52 +, Mark Brown wrote: Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to. > >

Re: [RFC 4/8] regulator: core: Check enabling bypass respects constraints

2017-03-28 Thread Leonard Crestez
On Fri, 2017-03-24 at 12:52 +, Mark Brown wrote: > On Wed, Mar 22, 2017 at 06:53:06PM +0200, Leonard Crestez wrote: > > > > > Enabling bypass mode makes a regulator passthrough the supply voltage > > directly. It is possible that the supply voltage is set high enough that > > it violates mach

Re: [RFC 4/8] regulator: core: Check enabling bypass respects constraints

2017-03-24 Thread Mark Brown
On Wed, Mar 22, 2017 at 06:53:06PM +0200, Leonard Crestez wrote: > Enabling bypass mode makes a regulator passthrough the supply voltage > directly. It is possible that the supply voltage is set high enough that > it violates machine constraints so let's check for that. > > The supply voltage mig

[RFC 4/8] regulator: core: Check enabling bypass respects constraints

2017-03-22 Thread Leonard Crestez
Enabling bypass mode makes a regulator passthrough the supply voltage directly. It is possible that the supply voltage is set high enough that it violates machine constraints so let's check for that. The supply voltage might be higher because of min_dropout_uV or maybe there is just an unrelated c