Re: [RFC 5/8] kdbus: use LSM hooks in kdbus code

2015-07-10 Thread Stephen Smalley
On 07/08/2015 09:37 AM, Stephen Smalley wrote: > On 07/08/2015 06:25 AM, Paul Osmialowski wrote: >> Originates from: >> >> https://github.com/lmctl/kdbus.git (branch: kdbus-lsm-v4.for-systemd-v212) >> commit: aa0885489d19be92fa41c6f0a71df28763228a40 >> >> Signed-off-by: Karol Lewandowski >> Signed

Re: [RFC 5/8] kdbus: use LSM hooks in kdbus code

2015-07-10 Thread Stephen Smalley
On 07/08/2015 09:37 AM, Stephen Smalley wrote: > On 07/08/2015 06:25 AM, Paul Osmialowski wrote: >> Originates from: >> >> https://github.com/lmctl/kdbus.git (branch: kdbus-lsm-v4.for-systemd-v212) >> commit: aa0885489d19be92fa41c6f0a71df28763228a40 >> >> Signed-off-by: Karol Lewandowski >> Signed

Re: [RFC 5/8] kdbus: use LSM hooks in kdbus code

2015-07-09 Thread Paul Osmialowski
On Thu, 9 Jul 2015, Sergei Zviagintsev wrote: Hi, On Wed, Jul 08, 2015 at 02:12:03PM +0200, Paul Osmialowski wrote: [...] + ret = security_kdbus_bus_alloc(b); + if (ret) { + goto exit_unref; + } checkpatch.pl will complain about this It should but it di

Re: [RFC 5/8] kdbus: use LSM hooks in kdbus code

2015-07-09 Thread Sergei Zviagintsev
Hi, On Wed, Jul 08, 2015 at 02:12:03PM +0200, Paul Osmialowski wrote: [...] > > + ret = security_kdbus_bus_alloc(b); > + if (ret) { > + goto exit_unref; > + } checkpatch.pl will complain about this -- To unsubscribe from this list: send the line "unsubscribe linux-kerne

Re: [RFC 5/8] kdbus: use LSM hooks in kdbus code

2015-07-08 Thread Casey Schaufler
On 7/8/2015 3:25 AM, Paul Osmialowski wrote: > Originates from: > > https://github.com/lmctl/kdbus.git (branch: kdbus-lsm-v4.for-systemd-v212) > commit: aa0885489d19be92fa41c6f0a71df28763228a40 > > Signed-off-by: Karol Lewandowski > Signed-off-by: Paul Osmialowski > --- > ipc/kdbus/bus.c

Re: [RFC 5/8] kdbus: use LSM hooks in kdbus code

2015-07-08 Thread Greg Kroah-Hartman
On Wed, Jul 08, 2015 at 12:25:07PM +0200, Paul Osmialowski wrote: > Originates from: > > https://github.com/lmctl/kdbus.git (branch: kdbus-lsm-v4.for-systemd-v212) > commit: aa0885489d19be92fa41c6f0a71df28763228a40 That's a horrid changelog entry, what is it supposed to mean? Don't refer to a di

Re: [RFC 5/8] kdbus: use LSM hooks in kdbus code

2015-07-08 Thread Stephen Smalley
On 07/08/2015 06:25 AM, Paul Osmialowski wrote: > Originates from: > > https://github.com/lmctl/kdbus.git (branch: kdbus-lsm-v4.for-systemd-v212) > commit: aa0885489d19be92fa41c6f0a71df28763228a40 > > Signed-off-by: Karol Lewandowski > Signed-off-by: Paul Osmialowski > --- > ipc/kdbus/bus.c

Re: [RFC 5/8] kdbus: use LSM hooks in kdbus code

2015-07-08 Thread Paul Osmialowski
Returning EPERM can be misleading. From 9c37667302f104e0f412ba2727c4d3df81fb59da Mon Sep 17 00:00:00 2001 From: Paul Osmialowski Date: Tue, 26 May 2015 12:00:33 +0200 Subject: [RFC 5/8] kdbus: use LSM hooks in kdbus code Originates from: https://github.com/lmctl/kdbus.git (branch: kdbus-lsm-v4.for-sy

Re: [RFC 5/8] kdbus: use LSM hooks in kdbus code

2015-07-08 Thread Lukasz Pawelczyk
On śro, 2015-07-08 at 12:25 +0200, Paul Osmialowski wrote: > Originates from: > > https://github.com/lmctl/kdbus.git (branch: kdbus-lsm-v4.for-systemd > -v212) > commit: aa0885489d19be92fa41c6f0a71df28763228a40 > > Signed-off-by: Karol Lewandowski > Signed-off-by: Paul Osmialowski > --- > ipc/

Re: [RFC 5/8] kdbus: use LSM hooks in kdbus code

2015-07-08 Thread Lukasz Pawelczyk
On śro, 2015-07-08 at 12:25 +0200, Paul Osmialowski wrote: > Originates from: > > https://github.com/lmctl/kdbus.git (branch: kdbus-lsm-v4.for-systemd > -v212) > commit: aa0885489d19be92fa41c6f0a71df28763228a40 > > Signed-off-by: Karol Lewandowski > Signed-off-by: Paul Osmialowski > --- > ipc/

[RFC 5/8] kdbus: use LSM hooks in kdbus code

2015-07-08 Thread Paul Osmialowski
Originates from: https://github.com/lmctl/kdbus.git (branch: kdbus-lsm-v4.for-systemd-v212) commit: aa0885489d19be92fa41c6f0a71df28763228a40 Signed-off-by: Karol Lewandowski Signed-off-by: Paul Osmialowski --- ipc/kdbus/bus.c| 12 ++- ipc/kdbus/bus.h| 3 +++ ipc/kdbus/