Re: [RFC 6/6] Revert "pstore/ram_core: Do not reset restored zone's position and size"

2018-10-26 Thread Joel Fernandes
On Fri, Oct 26, 2018 at 08:42:12PM +0100, Kees Cook wrote: > On Fri, Oct 26, 2018 at 7:22 PM, Joel Fernandes > wrote: > > On Fri, Oct 26, 2018 at 07:16:28PM +0100, Kees Cook wrote: > >> On Fri, Oct 26, 2018 at 7:00 PM, Joel Fernandes (Google) > >> wrote: > >> > This reverts commit

Re: [RFC 6/6] Revert "pstore/ram_core: Do not reset restored zone's position and size"

2018-10-26 Thread Joel Fernandes
On Fri, Oct 26, 2018 at 08:42:12PM +0100, Kees Cook wrote: > On Fri, Oct 26, 2018 at 7:22 PM, Joel Fernandes > wrote: > > On Fri, Oct 26, 2018 at 07:16:28PM +0100, Kees Cook wrote: > >> On Fri, Oct 26, 2018 at 7:00 PM, Joel Fernandes (Google) > >> wrote: > >> > This reverts commit

Re: [RFC 6/6] Revert "pstore/ram_core: Do not reset restored zone's position and size"

2018-10-26 Thread Kees Cook
On Fri, Oct 26, 2018 at 7:22 PM, Joel Fernandes wrote: > On Fri, Oct 26, 2018 at 07:16:28PM +0100, Kees Cook wrote: >> On Fri, Oct 26, 2018 at 7:00 PM, Joel Fernandes (Google) >> wrote: >> > This reverts commit 25b63da64708212985c06c7f8b089d356efdd9cf. >> > >> > Due to the commit which is being

Re: [RFC 6/6] Revert "pstore/ram_core: Do not reset restored zone's position and size"

2018-10-26 Thread Kees Cook
On Fri, Oct 26, 2018 at 7:22 PM, Joel Fernandes wrote: > On Fri, Oct 26, 2018 at 07:16:28PM +0100, Kees Cook wrote: >> On Fri, Oct 26, 2018 at 7:00 PM, Joel Fernandes (Google) >> wrote: >> > This reverts commit 25b63da64708212985c06c7f8b089d356efdd9cf. >> > >> > Due to the commit which is being

Re: [RFC 6/6] Revert "pstore/ram_core: Do not reset restored zone's position and size"

2018-10-26 Thread Joel Fernandes
On Fri, Oct 26, 2018 at 07:16:28PM +0100, Kees Cook wrote: > On Fri, Oct 26, 2018 at 7:00 PM, Joel Fernandes (Google) > wrote: > > This reverts commit 25b63da64708212985c06c7f8b089d356efdd9cf. > > > > Due to the commit which is being reverted here, it is not possible to > > know if pstore's

Re: [RFC 6/6] Revert "pstore/ram_core: Do not reset restored zone's position and size"

2018-10-26 Thread Joel Fernandes
On Fri, Oct 26, 2018 at 07:16:28PM +0100, Kees Cook wrote: > On Fri, Oct 26, 2018 at 7:00 PM, Joel Fernandes (Google) > wrote: > > This reverts commit 25b63da64708212985c06c7f8b089d356efdd9cf. > > > > Due to the commit which is being reverted here, it is not possible to > > know if pstore's

Re: [RFC 6/6] Revert "pstore/ram_core: Do not reset restored zone's position and size"

2018-10-26 Thread Kees Cook
On Fri, Oct 26, 2018 at 7:00 PM, Joel Fernandes (Google) wrote: > This reverts commit 25b63da64708212985c06c7f8b089d356efdd9cf. > > Due to the commit which is being reverted here, it is not possible to > know if pstore's messages were from a previous boot, or from very old > boots. This creates

Re: [RFC 6/6] Revert "pstore/ram_core: Do not reset restored zone's position and size"

2018-10-26 Thread Kees Cook
On Fri, Oct 26, 2018 at 7:00 PM, Joel Fernandes (Google) wrote: > This reverts commit 25b63da64708212985c06c7f8b089d356efdd9cf. > > Due to the commit which is being reverted here, it is not possible to > know if pstore's messages were from a previous boot, or from very old > boots. This creates

[RFC 6/6] Revert "pstore/ram_core: Do not reset restored zone's position and size"

2018-10-26 Thread Joel Fernandes (Google)
This reverts commit 25b63da64708212985c06c7f8b089d356efdd9cf. Due to the commit which is being reverted here, it is not possible to know if pstore's messages were from a previous boot, or from very old boots. This creates an awkard situation where its unclear if crash or other logs are from the

[RFC 6/6] Revert "pstore/ram_core: Do not reset restored zone's position and size"

2018-10-26 Thread Joel Fernandes (Google)
This reverts commit 25b63da64708212985c06c7f8b089d356efdd9cf. Due to the commit which is being reverted here, it is not possible to know if pstore's messages were from a previous boot, or from very old boots. This creates an awkard situation where its unclear if crash or other logs are from the