Re: [RFC 7/7] x86/current: Aggressive caching of current

2019-07-22 Thread Nadav Amit
> On Jul 22, 2019, at 2:07 PM, Peter Zijlstra wrote: > > On Thu, Jul 18, 2019 at 10:41:10AM -0700, Nadav Amit wrote: >> The current_task is supposed to be constant in each thread and therefore >> does not need to be reread. There is already an attempt to cache it >> using inline assembly, using

Re: [RFC 7/7] x86/current: Aggressive caching of current

2019-07-22 Thread Peter Zijlstra
On Thu, Jul 18, 2019 at 10:41:10AM -0700, Nadav Amit wrote: > The current_task is supposed to be constant in each thread and therefore > does not need to be reread. There is already an attempt to cache it > using inline assembly, using this_cpu_read_stable(), which hides the > dependency on the

[RFC 7/7] x86/current: Aggressive caching of current

2019-07-18 Thread Nadav Amit
The current_task is supposed to be constant in each thread and therefore does not need to be reread. There is already an attempt to cache it using inline assembly, using this_cpu_read_stable(), which hides the dependency on the read memory address. However, this caching is not working very well.