Re: [RFC PATCH] ALSA: compress: Fix gapless playback state machine

2020-06-11 Thread Vinod Koul
On 11-06-20, 10:42, Charles Keepax wrote: > On Thu, Jun 11, 2020 at 03:14:23PM +0530, Vinod Koul wrote: > > On 11-06-20, 11:09, Jaroslav Kysela wrote: > > > Dne 11. 06. 20 v 10:46 Charles Keepax napsal(a): > > > > On Wed, Jun 10, 2020 at 04:28:20PM +0530, Vinod Koul wrote: > > > > > On 10-06-20,

Re: [RFC PATCH] ALSA: compress: Fix gapless playback state machine

2020-06-11 Thread Vinod Koul
On 11-06-20, 12:40, Jaroslav Kysela wrote: > Dne 11. 06. 20 v 11:44 Vinod Koul napsal(a): > > On 11-06-20, 11:09, Jaroslav Kysela wrote: > > > Dne 11. 06. 20 v 10:46 Charles Keepax napsal(a): > > > > On Wed, Jun 10, 2020 at 04:28:20PM +0530, Vinod Koul wrote: > > > > > On 10-06-20, 12:40, Jaroslav

Re: [RFC PATCH] ALSA: compress: Fix gapless playback state machine

2020-06-11 Thread Charles Keepax
On Thu, Jun 11, 2020 at 03:14:23PM +0530, Vinod Koul wrote: > On 11-06-20, 11:09, Jaroslav Kysela wrote: > > Dne 11. 06. 20 v 10:46 Charles Keepax napsal(a): > > > On Wed, Jun 10, 2020 at 04:28:20PM +0530, Vinod Koul wrote: > > > > On 10-06-20, 12:40, Jaroslav Kysela wrote: > > > > > Dne 10. 06.

Re: [RFC PATCH] ALSA: compress: Fix gapless playback state machine

2020-06-11 Thread Jaroslav Kysela
Dne 11. 06. 20 v 11:44 Vinod Koul napsal(a): On 11-06-20, 11:09, Jaroslav Kysela wrote: Dne 11. 06. 20 v 10:46 Charles Keepax napsal(a): On Wed, Jun 10, 2020 at 04:28:20PM +0530, Vinod Koul wrote: On 10-06-20, 12:40, Jaroslav Kysela wrote: Dne 10. 06. 20 v 12:07 Srinivas Kandagatla

Re: [RFC PATCH] ALSA: compress: Fix gapless playback state machine

2020-06-11 Thread Vinod Koul
On 11-06-20, 11:09, Jaroslav Kysela wrote: > Dne 11. 06. 20 v 10:46 Charles Keepax napsal(a): > > On Wed, Jun 10, 2020 at 04:28:20PM +0530, Vinod Koul wrote: > > > On 10-06-20, 12:40, Jaroslav Kysela wrote: > > > > Dne 10. 06. 20 v 12:07 Srinivas Kandagatla napsal(a): > > > > > For gapless

Re: [RFC PATCH] ALSA: compress: Fix gapless playback state machine

2020-06-11 Thread Jaroslav Kysela
Dne 11. 06. 20 v 10:46 Charles Keepax napsal(a): On Wed, Jun 10, 2020 at 04:28:20PM +0530, Vinod Koul wrote: On 10-06-20, 12:40, Jaroslav Kysela wrote: Dne 10. 06. 20 v 12:07 Srinivas Kandagatla napsal(a): For gapless playback call to snd_compr_drain_notify() after partial drain should put

Re: [RFC PATCH] ALSA: compress: Fix gapless playback state machine

2020-06-11 Thread Charles Keepax
On Wed, Jun 10, 2020 at 04:28:20PM +0530, Vinod Koul wrote: > On 10-06-20, 12:40, Jaroslav Kysela wrote: > > Dne 10. 06. 20 v 12:07 Srinivas Kandagatla napsal(a): > > > For gapless playback call to snd_compr_drain_notify() after > > > partial drain should put the state to SNDRV_PCM_STATE_RUNNING >

Re: [RFC PATCH] ALSA: compress: Fix gapless playback state machine

2020-06-10 Thread Pierre-Louis Bossart
On 6/10/20 5:07 AM, Srinivas Kandagatla wrote: For gapless playback call to snd_compr_drain_notify() after partial drain should put the state to SNDRV_PCM_STATE_RUNNING rather than SNDRV_PCM_STATE_SETUP as the driver is ready to process the buffers for new track. With existing code, if we

Re: [RFC PATCH] ALSA: compress: Fix gapless playback state machine

2020-06-10 Thread Vinod Koul
On 10-06-20, 12:40, Jaroslav Kysela wrote: > Dne 10. 06. 20 v 12:07 Srinivas Kandagatla napsal(a): > > For gapless playback call to snd_compr_drain_notify() after > > partial drain should put the state to SNDRV_PCM_STATE_RUNNING > > rather than SNDRV_PCM_STATE_SETUP as the driver is ready to > >

Re: [RFC PATCH] ALSA: compress: Fix gapless playback state machine

2020-06-10 Thread Srinivas Kandagatla
On 10/06/2020 11:40, Jaroslav Kysela wrote: Dne 10. 06. 20 v 12:07 Srinivas Kandagatla napsal(a): For gapless playback call to snd_compr_drain_notify() after partial drain should put the state to SNDRV_PCM_STATE_RUNNING rather than SNDRV_PCM_STATE_SETUP as the driver is ready to process the

Re: [RFC PATCH] ALSA: compress: Fix gapless playback state machine

2020-06-10 Thread Jaroslav Kysela
Dne 10. 06. 20 v 12:07 Srinivas Kandagatla napsal(a): For gapless playback call to snd_compr_drain_notify() after partial drain should put the state to SNDRV_PCM_STATE_RUNNING rather than SNDRV_PCM_STATE_SETUP as the driver is ready to process the buffers for new track. With existing code, if

[RFC PATCH] ALSA: compress: Fix gapless playback state machine

2020-06-10 Thread Srinivas Kandagatla
For gapless playback call to snd_compr_drain_notify() after partial drain should put the state to SNDRV_PCM_STATE_RUNNING rather than SNDRV_PCM_STATE_SETUP as the driver is ready to process the buffers for new track. With existing code, if we are playing 3 tracks in gapless, after partial drain