Re: [RFC PATCH] PCI: Remove End-End TLP as PASID dependency

2020-06-13 Thread Zhangfei Gao
On 2020/6/12 上午1:41, Bjorn Helgaas wrote: [+cc Sinan] On Wed, Jun 10, 2020 at 12:18:14PM +0800, Zhangfei Gao wrote: Some platform devices appear as PCI and have PCI cfg space, but are actually on the AMBA bus. They can support PASID via smmu stall feature, but does not support tlp since they

Re: [RFC PATCH] PCI: Remove End-End TLP as PASID dependency

2020-06-11 Thread Bjorn Helgaas
[+cc Sinan] On Wed, Jun 10, 2020 at 12:18:14PM +0800, Zhangfei Gao wrote: > Some platform devices appear as PCI and have PCI cfg space, > but are actually on the AMBA bus. > They can support PASID via smmu stall feature, but does not > support tlp since they are not real pci devices. > So remove t

Re: [RFC PATCH] PCI: Remove End-End TLP as PASID dependency

2020-06-11 Thread Sinan Kaya
On 6/10/2020 4:00 AM, Zhangfei Gao wrote: >> Why not set the eetlp_prefix_path bit from a PCI quirk?  Unlike the stall >> problem from the other thread, this one looks like a simple design >> mistake >> that can be fixed easily in future iterations of the platform: just set >> the "End-End TLP Pref

Re: [RFC PATCH] PCI: Remove End-End TLP as PASID dependency

2020-06-10 Thread Zhangfei Gao
On 2020/6/10 下午3:46, Jean-Philippe Brucker wrote: On Wed, Jun 10, 2020 at 12:18:14PM +0800, Zhangfei Gao wrote: Some platform devices appear as PCI and have PCI cfg space, but are actually on the AMBA bus. They can support PASID via smmu stall feature, but does not support tlp since they are

Re: [RFC PATCH] PCI: Remove End-End TLP as PASID dependency

2020-06-10 Thread Jean-Philippe Brucker
On Wed, Jun 10, 2020 at 12:18:14PM +0800, Zhangfei Gao wrote: > Some platform devices appear as PCI and have PCI cfg space, > but are actually on the AMBA bus. > They can support PASID via smmu stall feature, but does not > support tlp since they are not real pci devices. > So remove tlp as a PASID

[RFC PATCH] PCI: Remove End-End TLP as PASID dependency

2020-06-09 Thread Zhangfei Gao
Some platform devices appear as PCI and have PCI cfg space, but are actually on the AMBA bus. They can support PASID via smmu stall feature, but does not support tlp since they are not real pci devices. So remove tlp as a PASID dependency. Signed-off-by: Zhangfei Gao --- drivers/pci/ats.c | 3 --