Re: [RFC PATCH] UBI: fix rb_tree node comparison in add_map

2014-05-13 Thread Artem Bityutskiy
On Fri, 2014-03-21 at 15:54 -0400, Mike Snitzer wrote: > The comparisons used in add_vol() shouldn't be identical. Pretty sure > the following is correct but it is completely untested. > > Signed-off-by: Mike Snitzer Pushed to linux-ubifs.git, thanks! -- Best Regards, Artem Bityutskiy -- To

Re: [RFC PATCH] UBI: fix rb_tree node comparison in add_map

2014-05-13 Thread Artem Bityutskiy
On Fri, 2014-05-09 at 18:19 -0700, Brian Norris wrote: > Hi Artem, > > On Sat, Mar 22, 2014 at 12:56:59AM +0100, Richard Weinberger wrote: > > Am 21.03.2014 20:54, schrieb Mike Snitzer: > > > The comparisons used in add_vol() shouldn't be identical. Pretty sure > > > the following is correct but

Re: [RFC PATCH] UBI: fix rb_tree node comparison in add_map

2014-05-09 Thread Brian Norris
Hi Artem, On Sat, Mar 22, 2014 at 12:56:59AM +0100, Richard Weinberger wrote: > Am 21.03.2014 20:54, schrieb Mike Snitzer: > > The comparisons used in add_vol() shouldn't be identical. Pretty sure > > the following is correct but it is completely untested. > > > > Signed-off-by: Mike Snitzer >

Re: [RFC PATCH] UBI: fix rb_tree node comparison in add_map

2014-03-21 Thread Richard Weinberger
Am 21.03.2014 20:54, schrieb Mike Snitzer: > The comparisons used in add_vol() shouldn't be identical. Pretty sure > the following is correct but it is completely untested. > > Signed-off-by: Mike Snitzer > --- > drivers/mtd/ubi/fastmap.c |4 ++-- > 1 files changed, 2 insertions(+), 2 delet

[RFC PATCH] UBI: fix rb_tree node comparison in add_map

2014-03-21 Thread Mike Snitzer
The comparisons used in add_vol() shouldn't be identical. Pretty sure the following is correct but it is completely untested. Signed-off-by: Mike Snitzer --- drivers/mtd/ubi/fastmap.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) NOTE: I stumbled upon this code while implementi