Re: [RFC PATCH] always probe UART HW when options are not specified

2015-12-22 Thread Sebastian Frias
On 12/21/2015 05:50 PM, Sebastian Frias wrote: You need to use the format documented in Documentation/kernel-parameters.text: console=[KNL] Output console device and options. uart[8250],io,[,options] uart[8250],mmio,[,options] uart[8250],mmio16,[,options]

Re: [RFC PATCH] always probe UART HW when options are not specified

2015-12-21 Thread Sebastian Frias
Hi Peter, On 12/18/2015 04:03 PM, Peter Hurley wrote: I totally understand, we have the same constraints with our SDK's APIs but with major versions we drop old APIs that have been superseded. I would have thought that the switch to DT would have been a good opportunity to clean all that up,

Re: [RFC PATCH] always probe UART HW when options are not specified

2015-12-18 Thread Peter Hurley
On 12/18/2015 05:53 AM, Sebastian Frias wrote: > Hi Peter, > > On 12/17/2015 09:09 PM, Peter Hurley wrote: >>> It's confusing though, given there are multiple ways to express the same >>> thing. >>> I also found parts of the doc confusing in that regard as well. >>> ie: there's also a "stdout-pat

Re: [RFC PATCH] always probe UART HW when options are not specified

2015-12-18 Thread Sebastian Frias
Hi Peter, On 12/17/2015 09:09 PM, Peter Hurley wrote: It's confusing though, given there are multiple ways to express the same thing. I also found parts of the doc confusing in that regard as well. ie: there's also a "stdout-path" DT key. Yep. Thing is, once it goes into the command line and s

Re: [RFC PATCH] always probe UART HW when options are not specified

2015-12-17 Thread Peter Hurley
On 12/17/2015 10:21 AM, Sebastian Frias wrote: > On 12/17/2015 06:48 PM, Peter Hurley wrote: >> On 12/17/2015 08:48 AM, Sebastian Frias wrote: >>> On 12/17/2015 05:29 PM, Peter Hurley wrote: On 12/17/2015 07:15 AM, Sebastian Frias wrote: > --- > > I think there are a few minor bugs

Re: [RFC PATCH] always probe UART HW when options are not specified

2015-12-17 Thread Sebastian Frias
On 12/17/2015 06:21 PM, Greg Kroah-Hartman wrote: On Thu, Dec 17, 2015 at 05:48:42PM +0100, Sebastian Frias wrote: On 12/17/2015 05:29 PM, Peter Hurley wrote: On 12/17/2015 07:15 AM, Sebastian Frias wrote: --- I think there are a few minor bugs on the 8250 UART code. Below you can find a pat

Re: [RFC PATCH] always probe UART HW when options are not specified

2015-12-17 Thread Sebastian Frias
Hi Peter, On 12/17/2015 06:48 PM, Peter Hurley wrote: Hi Sebastian, On 12/17/2015 08:48 AM, Sebastian Frias wrote: On 12/17/2015 05:29 PM, Peter Hurley wrote: On 12/17/2015 07:15 AM, Sebastian Frias wrote: --- I think there are a few minor bugs on the 8250 UART code. Below you can find a p

Re: [RFC PATCH] always probe UART HW when options are not specified

2015-12-17 Thread Peter Hurley
Hi Sebastian, On 12/17/2015 08:48 AM, Sebastian Frias wrote: > On 12/17/2015 05:29 PM, Peter Hurley wrote: >> On 12/17/2015 07:15 AM, Sebastian Frias wrote: >>> --- >>> >>> I think there are a few minor bugs on the 8250 UART code. >>> >>> Below you can find a patch with a proposed solution. >>> >>

Re: [RFC PATCH] always probe UART HW when options are not specified

2015-12-17 Thread Greg Kroah-Hartman
On Thu, Dec 17, 2015 at 05:48:42PM +0100, Sebastian Frias wrote: > On 12/17/2015 05:29 PM, Peter Hurley wrote: > >On 12/17/2015 07:15 AM, Sebastian Frias wrote: > >>--- > >> > >>I think there are a few minor bugs on the 8250 UART code. > >> > >>Below you can find a patch with a proposed solution. >

Re: [RFC PATCH] always probe UART HW when options are not specified

2015-12-17 Thread Sebastian Frias
On 12/17/2015 05:29 PM, Peter Hurley wrote: On 12/17/2015 07:15 AM, Sebastian Frias wrote: --- I think there are a few minor bugs on the 8250 UART code. Below you can find a patch with a proposed solution. In a nutshell: - probe_baud from 87515772c33ee8a0cc08d984a7d2401eeff074cd was converted

Re: [RFC PATCH] always probe UART HW when options are not specified

2015-12-17 Thread Peter Hurley
On 12/17/2015 07:15 AM, Sebastian Frias wrote: > --- > > I think there are a few minor bugs on the 8250 UART code. > > Below you can find a patch with a proposed solution. > > In a nutshell: > - probe_baud from 87515772c33ee8a0cc08d984a7d2401eeff074cd was > converted into probe_port so that it r

Re: [RFC PATCH] always probe UART HW when options are not specified

2015-12-17 Thread Måns Rullgård
Sebastian Frias writes: > - reading/writing to UART_DLL/UART_DLM directly are converted to using > the read_dl/write_dl callbacks. This should be an obvious fix. Please send that as a separate patch. -- Måns Rullgård -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" i